Skip to content

Failures on Migrate void tests to Null Safety. #42169

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
lrhn opened this issue Jun 3, 2020 · 0 comments
Closed

Failures on Migrate void tests to Null Safety. #42169

lrhn opened this issue Jun 3, 2020 · 0 comments
Labels
legacy-area-front-end Legacy: Use area-dart-model instead. NNBD Issues related to NNBD Release

Comments

@lrhn
Copy link
Member

lrhn commented Jun 3, 2020

There are new test failures on Migrate void tests to Null Safety..

The tests

language/void/return_future_future_or_void_async_error1_test/none Pass (expected CompileTimeError)
language/void/return_future_or_future_or_void_sync_error2_test/none Pass (expected CompileTimeError)
language/void/return_future_or_void_sync_error4_test/none Pass (expected CompileTimeError)

are failing on configurations

cfe-strong-linux
cfe-weak-linux
dart2js-hostasserts-strong-linux-x64-d8
dart2js-hostasserts-weak-linux-x64-d8
dartdevk-strong-linux-release-chrome
dartdevk-weak-linux-release-chrome
dartk-strong-linux-debug-x64
dartk-strong-linux-release-x64
dartk-weak-asserts-linux-debug-x64
dartk-weak-asserts-linux-release-x64

The tests are generally checking that return; is not allowed unless the return type/future value type is void, dynamic or Null, and not, for example FutureOr<void>.

@lrhn lrhn added the legacy-area-front-end Legacy: Use area-dart-model instead. label Jun 3, 2020
@johnniwinther johnniwinther added the NNBD Issues related to NNBD Release label Jun 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
legacy-area-front-end Legacy: Use area-dart-model instead. NNBD Issues related to NNBD Release
Projects
None yet
Development

No branches or pull requests

2 participants