Skip to content

Ensure AOT apps for macOS ARM run correctly (dart compile exe) #42774

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
a-siva opened this issue Jul 21, 2020 · 12 comments
Closed

Ensure AOT apps for macOS ARM run correctly (dart compile exe) #42774

a-siva opened this issue Jul 21, 2020 · 12 comments
Assignees
Labels
area-vm Use area-vm for VM related issues, including code coverage, and the AOT and JIT backends. customer-dart-sass status-blocked Blocked from making progress by another (referenced) issue

Comments

@a-siva
Copy link
Contributor

a-siva commented Jul 21, 2020

Ensure dart2native apps generated for macOS ARM target work correctly on that platform.

@a-siva a-siva added the area-vm Use area-vm for VM related issues, including code coverage, and the AOT and JIT backends. label Jul 21, 2020
@a-siva a-siva added this to the Future milestone Aug 5, 2020
@alexmarkley
Copy link

@a-siva I would like to propose that there are two separate issues here:

  1. Future versions of dart2native should produce native code on Apple Silicon (and preferably "Universal" binaries) dart2native produces a Mach-O x86_64 binary even on Apple Silicon / DTK #43476

  2. Current versions of dart2native should produce x86_64 binaries that work correctly under the Rosetta translation environment: dart2native produces non-functional (crashing) binaries on Apple Silicon / DTK #43477

@mit-mit
Copy link
Member

mit-mit commented Sep 23, 2020

@mkustermann you duped both of #43476 and #43477 into this, but it seems reasonable to have a different timeline for Rosetta compatibility (most urgent) and full support for universal binaries? Or were you thinking we'd just got to universal binaries directly?

@mkustermann
Copy link
Member

@mit-mit I'm going through unlabeled issues and was aware that @a-siva has open bug for dart2native regarding Apple Silicon already (which I assume covers both aspects), which is why I merged it into here.

Apologies if I misunderstood the intend here. @a-siva If you want to track those issues separately, please re-open #43476 and #43477

@alexmarkley
Copy link

@mkustermann I agree with the general principle of keeping the issue queue clean and organized.

FWIW I think Rosetta support for existing binaries is pretty different from Universal binary support. They probably have very different priorities and work efforts associated with them. But that's just my guess. 😄

@bdkjones
Copy link

Hi everyone. It's been a few months since this was opened. Has any progress occurred? The milestone is still ambiguous and Apple Silicon Macs are about 30-45 days from being in the wild (if Apple's "by the end of the year" statement holds true). Thanks!

@gkjpettet
Copy link

Where are we with this? Three new Apple Silicon Macs are shipping next week and the MacBook Air is Apple's most popular computer.

@bdkjones
Copy link

bdkjones commented Feb 15, 2021

It’s been 5 months since anyone updated this issue and several projects are blocked on it. Apple Silicon is here.

Development takes time, but surely someone at Google/Dart has a plan they can share? Just knowing an ETA and that someone is handling this would be very helpful.

@mraleph mraleph assigned mraleph and a-siva and unassigned mraleph Feb 19, 2021
@mraleph mraleph added the status-blocked Blocked from making progress by another (referenced) issue label Feb 19, 2021
@mraleph
Copy link
Member

mraleph commented Feb 19, 2021

(@a-siva assigning to you to reflect that you are driving this)

In general before we can fix dart2native we should be able to produce a dart/dart_precompile_runtime binary for Mac OS ARM64 target - and we currently can't because we are blocked on https://bugs.fuchsia.dev/p/fuchsia/issues/detail?id=67614

@a-siva a-siva modified the milestones: Future, March Beta Release Feb 20, 2021
@bdkjones
Copy link

bdkjones commented Mar 3, 2021

@a-siva It looks like Rosetta might be going away in some parts of the world with the next update to macOS: https://twitter.com/SteveMoser/status/1366904041243041794?s=20

It would be nice if Dart could get on board before that happens.

@vsmenon
Copy link
Member

vsmenon commented Mar 23, 2021

Same q as #42773 - @a-siva @mit-mit - are we comfortable punting this to the next milestone? I think we discussed that since we're blocked.

@franklinyow
Copy link
Contributor

@a-siva Should this move out of April? Which Milestone we're looking at?

@mit-mit mit-mit changed the title Ensure AOT apps generated for macOS ARM run correctly (dart2native) Ensure AOT apps for macOS ARM run correctly (dart compile exe) Apr 20, 2021
@a-siva
Copy link
Contributor Author

a-siva commented Apr 20, 2021

This works now when we do local builds, marking as fixed. We have #42773 tracking the broader issue of building/testing the new configuration on the bots.

@a-siva a-siva closed this as completed Apr 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-vm Use area-vm for VM related issues, including code coverage, and the AOT and JIT backends. customer-dart-sass status-blocked Blocked from making progress by another (referenced) issue
Projects
None yet
Development

No branches or pull requests

10 participants