dds package should migrate to null safety

[jmagman]

dds 1.7.6 is not null safe:

sdk/pkg/dds/lib/dds.dart

Line 5 in 96cf91b

// @dart=2.10

This is preventing the flutter_tool from migrating its size analyzer library to null safety.
https://github.com/flutter/flutter/blob/6b3093b6afd6a47e57c07f7e3f701d5e97073fc8/packages/flutter_tools/lib/src/base/dds.dart#L9

\cc @bkonyi

[bkonyi]

Thanks for formally filing an issue for this. How urgently does this need to be migrated? It's on my radar, but I have a fairly involved DDS change in-flight right now which may take some time to land so I won't be able to get started on migration until that's done.

[jmagman]

Thanks for formally filing an issue for this. How urgently does this need to be migrated?

Not too urgent, though it is I believe the last unsafe package the tool depends on.

It's on my radar, but I have a fairly involved DDS change in-flight right now which may take some time to land so I won't be able to get started on migration until that's done.

Any idea of a general ETA for when that would be done? Are we talking weeks, months..?

[bkonyi]

This is the change in question that needs to land. It's quite large and is going through initial review, so hopefully it'll land in the next week or so. I'd say mid-May would be a conservative estimate.

[bkonyi]

@jmagman I've got a local version of DDS migrated but there's currently two packages that DDS depends on that haven't been migrated yet (package:devtools_shared and package:sse). Are you aiming to enable strong null safety at this point?

[jmagman]

package:devtools_shared and package:sse

(Note to self: flutter/devtools#2978 and dart-lang/tools#1645)

@bkonyi Would like to in the tool within the next few months. dds isn't currently the bottleneck, but I believe it is the last imported dependency that isn't null safe (though the tests also use a null unsafe version of mockito).

[bkonyi]

Okay, that's totally doable. I think I can have something published by end of next week, assuming the tree closures get resolved this week.

[bkonyi]

Reopening for now until 2.0.0 is published.

[bkonyi]

This seems to have rolled through into google3, so I've gone ahead and published as 2.0.0.

[jmagman]

This seems to have rolled through into google3, so I've gone ahead and published as 2.0.0.

Thanks!

On to the next... dart-lang/webdev#1327. 😄