Skip to content

Migrate pkg/compiler to null safety #50008

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Tracked by #49169
devoncarew opened this issue Sep 19, 2022 · 15 comments
Closed
Tracked by #49169

Migrate pkg/compiler to null safety #50008

devoncarew opened this issue Sep 19, 2022 · 15 comments
Labels
area-web-js Issues related to JavaScript support for Dart Web, including DDC, dart2js, and JS interop. web-dart2js

Comments

@devoncarew
Copy link
Member

This issues tracks migrating dart2js (pkg/compiler) to null safety; see #49169 for the general dart-lang repo tracking meta issue.

@devoncarew devoncarew added the area-web-js Issues related to JavaScript support for Dart Web, including DDC, dart2js, and JS interop. label Sep 19, 2022
@devoncarew
Copy link
Member Author

(post migration tasks can be tracked using #48820)

@sigmundch sigmundch changed the title Migrate pkg/dev_compiler to null safety Migrate pkg/compiler to null safety Sep 19, 2022
@sigmundch
Copy link
Member

Status as of 9/30/22 (files under pkg/compiler/lib/)

migrated total %
Files 246 330 74.55%
Lines 92845 164412 56.47%
Bytes 3170147 5720789 55.41%

@khyati82
Copy link

khyati82 commented Oct 7, 2022

@sigmundch - Is there a tentative eta on when this might be done?

@sigmundch
Copy link
Member

ETA is unclear at the moment.

Our initial goal was to complete this by November, however, recent high-priority internal demands on my team are taking our attention away from this. Our plan was to hold a team fixit once we reduce the pressure on the internal demands. Meanwhile, I only expect steady incremental progress.

Today's status:

migrated total %
Files 255 333 76.58%
Lines 95922 164865 58.18%
Bytes 3282311 5737107 57.21%

@sigmundch
Copy link
Member

Update: we continue to focus on other areas at the moment, but have made some progress. Current status:

migrated total %
Files 270 342 78.95%
Lines 103498 166045 62.33%
Bytes 3550347 5779222 61.43%

Most remaining items are in the following subfolders: inferrer*, ssa, js_backend, js_emitter

@sigmundch
Copy link
Member

inferrer folder is now migrated, ssa, js_backend, and js_emitter remain:

migrated total %
Files 263 325 80.92%
Lines 111538 164707 67.72%
Bytes 3841046 5734266 66.98%

@sigmundch
Copy link
Member

Lots of activity last week, updated stats on the pkg/compiler/lib/ folder:

migrated total %
Files 287 324 88.58%
Lines 129623 164394 78.85%
Bytes 4459214 5728895 77.84%

@sigmundch
Copy link
Member

Current status of the lib/ folder:

migrated total %
Files 310 324 95.68%
Lines 145806 164884 88.43%
Bytes 5048289 5748555 87.82%

Most remaining work are a couple big cycles in the SSA folder and a few entry point files before we start triaging runtime failures with sound null safety and before we start migrating unit tests.

@sigmundch
Copy link
Member

Current lib status:

migrated total %
Files 314 323 97.21%
Lines 153633 166104 92.49%
Bytes 5339523 5796163 92.12%

@mit-mit
Copy link
Member

mit-mit commented Feb 9, 2023

Hey @sigmundch got any updates?

@sigmundch
Copy link
Member

yes! @natebiggs pushed through and the lib migration is complete (100%) and the tests and tool folders are nearly complete (98% including data files that are likely to be kept unmigrated for test coverage purposes).

@natebiggs has a couple CLs in flight to enable sound null-safety for running the compiler both internally and in the sdk. He is on PTO this week, so I expect we will land them sometime in the next couple weeks.

@mit-mit
Copy link
Member

mit-mit commented Feb 9, 2023

Very cool, thanks!

@mit-mit
Copy link
Member

mit-mit commented Mar 6, 2023

Any updates @natebiggs ?

@biggs0125
Copy link

Ah yes forgot to update this bug, this is done!

@mit-mit
Copy link
Member

mit-mit commented Mar 6, 2023

WOOHOO 🥳, thanks!

@mit-mit mit-mit closed this as completed Mar 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-web-js Issues related to JavaScript support for Dart Web, including DDC, dart2js, and JS interop. web-dart2js
Projects
None yet
Development

No branches or pull requests

5 participants