Skip to content

[ddc] hide unsound flag if build requires it #50346

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
sigmundch opened this issue Oct 31, 2022 · 6 comments
Closed

[ddc] hide unsound flag if build requires it #50346

sigmundch opened this issue Oct 31, 2022 · 6 comments
Assignees
Labels
area-web-js Issues related to JavaScript support for Dart Web, including DDC, dart2js, and JS interop. P2 A bug or feature request we're likely to work on web-dev-compiler
Milestone

Comments

@sigmundch
Copy link
Member

Starting in Dart3.beta, the SDK will have a new build flag to determine whether an SDK supports unsound null safety on any of its commands. When the flag indicates that unsound mode is not supported, then DDC needs to provide an error if a user provides the --no-sound-null-safety flag.

@sigmundch sigmundch added P1 A high priority bug; for example, a single project is unusable or has many test failures web-dev-compiler area-web-js Issues related to JavaScript support for Dart Web, including DDC, dart2js, and JS interop. labels Oct 31, 2022
@sigmundch sigmundch added this to the Dart 3 beta milestone Oct 31, 2022
@nshahan
Copy link
Contributor

nshahan commented Oct 31, 2022

Is there an issue for adding the build flag that we can list here as blocking for now? Or if that has already landed, how can we tell if DDC is running a version that was built with it enabled?

@a-siva
Copy link
Contributor

a-siva commented Oct 31, 2022

I have created #50348 for the VM which would have the build rule changes etc. Would this be the issue that you are referring to above ?

@nshahan
Copy link
Contributor

nshahan commented Oct 31, 2022

I'm not sure. If I'm understanding correctly it seems like the DDC binary script will need to know if it is running as part of a Dart SDK that was built with a special build flag enabled. My expectation is that flag would be outside of the VM if it is passed as part of the SDK build.

@annagrin annagrin added P2 A bug or feature request we're likely to work on and removed P1 A high priority bug; for example, a single project is unusable or has many test failures labels Nov 14, 2022
@itsjustkevin
Copy link
Contributor

@nshahan are we planning this work still as we have changed how we are approaching the no-sound-null-safety flag?

@sigmundch
Copy link
Member Author

@nshahan - since we no longer include the unsound .dill files (since https://dart-review.googlesource.com/c/sdk/+/278999), is it fair to mark this one as complete?

@nshahan
Copy link
Contributor

nshahan commented Mar 21, 2023

I'm closing the issue because at the moment I'm not planning any more work here but with the caveat that there is still work in progress in the Flutter repo.

Running DDC is only supported via running builds with the Flutter Tool or build_web_compilers.

The unsound .dill files used by DDC have been removed from the packaged SDK.

@nshahan nshahan closed this as completed Mar 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-web-js Issues related to JavaScript support for Dart Web, including DDC, dart2js, and JS interop. P2 A bug or feature request we're likely to work on web-dev-compiler
Projects
None yet
Development

No branches or pull requests

5 participants