-
Notifications
You must be signed in to change notification settings - Fork 1.7k
[ddc] hide unsound flag if build requires it #50346
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Is there an issue for adding the build flag that we can list here as blocking for now? Or if that has already landed, how can we tell if DDC is running a version that was built with it enabled? |
I have created #50348 for the VM which would have the build rule changes etc. Would this be the issue that you are referring to above ? |
I'm not sure. If I'm understanding correctly it seems like the DDC binary script will need to know if it is running as part of a Dart SDK that was built with a special build flag enabled. My expectation is that flag would be outside of the VM if it is passed as part of the SDK build. |
@nshahan are we planning this work still as we have changed how we are approaching the |
@nshahan - since we no longer include the unsound .dill files (since https://dart-review.googlesource.com/c/sdk/+/278999), is it fair to mark this one as complete? |
I'm closing the issue because at the moment I'm not planning any more work here but with the caveat that there is still work in progress in the Flutter repo. Running DDC is only supported via running builds with the Flutter Tool or build_web_compilers.
The unsound .dill files used by DDC have been removed from the packaged SDK. |
Starting in Dart3.beta, the SDK will have a new build flag to determine whether an SDK supports unsound null safety on any of its commands. When the flag indicates that unsound mode is not supported, then DDC needs to provide an error if a user provides the
--no-sound-null-safety
flag.The text was updated successfully, but these errors were encountered: