Skip to content

[CP] Remove delay in removing file overlays. #51015

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
srawlins opened this issue Jan 13, 2023 · 4 comments
Closed

[CP] Remove delay in removing file overlays. #51015

srawlins opened this issue Jan 13, 2023 · 4 comments
Assignees
@vsmenon @itsjustkevin @mit-mit @athomas
Labels
cherry-pick-approved Label for approved cherrypick request legacy-area-analyzer Use area-devexp instead. merge-to-beta

Comments

@srawlins
Copy link
Member

Commit(s) to merge

97f5626

Target

beta

Prepared changelist for beta/stable

https://dart-review.googlesource.com/c/sdk/+/278993

Issue Description

On IDEs like IntelliJ and Android Studio, static analysis is not available for 10 seconds after a file save. This CL fixes this bug.

What is the fix

The fix is to remove the 10 second delay.

Why cherry-pick

This is a severe issue representing a severe regression starting in Dart 2.17 releases.

Risk

low

Issue link(s)

#50960 and #49107

Extra Info

No response
@srawlins srawlins added the cherry-pick-review Issue that need cherry pick triage to approve label Jan 13, 2023
@srawlins
Copy link
Member Author

srawlins commented Jan 13, 2023 •
edited
Loading

CC @mraleph @scheglov @jacob314

@a-siva
Copy link
Contributor

a-siva commented Jan 13, 2023

lgtm

1 similar comment
@mraleph
Copy link
Member

mraleph commented Jan 14, 2023

lgtm

@itsjustkevin itsjustkevin added cherry-pick-approved Label for approved cherrypick request merge-to-beta labels Jan 17, 2023
@srawlins
Copy link
Member Author

I believe this landed?

@a-siva a-siva added the legacy-area-analyzer Use area-devexp instead. label Jan 18, 2023
@whesse whesse removed the cherry-pick-review Issue that need cherry pick triage to approve label Jan 19, 2023
@whesse whesse closed this as completed Jan 19, 2023
@navaronbracke navaronbracke mentioned this issue Jan 29, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@vsmenon vsmenon

@itsjustkevin itsjustkevin

@mit-mit mit-mit

@athomas athomas

Labels
cherry-pick-approved Label for approved cherrypick request legacy-area-analyzer Use area-devexp instead. merge-to-beta
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
8 participants
@srawlins @mraleph @vsmenon @whesse @a-siva @itsjustkevin @mit-mit @athomas