Skip to content

CFE reports an incorrect old primitive equality error on co19/Language/Expressions/Constants/equals_expression_t03 #51688

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
munificent opened this issue Mar 9, 2023 · 0 comments
Assignees
Labels
legacy-area-front-end Legacy: Use area-dart-model instead.
Milestone

Comments

@munificent
Copy link
Member

We're rolling a bunch of a co19 updates in the Dart SDK. Most of the changes are related to patterns, but there are some related to the changes to constant equality. Prior to Dart 3.0, an == expression was only constant if the LHS was one of a fixed list of types. In 3.0, we loosened that to allow any type that has primitive equality (i.e. doesn't override ==).

The test co19/Language/Expressions/Constants/equals_expression_t03 has been updated to test that behavior, but it looks like CFE isn't implementing it yet and still reports an error based on the old constant equality rule.

@munificent munificent added the legacy-area-front-end Legacy: Use area-dart-model instead. label Mar 9, 2023
@munificent munificent added this to the Dart 3 beta 3 milestone Mar 9, 2023
@johnniwinther johnniwinther self-assigned this Mar 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
legacy-area-front-end Legacy: Use area-dart-model instead.
Projects
None yet
Development

No branches or pull requests

2 participants