Crash in AbstractType::IsStrictlyNonNullable on co19/LanguageFeatures/Patterns/matching_record_* tests

[alexmarkov]

There are new test failures on [co19] Roll co19 to e8141111c3315b0a9c151fcac0e14656dcfddac5.

The tests

co19/LanguageFeatures/Patterns/matching_record_A01_t01 Crash (expected Pass)
co19/LanguageFeatures/Patterns/matching_record_A02_t01 Crash (expected Pass)
co19/LanguageFeatures/Patterns/matching_record_A02_t02 Crash (expected Pass)

are failing on configurations

dartkp-strong-linux-release-simarm64
dartkp-strong-linux-release-x64
dartkp-strong-mac-release-simarm64
dartkp-strong-win-release-x64
dartkp-weak-asserts-linux-release-x64
dartkp-weak-asserts-win-release-x64

Log:

--- Command "vm_compile_to_kernel" (took 03.000924s):
DART_CONFIGURATION=ReleaseX64 /b/s/w/ir/pkg/vm/tool/gen_kernel --aot --platform=out/ReleaseX64/vm_platform_strong.dill -o /b/s/w/ir/out/ReleaseX64/generated_compilations/dartkp-strong-linux-release-x64/tests_co19_src_LanguageFeatures_Patterns_matching_record_A02_t01/out.dill /b/s/w/ir/tests/co19/src/LanguageFeatures/Patterns/matching_record_A02_t01.dart -Dtest_runner.configuration=dartkp-strong-linux-release-x64 --enable-experiment=patterns,records --packages=/b/s/w/ir/.dart_tool/package_config.json -Ddart.vm.product=false --sound-null-safety

exit code:
0

--- Command "precompiler" (took 02.000480s):
DART_CONFIGURATION=ReleaseX64 out/ReleaseX64/gen_snapshot --snapshot-kind=app-aot-assembly --assembly=/b/s/w/ir/out/ReleaseX64/generated_compilations/dartkp-strong-linux-release-x64/tests_co19_src_LanguageFeatures_Patterns_matching_record_A02_t01/out.S --sound-null-safety -Dtest_runner.configuration=dartkp-strong-linux-release-x64 --enable-experiment=patterns,records --ignore-unrecognized-flags --packages=/b/s/w/ir/.dart_tool/package_config.json /b/s/w/ir/out/ReleaseX64/generated_compilations/dartkp-strong-linux-release-x64/tests_co19_src_LanguageFeatures_Patterns_matching_record_A02_t01/out.dill

exit code:
-6

stderr:
===== CRASH =====
si_signo=Segmentation fault(11), si_code=1, si_addr=0x32445
version=3.0.0-edge.8912e037976c0005dd49727a4efd7cf1c660055d (be) (Fri Mar 17 09:19:24 2023 +0000) on "linux_x64"
pid=31737, thread=31737, isolate_group=isolate(0x557679d74000), isolate=(nil)((nil))
os=linux, arch=x64, comp=no, sim=no
isolate_instructions=0, vm_instructions=0
fp=7ffe0b256850, sp=7ffe0b256830, pc=5576776440d8
  pc 0x00005576776440d8 fp 0x00007ffe0b256850 dart::AbstractType::IsStrictlyNonNullable() const+0x18
  pc 0x0000557677a82853 fp 0x00007ffe0b256890 dart::LoadFieldInstr::ComputeType() const+0x153
  pc 0x0000557677a7db6e fp 0x00007ffe0b2568c0 dart::Value::Type()+0x3e
  pc 0x0000557677998d5f fp 0x00007ffe0b256930 dart::AotCallSpecializer::TryOptimizeIntegerOperation(dart::TemplateDartCall<0l>*, dart::Token::Kind)+0xdf
  pc 0x0000557677999d22 fp 0x00007ffe0b2569a0 dart::AotCallSpecializer::TryOptimizeStaticCallUsingStaticTypes(dart::StaticCallInstr*)+0x212
  pc 0x0000557677a8389d fp 0x00007ffe0b2569f0 dart::CallSpecializer::ApplyClassIds()+0xdd
  pc 0x0000557677a8e7a0 fp 0x00007ffe0b256a00 out/ReleaseX64/gen_snapshot+0xb597a0
  pc 0x0000557677a8dee0 fp 0x00007ffe0b256ac0 dart::CompilerPass::Run(dart::CompilerPassState*) const+0x120
  pc 0x0000557677a8e0e9 fp 0x00007ffe0b256ae0 dart::CompilerPass::RunInliningPipeline(dart::CompilerPass::PipelineMode, dart::CompilerPassState*)+0x19
  pc 0x0000557677a4b8fa fp 0x00007ffe0b257000 out/ReleaseX64/gen_snapshot+0xb168fa
  pc 0x0000557677a41748 fp 0x00007ffe0b257090 out/ReleaseX64/gen_snapshot+0xb0c748
  pc 0x0000557677a4dbbf fp 0x00007ffe0b257160 out/ReleaseX64/gen_snapshot+0xb18bbf
  pc 0x0000557677a461af fp 0x00007ffe0b2572b0 out/ReleaseX64/gen_snapshot+0xb111af
  pc 0x0000557677a45e11 fp 0x00007ffe0b2573a0 dart::FlowGraphInliner::Inline()+0x1c1
  pc 0x0000557677a8e754 fp 0x00007ffe0b257400 out/ReleaseX64/gen_snapshot+0xb59754
  pc 0x0000557677a8dee0 fp 0x00007ffe0b2574c0 dart::CompilerPass::Run(dart::CompilerPassState*) const+0x120
  pc 0x0000557677a8e357 fp 0x00007ffe0b2574e0 dart::CompilerPass::RunPipeline(dart::CompilerPass::PipelineMode, dart::CompilerPassState*)+0x97
  pc 0x00005576779aacf8 fp 0x00007ffe0b257b80 dart::PrecompileParsedFunctionHelper::Compile(dart::CompilationPipeline*)+0x588
  pc 0x00005576779ab575 fp 0x00007ffe0b258240 out/ReleaseX64/gen_snapshot+0xa76575
  pc 0x00005576779a7a97 fp 0x00007ffe0b258350 dart::Precompiler::CompileFunction(dart::Precompiler*, dart::Thread*, dart::Zone*, dart::Function const&)+0x177
  pc 0x00005576779a6a14 fp 0x00007ffe0b2583e0 dart::Precompiler::ProcessFunction(dart::Function const&)+0xe4
  pc 0x00005576779a2914 fp 0x00007ffe0b258430 dart::Precompiler::Iterate()+0x84
  pc 0x000055767799f977 fp 0x00007ffe0b258b70 dart::Precompiler::DoCompileAll()+0x1497
  pc 0x000055767799e478 fp 0x00007ffe0b259000 dart::Precompiler::CompileAll()+0xb8
  pc 0x0000557677b2ffb1 fp 0x00007ffe0b259160 Dart_Precompile+0x231
  pc 0x00005576774e6b71 fp 0x00007ffe0b2592f0 dart::bin::main(int, char**)+0x8e1
-- End of DumpStackTrace
=== Crash occurred when compiling file:///b/s/w/ir/tests/co19/src/LanguageFeatures/Patterns/matching_record_A02_t01.dart_::_main in AOT mode in ApplyClassIds pass
../../runtime/vm/object.cc: 20685: error: unreachable code
Aborting reentrant request for stack trace.

--- Re-run this test:
python3 tools/test.py -n dartkp-strong-linux-release-x64 co19/LanguageFeatures/Patterns/matching_record_A02_t01