Skip to content

Failures on Add nonNulls and indexed extensions on iterables. #51900

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
lrhn opened this issue Mar 30, 2023 · 0 comments
Closed

Failures on Add nonNulls and indexed extensions on iterables. #51900

lrhn opened this issue Mar 30, 2023 · 0 comments
Assignees
Labels
area-vm Use area-vm for VM related issues, including code coverage, and the AOT and JIT backends. type-bug Incorrect behavior (everything from a crash to more subtle misbehavior)

Comments

@lrhn
Copy link
Member

lrhn commented Mar 30, 2023

There are new test failures on Add nonNulls and indexed extensions on iterables..

The tests

lib/mirrors/mirrors_reader_test Crash (expected Pass)
service/valid_source_locations_test/dds RuntimeError (expected Pass)
service/valid_source_locations_test/service RuntimeError (expected Pass)

are failing on configurations

vm-linux-debug-x64
vm-linux-release-x64

The mirrors_reader_test crashes hard with:

 exit code: -6
 stderr:  ../../runtime/lib/mirrors.cc: 567: error: unreachable code
 version=3.0.0-edge.a7f2562b389d0939865fdbb4854b927861b88356 (be) (Thu Mar 30 10:29:22 2023 +0000) on "linux_x64"
 pid=29185, thread=29249, isolate_group=main(0x5582fda44000), isolate=main(0x5582fda45800)
 os=linux, arch=x64, comp=no, sim=no
 isolate_instructions=5582fa904c20, vm_instructions=5582fa904c20
 fp=7fe89a2fbcb0, sp=7fe89a2fbb78, pc=5582fad11e4c
   pc 0x00005582fad11e4c fp 0x00007fe89a2fbcb0 dart::Profiler::DumpStackTrace(void*)+0x7c
   pc 0x00005582fa904e14 fp 0x00007fe89a2fbd90 dart::Assert::Fail(char const*, ...) const+0x84
   pc 0x00005582faac4e21 fp 0x00007fe89a2fbdd0 out/DebugX64/dart+0x243ae21
   pc 0x00005582fabee8f8 fp 0x00007fe89a2fc4f0 dart::NativeEntry::BootstrapNativeCallWrapper(_Dart_NativeArguments*, void (*)(_Dart_NativeArguments*))+0xc8
   pc 0x00007fe8a2403014 fp 0x00007fe89a2fc538 Unknown symbol

The source-location tests fail with

   Invalid argument(s): Unrecognized instance kind: RecordType
   package:observatory/src/service/object.dart 2796:3   stringToInstanceKind
   package:observatory/src/service/object.dart 2926:12  Instance._update
   package:observatory/src/service/object.dart 388:5    ServiceObject.updateFromServiceMap
   package:observatory/src/service/object.dart          ServiceObject._fromMap
   package:observatory/src/service/object.dart 1545:25  Isolate.getFromMap
   package:observatory/src/service/object.dart 4759:22  _upgradeMap.<fn>
   dart:collection-patch/compact_hash.dart 625:13       _LinkedHashMapMixin.forEach
   package:observatory/src/service/object.dart 4757:7   _upgradeMap
   package:observatory/src/service/object.dart 4750:5   _upgradeCollection
   package:observatory/src/service/object.dart 2923:5   Instance._update
   package:observatory/src/service/object.dart 388:5    ServiceObject.updateFromServiceMap
   package:observatory/src/service/object.dart          ServiceObject._fromMap
   package:observatory/src/service/object.dart 1545:25  Isolate.getFromMap
   package:observatory/src/service/object.dart 4759:22  _upgradeMap.<fn>
   dart:collection-patch/compact_hash.dart 625:13       _LinkedHashMapMixin.forEach
   package:observatory/src/service/object.dart 4757:7   _upgradeMap
   package:observatory/src/service/object.dart 4750:5   _upgradeCollection
   package:observatory/src/service/object.dart 3205:5   ServiceFunction._update
   package:observatory/src/service/object.dart 388:5    ServiceObject.updateFromServiceMap
   package:observatory/src/service/object.dart 347:11   ServiceObject.reload.<fn>
   dart:async/zone.dart 1407:47                         _rootRunUnary

Likely both are not ready to see a record type.
I'm preapproving the failures for now.

@lrhn lrhn added area-vm Use area-vm for VM related issues, including code coverage, and the AOT and JIT backends. type-bug Incorrect behavior (everything from a crash to more subtle misbehavior) labels Mar 30, 2023
@alexmarkov alexmarkov self-assigned this Mar 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-vm Use area-vm for VM related issues, including code coverage, and the AOT and JIT backends. type-bug Incorrect behavior (everything from a crash to more subtle misbehavior)
Projects
None yet
Development

No branches or pull requests

2 participants