Change package:vm_service BoundVariable.value from "dynamic" to "Response" #51930
Labels
area-pkg
Used for miscellaneous pkg/ packages not associated with specific area- teams.
pkg-vm-service
Noted at #51916 (comment). The current type of
BoundVariable.value
is dynamic:sdk/pkg/vm_service/lib/src/vm_service.dart
Lines 3088 to 3089 in 57ba99c
All of the types it can be implement/extend
Response
so this could beResponse
.The problem with
dynamic
is that it's easy to pass to any function and get a runtime error (which is what #51916 was, assuming it was alwaysInstanceRef
).@bkonyi notes this code is generated so might not be trivial to know the types all share a common base.
The text was updated successfully, but these errors were encountered: