Skip to content

moving dart-lang/linter issues into this repo #57109

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
devoncarew opened this issue Nov 15, 2024 · 3 comments
Closed

moving dart-lang/linter issues into this repo #57109

devoncarew opened this issue Nov 15, 2024 · 3 comments
Labels
area-meta Cross-cutting, high-level issues (for tracking many other implementation issues, ...).

Comments

@devoncarew
Copy link
Member

Hi, as the tail end of #59165, we'll be moving the issues from dart-lang/linter into this repo.

Note that there are currently ~750 open issues in the linter repo. For people who are currently watching this repository (Watch > All Activity), that will create a lot of notifications. You may want to temporarily switch to the Participating and @mentions level of notifications to reduce the number of emails generated.

We'll likely do the move during the day of Monday, Nov. 18th (this coming Monday), and will close this issue when the move is complete; you could then restore normal notifications then.

@devoncarew devoncarew added the area-meta Cross-cutting, high-level issues (for tracking many other implementation issues, ...). label Nov 15, 2024
@devoncarew
Copy link
Member Author

The issue move is about half way through (we hit some rate limit issues during the move yesterday).

@devoncarew
Copy link
Member Author

This is now complete.

@gnprice
Copy link
Contributor

gnprice commented Nov 21, 2024

Here's a somewhat concerning GitHub bug that seems to have been exercised by the moves: it apparently caused an edit to a PR description in an unrelated repo.

I'm not sure there's any particular action to be taken on this. Mentioning it here partly in case anyone sees other examples, so that a pattern emerges. Hopefully the issue is rare and there weren't any other examples.


Specifically, the PR zulip/zulip-flutter#29, in a Zulip repo, had had a reference #28 to PR 28 in that repo. Yesterday it was edited to instead read dart-lang/sdk#57174, pointing to #57174 .

I suspect what happened is that #57174 was formerly issue 28 in dart-lang/linter, and so after the move some job inside GitHub was looking for references to the old dart-lang/linter#28 and updating them to point to #57174. And then, somehow, it picked up our reference to zulip/zulip-flutter#28, in another zulip/zulip-flutter PR, and decided that that was a reference to dart-lang/linter#28 and needed rewriting too.

We noticed the edit because GitHub sent a webhook for it, identifying @devoncarew as the user making the edit, and a bot of ours posted it like normal in our GitHub notification-firehose channel. The edit doesn't show up in the edit history for the PR in the GitHub web UI.

The linked issue #57174 is one that was moved from dart-lang/linter. Oddly, that move happened more than a day before the spurious edit. But given the attribution to @devoncarew (who did the move), I think the edit must still have been triggered by the move. Perhaps the rewrites of old references are done in a queued job that was just slow.

The issue is old, dated from 2015, so it seems plausible that it had been issue 28 in dart-lang/linter. (I don't know an easy way to check that.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-meta Cross-cutting, high-level issues (for tracking many other implementation issues, ...).
Projects
None yet
Development

No branches or pull requests

2 participants