Skip to content

Bad location caching for pubspec lint reporting. #57188

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
pq opened this issue Mar 2, 2015 · 1 comment
Closed

Bad location caching for pubspec lint reporting. #57188

pq opened this issue Mar 2, 2015 · 1 comment
Assignees
Labels
devexp-linter Issues with the analyzer's support for the linter package legacy-area-analyzer Use area-devexp instead. type-bug Incorrect behavior (everything from a crash to more subtle misbehavior)

Comments

@pq
Copy link
Member

pq commented Mar 2, 2015

Specifically, this

library library_names;

yields:

[lint] DO use `lowercase_with_underscores` for package names. (tool/rule.dart, line 1, col 6)

(And shouldn't.)

@pq pq added the type-bug Incorrect behavior (everything from a crash to more subtle misbehavior) label Mar 2, 2015
@pq pq self-assigned this Mar 2, 2015
@pq
Copy link
Member Author

pq commented Mar 2, 2015

Actually, I think this is a bad location caching issue. Specifically:

[lint] AVOID wrapping fields in getters and setters just to be "safe". (test/rules/unnecessary_getters_setters.dart, line 18, col 3)
[lint] AVOID wrapping fields in getters and setters just to be "safe". (test/rules/unnecessary_getters_setters.dart, line 7, col 3)
[lint] DO use `lowercase_with_underscores` for package names. (tool/rule.dart, line 1, col 6)

I think the last entry should be reporting the pubspec location.

@pq pq changed the title lowercase_with_underscores for packages Lint too aggressive. Bad location caching for pubspec lint reporting. Mar 2, 2015
@devoncarew devoncarew added devexp-linter Issues with the analyzer's support for the linter package legacy-area-analyzer Use area-devexp instead. labels Nov 18, 2024
@devoncarew devoncarew transferred this issue from dart-archive/linter Nov 18, 2024
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
devexp-linter Issues with the analyzer's support for the linter package legacy-area-analyzer Use area-devexp instead. type-bug Incorrect behavior (everything from a crash to more subtle misbehavior)
Projects
None yet
Development

No branches or pull requests

2 participants