Skip to content

camel_case_types/non_constant_identifier_names complaints about underline #57201

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
zoechi opened this issue Mar 16, 2015 · 3 comments
Closed
Labels
devexp-linter Issues with the analyzer's support for the linter package legacy-area-analyzer Use area-devexp instead.

Comments

@zoechi
Copy link
Contributor

zoechi commented Mar 16, 2015

/test/model/model.dart 105:7 [lint] DO name types using UpperCamelCase.
class Key_PathElement {
      ^^^^^^^^^^^^^^^
/test/model/to_datastore_converter.dart 25:25 [lint] DO name non-constant identifiers using lowerCamelCase.
  ds.CommitRequest_Mode commitRequest_Mode(CommitRequest_Mode mode) {
                        ^^^^^^^^^^^^^^^^^^
/test/model/to_datastore_converter.dart 87:45 [lint] DO name non-constant identifiers using lowerCamelCase.
  ds.BeginTransactionRequest_IsolationLevel beginTransactionRequest_IsolationLevel(
                                            ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

I have this in several class/attribute names to avoid ambiguity.
I think underlines should be valid if the casing of the first character is correct and lower- and uppercase letters are used.

@zoechi zoechi changed the title UpperCamelCase/lowerCamelCase complaints about underline camel_case_types/non_constant_identifier_names complaints about underline Mar 16, 2015
@pq
Copy link
Member

pq commented Mar 16, 2015

Hmmmm. The style guide is pretty specific on this one.

Classes, enums, and typedefs should capitalize the first letter of each word (including the first word), and use no separators.

In the names section.

Perhaps best to open an issue on the style guide?

@zoechi
Copy link
Contributor Author

zoechi commented Mar 17, 2015

done - dart-archive/www.dartlang.org#1284

@pq
Copy link
Member

pq commented Mar 17, 2015

Awesome. Thanks! For now, let's close this out with a special tag. If we see any movement on dart-archive/www.dartlang.org#1284, we can re-open.

@devoncarew devoncarew added devexp-linter Issues with the analyzer's support for the linter package legacy-area-analyzer Use area-devexp instead. labels Nov 18, 2024
@devoncarew devoncarew transferred this issue from dart-archive/linter Nov 18, 2024
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
devexp-linter Issues with the analyzer's support for the linter package legacy-area-analyzer Use area-devexp instead.
Projects
None yet
Development

No branches or pull requests

3 participants