Skip to content

the linter package should export a linter version #57909

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
devoncarew opened this issue Feb 20, 2019 · 6 comments
Closed

the linter package should export a linter version #57909

devoncarew opened this issue Feb 20, 2019 · 6 comments
Assignees
@pq
Labels
devexp-linter Issues with the analyzer's support for the linter package legacy-area-analyzer Use area-devexp instead.

Comments

@devoncarew
Copy link
Member

This would be incremented whenever a linter rule changes such that a line would generate different lints than before; or alternatively, incremented whenever a new version of the linter was ready to be rolled into the analyzer. The analysis driver would use this version in the summary cache signature.

cc @scheglov @pq
@pq pq self-assigned this Feb 20, 2019
@scheglov
Copy link
Contributor

Sounds good to me, let me know when linter will have this data, so that I could update the code that computes signatures.

@pq
Copy link
Member

pq commented Feb 20, 2019

https://dart-review.googlesource.com/c/sdk/+/93882

Once this (or something similar) lands, we'll need to publish a new analyzer and set this value from the linter but you should be able to start on the signature logic now (just discarding null version info).

@pq pq mentioned this issue Feb 20, 2019
Merged
@pq
Copy link
Member

pq commented Feb 21, 2019

Once this (or something similar) lands, we'll need to publish a new analyzer

@stereotype441: any other need for an analyzer roll or is one planned any time soon?

@bwilkerson
Copy link
Member

I have a CL nearly ready to send out that includes some changes that we want in a breaking change version. It's not terrible if we publish twice, but just FYI.

dart-bot referenced this issue Feb 21, 2019
@pq
linter version support
371d244 
See: https://github.com/dart-lang/linter/issues/1440

Change-Id: I0198ea52fb9d5680e76a462d25d7302cd4aa6be8
Reviewed-on: https://dart-review.googlesource.com/c/93882
Reviewed-by: Konstantin Shcheglov <[email protected]>
Commit-Queue: Phil Quitslund <[email protected]>
@scheglov
Copy link
Contributor

https://dart-review.googlesource.com/c/sdk/+/93844

dart-bot referenced this issue Feb 21, 2019
@scheglov
Include 'linterVersion' into AnalysisOption signature.
f5d43c4 
BTW, I'm in doubt about using global variable in AnalysisOption directly.

Maybe make it a writable option, like `lintRules`, so that we don't use
static data? I realize that most probably we set `lintRules` into
AnalysisOptions just because it is just convenient to separate registry
and enable rules, not because we want separation from static data.


[email protected], [email protected]

Bug: https://github.com/dart-lang/linter/issues/1440
Change-Id: I44f5c8cdc41eaead926fbbe250063c41bd888a78
Reviewed-on: https://dart-review.googlesource.com/c/93844
Reviewed-by: Brian Wilkerson <[email protected]>
Commit-Queue: Konstantin Shcheglov <[email protected]>
@pq pq mentioned this issue Feb 21, 2019
Open
@pq
Copy link
Member

pq commented Mar 6, 2019

Just getting back to closing the loop on this. All done. 👍

@pq pq closed this as completed Mar 6, 2019
@devoncarew devoncarew added devexp-linter Issues with the analyzer's support for the linter package legacy-area-analyzer Use area-devexp instead. labels Nov 18, 2024
@devoncarew devoncarew transferred this issue from dart-archive/linter Nov 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@pq pq

Labels
devexp-linter Issues with the analyzer's support for the linter package legacy-area-analyzer Use area-devexp instead.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@pq @scheglov @devoncarew @bwilkerson