Skip to content

Prepare for Dart 3 #2399

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
mit-mit opened this issue Dec 8, 2022 · 6 comments
Closed

Prepare for Dart 3 #2399

mit-mit opened this issue Dec 8, 2022 · 6 comments

Comments

@mit-mit
Copy link
Member

mit-mit commented Dec 8, 2022

The source currently contains several references to APIs scheduled for removal in Dart 3 (details here):

Can we move the min up to 3.0, and start working on a dev release version for this?

@jakemac53
Copy link
Contributor

jakemac53 commented Dec 8, 2022

Do we want to do a dev version or stable version? If the current stable is selectable on 3.x, then users will get that version over the dev version (unless they explicitly asked for the dev release, which they likely wouldn't know to do, they don't even directly depend on or import this package generally).

@mit-mit
Copy link
Member Author

mit-mit commented Dec 8, 2022

I think that a) landing changes here in the repo, and b) publishing a new dev, should be sufficient?

Or were you saying that tests might fail with 3.0 dev as they'd still be on the stable package?

@jakemac53
Copy link
Contributor

Right, we want users on 3.0 dev to pick this version up. We ended up going with a strategy where we don't depend on a dev sdk though, so the point is moot. We will just publish a stable version, with unchanged sdk deps.

Although now that I think about it maybe we should be upping the sdk constraint to <4.0.0 but that seems a bit premature to me at this juncture, and IIRC we went with a strategy where that won't be necessary anyways?

@jakemac53
Copy link
Contributor

cc @natebosch

@natebosch
Copy link
Member

Yeah I think keeping the SDK constraints where they are is best.

@mit-mit
Copy link
Member Author

mit-mit commented Dec 10, 2022

Looks like this was done in dart-archive/matcher@7e6a665 and already rolled in dart-lang/sdk@db636ba?

@mosuem mosuem transferred this issue from dart-archive/matcher Oct 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants