Add more than one variable arguments.

[ykmnkmi]

For example Element methods with variable arguments, instead of a single argument:

external void prepend(JSAny nodes);
external void append(JSAny nodes);
external void before(JSAny nodes);
external void after(JSAny nodes);

generate rest arguments as optional positional arguments:

external void prepend(JSAny node, [JSAny node2, JSAny node3, ..., JSAny node9]);
external void append(JSAny node, [JSAny node2, JSAny node3, ..., JSAny node9]);
external void before(JSAny node, [JSAny node2, JSAny node3, ..., JSAny node9]);
external void after(JSAny node, [JSAny node2, JSAny node3, ..., JSAny node9]);

I have some cases with 2 ~ 4 arguments. Currently, I use extension types and dart:js_interop (target.callMethod('append'.toJS, node1, node2);)

Also, nodes for a single argument name sounds like it expect list of nodes, instead one node.

[srujzs]

Indeed, it's misleading and we should really be providing multiple arguments. We've been typically implementing variadic arguments as ~4 arguments in the SDK (callMethod from dart:js_interop_unsafe for example) so I'm tempted to keep it aligned there.

[ykmnkmi]

@srujzs I can work on this issue.

[srujzs]

Thanks, go for it! Happy to review the PR and answer any questions about the translator.

#339 is also related if you think it would make sense to do at the same time.

[ykmnkmi]

@srujzs, how should I make the PR? Separately or all in one? There is also a new webref release with changes.

[srujzs]

Thanks! Just something I noticed on a quick pass: the first variadic parameter is also optional. It's allowed for an API to pass no parameters.

All in one (both the web_generator changes and the web changes) is preferable as it's useful to see the effects on web.

Let's avoid updating the webref version as it's a breaking change and will require a new package version. I'm tempted to also investigate using subfolders for newer versions instead of releasing a new version of web. That would avoid having to migrate the whole world every time.

[ykmnkmi]

Also, setTimeout is breaking, current binding

external int setTimeout(
    TimerHandler handler,
    JSAny? arguments, [
    int timeout
]);

new

external int setTimeout(
    TimerHandler handler, [
    int timeout,
    JSAny? argument1,
    JSAny? argument2,
    JSAny? argument3,
    JSAny? argument4,
  ]);

it is ok?

[srujzs]

(responded in PR)