Skip to content

Commit 302b6db

Browse files
authored
Remove reassemble invocation and publish 24.3.7 (#2598)
#2584 This can and should be done in Flutter tools.
1 parent 3e17660 commit 302b6db

File tree

5 files changed

+6
-46
lines changed

5 files changed

+6
-46
lines changed

Diff for: dwds/CHANGELOG.md

+4-1
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,7 @@
1-
## 24.3.7-wip
1+
## 24.3.7
2+
3+
- The registered extension `reassemble` is now no longer called when calling
4+
`reloadSources`. Users should call `reassemble` using `callServiceExtension`.
25

36
- `callServiceExtension` now checks the runtime for the list of registered
47
service extensions. It also now throws a `RPCError` with

Diff for: dwds/lib/src/injected/client.js

-32
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

Diff for: dwds/lib/src/version.dart

+1-1
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

Diff for: dwds/pubspec.yaml

+1-1
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
name: dwds
22
# Every time this changes you need to run `dart run build_runner build`.
3-
version: 24.3.7-wip
3+
version: 24.3.7
44
description: >-
55
A service that proxies between the Chrome debug protocol and the Dart VM
66
service protocol.

Diff for: dwds/web/reloader/ddc_library_bundle_restarter.dart

-11
Original file line numberDiff line numberDiff line change
@@ -30,13 +30,6 @@ extension type _Debugger._(JSObject _) implements JSObject {
3030
await invokeExtension(method, '{}').toDart;
3131
}
3232
}
33-
34-
Future<void> maybeInvokeFlutterReassemble() async {
35-
final method = 'ext.flutter.reassemble';
36-
if (extensionNames.toDart.contains(method.toJS)) {
37-
await invokeExtension(method, '{}').toDart;
38-
}
39-
}
4033
}
4134

4235
@JS('XMLHttpRequest')
@@ -92,9 +85,5 @@ class DdcLibraryBundleRestarter implements Restarter {
9285
}
9386
}
9487
await _dartDevEmbedder.hotReload(filesToLoad, librariesToReload).toDart;
95-
// TODO(srujzs): Reassembling is slow. It's roughly almost the time it takes
96-
// to recompile and do a hot reload. We should do some better profiling and
97-
// see if we can improve this.
98-
await _dartDevEmbedder.debugger.maybeInvokeFlutterReassemble();
9988
}
10089
}

0 commit comments

Comments
 (0)