Skip to content

Commit 8b7f9d3

Browse files
author
Anna Gringauze
authored
Re-enable weak webdev tests (#1960)
* Validate only needed summaries in expression_compiler_service * Move shared test functionality into test_common package * Rebase on master * Fix bad merge * Re-enable webdev weak null safety e2e tests
1 parent 83d8e47 commit 8b7f9d3

File tree

3 files changed

+9
-4
lines changed

3 files changed

+9
-4
lines changed

Diff for: webdev/pubspec.yaml

+2
Original file line numberDiff line numberDiff line change
@@ -45,6 +45,8 @@ dev_dependencies:
4545
build_verify: ^3.0.0
4646
build_version: ^2.1.1
4747
test: ^1.21.1
48+
test_common:
49+
path: ../test_common
4850
test_descriptor: ^2.0.0
4951
test_process: ^2.0.2
5052
webdriver: ^3.0.0

Diff for: webdev/test/e2e_test.dart

+2-4
Original file line numberDiff line numberDiff line change
@@ -180,8 +180,7 @@ void main() {
180180
await process.shouldExit(0);
181181

182182
await d.file('main.unsound.ddc.js', isNotEmpty).validate();
183-
// 'https://github.com/dart-lang/webdev/issues/1892'
184-
}, skip: true);
183+
});
185184
});
186185

187186
group('should build with --output=NONE', () {
@@ -507,8 +506,7 @@ void main() {
507506
}
508507
}, timeout: const Timeout.factor(2));
509508
});
510-
// 'https://github.com/dart-lang/webdev/issues/1892'
511-
}, skip: !soundNullSafety);
509+
});
512510
}
513511
});
514512
}

Diff for: webdev/test/test_utils.dart

+5
Original file line numberDiff line numberDiff line change
@@ -7,13 +7,18 @@ import 'dart:io';
77

88
import 'package:path/path.dart' as p;
99
import 'package:test/test.dart';
10+
import 'package:test_common/test_sdk_configuration.dart';
1011
import 'package:test_process/test_process.dart';
1112
import 'package:webdev/src/util.dart';
1213

1314
final _webdevBin = p.absolute(p.join('bin', 'webdev.dart'));
15+
final _sdkConfigurationProvider = TestSdkConfigurationProvider();
1416

1517
Future<TestProcess> runWebDev(List<String> args,
1618
{String? workingDirectory}) async {
19+
// Generate missing test assets in the SDK.
20+
await _sdkConfigurationProvider.configuration;
21+
1722
var fullArgs = [_webdevBin, ...args];
1823

1924
return TestProcess.start(dartPath, fullArgs,

0 commit comments

Comments
 (0)