Skip to content

Commit a7bc3fc

Browse files
author
Anna Gringauze
authored
Make dart-uri-file-uri test use sound null safety (#1959)
* Validate only needed summaries in expression_compiler_service * Make dart-uri-file-uri-test run with sound null safety
1 parent 464a8eb commit a7bc3fc

File tree

1 file changed

+9
-10
lines changed

1 file changed

+9
-10
lines changed

Diff for: dwds/test/dart_uri_file_uri_test.dart

+9-10
Original file line numberDiff line numberDiff line change
@@ -12,26 +12,25 @@ import 'package:test/test.dart';
1212
import 'fixtures/context.dart';
1313
import 'fixtures/utilities.dart';
1414

15-
final context = TestContext.withWeakNullSafety(
16-
packageName: '_testPackage',
15+
final context = TestContext.withSoundNullSafety(
16+
packageName: '_testPackageSound',
1717
webAssetsPath: 'web',
1818
dartEntryFileName: 'main.dart',
1919
htmlEntryFileName: 'index.html',
2020
);
2121

2222
/// The directory for the general _test package.
23-
final testDir = absolutePath(pathFromFixtures: p.join('_test'));
23+
final testDir = absolutePath(pathFromFixtures: p.join('_testSound'));
2424

2525
/// The directory for the _testPackage package (contained within dwds), which
2626
/// imports _test.
27-
final testPackageDir = absolutePath(pathFromFixtures: p.join('_testPackage'));
27+
final testPackageDir =
28+
absolutePath(pathFromFixtures: p.join('_testPackageSound'));
2829

2930
// This tests converting file Uris into our internal paths.
3031
//
3132
// These tests are separated out because we need a running isolate in order to
3233
// look up packages.
33-
// TODO(https://github.com/dart-lang/webdev/issues/1818): Switch test over for
34-
// testing sound null-safety.
3534
void main() {
3635
for (final compilationMode in CompilationMode.values) {
3736
group('$compilationMode |', () {
@@ -45,14 +44,14 @@ void main() {
4544
final serverPath =
4645
compilationMode == CompilationMode.frontendServer &&
4746
useDebuggerModuleNames
48-
? 'packages/_testPackage/lib/test_library.dart'
49-
: 'packages/_test_package/test_library.dart';
47+
? 'packages/_testPackageSound/lib/test_library.dart'
48+
: 'packages/_test_package_sound/test_library.dart';
5049

5150
final anotherServerPath =
5251
compilationMode == CompilationMode.frontendServer &&
5352
useDebuggerModuleNames
54-
? 'packages/_test/lib/library.dart'
55-
: 'packages/_test/library.dart';
53+
? 'packages/_testSound/lib/library.dart'
54+
: 'packages/_test_sound/library.dart';
5655

5756
setUpAll(() async {
5857
await context.setUp(

0 commit comments

Comments
 (0)