Skip to content

Commit c8b1cfa

Browse files
authored
[dwds] Split hot reload callback into 2, disable breakpoints in changed files, and publish 24.3.10 (#2606)
dart-lang/sdk#60186 Breakpoints are currently broken when doing a hot reload when files change. They either are not re-mapped or point to the wrong location. For now, we should disable them in the changed libraries. In order to do this, we split the hot reload implementation into 2 in order to get the list of changed libraries. The call to hot reload will later use the cached list to call out to the embedder. Note that this likely won't change any behavior. New JS files already don't have breakpoints, so this PR should be mostly about cleaning up bookkeeping.
1 parent 8d8413f commit c8b1cfa

12 files changed

+503
-219
lines changed

Diff for: dwds/CHANGELOG.md

+5
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,8 @@
1+
## 24.3.10
2+
3+
- Disabled breakpoints on changed files in a hot reload. They currently do not
4+
map to the correct locations or are broken, so disable them for now. - [#60186](https://github.com/dart-lang/sdk/issues/60186)
5+
16
## 24.3.9
27

38
- Renamed DWDS Injector parameter `enableDebuggingSupport` to `injectDebuggingSupportCode` for clearer intent.

0 commit comments

Comments
 (0)