Update package:lints and clean up library declarations (#2436)

Author: parlough

analysis_options.yaml

@@ -10,7 +10,6 @@ analyzer:
 linter:
   rules:
     - always_declare_return_types
-    - always_require_non_null_named_parameters
     - annotate_overrides
     - avoid_classes_with_only_static_members
     - avoid_empty_else
@@ -20,7 +19,6 @@ linter:
     - avoid_relative_lib_imports
     - avoid_renaming_method_parameters
     - avoid_return_types_on_setters
-    - avoid_returning_null
     - avoid_returning_null_for_void
     - avoid_returning_this
     - avoid_shadowing_type_parameters
@@ -63,7 +61,6 @@ linter:
     - prefer_conditional_assignment
     - prefer_const_constructors
     - prefer_contains
-    - prefer_equal_for_default_values
     - prefer_final_fields
     - prefer_for_elements_to_map_fromIterable
     - prefer_function_declarations_over_variables

dwds/debug_extension/web/background.dart

@@ -3,7 +3,7 @@
 // BSD-style license that can be found in the LICENSE file.
 
 @JS()
-library background;
+library;
 
 import 'package:dwds/data/debug_info.dart';
 import 'package:js/js.dart';

dwds/debug_extension/web/cider_connection.dart

@@ -3,7 +3,7 @@
 // BSD-style license that can be found in the LICENSE file.
 
 @JS()
-library cider_connection;
+library;
 
 import 'dart:convert';
 import 'dart:js_util';

dwds/debug_extension/web/copier.dart

@@ -3,7 +3,7 @@
 // BSD-style license that can be found in the LICENSE file.
 
 @JS()
-library copier;
+library;
 
 import 'dart:html';
 

dwds/debug_extension/web/cross_extension_communication.dart

@@ -3,7 +3,7 @@
 // BSD-style license that can be found in the LICENSE file.
 
 @JS()
-library cross_extension_communication;
+library;
 
 import 'package:js/js.dart';
 

dwds/debug_extension/web/debug_info.dart

@@ -3,7 +3,7 @@
 // BSD-style license that can be found in the LICENSE file.
 
 @JS()
-library debug_info;
+library;
 
 import 'dart:convert';
 import 'dart:html';

dwds/debug_extension/web/debug_session.dart

@@ -3,7 +3,7 @@
 // BSD-style license that can be found in the LICENSE file.
 
 @JS()
-library debug_session;
+library;
 
 import 'dart:async';
 import 'dart:convert';

dwds/debug_extension/web/detector.dart

@@ -3,7 +3,7 @@
 // BSD-style license that can be found in the LICENSE file.
 
 @JS()
-library detector;
+library;
 
 import 'dart:convert';
 import 'dart:html';

dwds/debug_extension/web/devtools.dart

@@ -3,7 +3,7 @@
 // BSD-style license that can be found in the LICENSE file.
 
 @JS()
-library devtools;
+library;
 
 import 'dart:html';
 

dwds/debug_extension/web/logger.dart

@@ -3,7 +3,7 @@
 // BSD-style license that can be found in the LICENSE file.
 
 @JS()
-library logger;
+library;
 
 import 'package:js/js.dart';
 

dwds/debug_extension/web/messaging.dart

@@ -3,7 +3,7 @@
 // BSD-style license that can be found in the LICENSE file.
 
 @JS()
-library messaging;
+library;
 
 import 'dart:async';
 import 'dart:convert';

dwds/debug_extension/web/panel.dart

@@ -3,7 +3,7 @@
 // BSD-style license that can be found in the LICENSE file.
 
 @JS()
-library panel;
+library;
 
 import 'dart:async';
 import 'dart:convert';

dwds/debug_extension/web/popup.dart

@@ -3,7 +3,7 @@
 // BSD-style license that can be found in the LICENSE file.
 
 @JS()
-library popup;
+library;
 
 import 'dart:async';
 import 'dart:convert';

dwds/debug_extension/web/storage.dart

@@ -3,7 +3,7 @@
 // BSD-style license that can be found in the LICENSE file.
 
 @JS()
-library storage;
+library;
 
 import 'dart:async';
 import 'dart:convert';

dwds/debug_extension/web/utils.dart

@@ -3,7 +3,7 @@
 // BSD-style license that can be found in the LICENSE file.
 
 @JS()
-library utils;
+library;
 
 import 'dart:async';
 import 'dart:js_util';

dwds/pubspec.yaml

@@ -50,7 +50,7 @@ dev_dependencies:
   frontend_server_common:
     path: ../frontend_server_common
   js: ^0.6.4
-  lints: ^3.0.0
+  lints: ^4.0.0
   pubspec_parse: ^1.2.0
   puppeteer: ^3.0.0
   stream_channel: ^2.1.0

dwds/test/build/ensure_version_test.dart

@@ -3,6 +3,8 @@
 // BSD-style license that can be found in the LICENSE file.
 
 @TestOn('vm')
+library;
+
 import 'dart:io';
 
 import 'package:dwds/src/version.dart';

dwds/test/build/min_sdk_test.dart

@@ -4,6 +4,8 @@
 
 @TestOn('vm')
 @Skip('Intended to run in analyze stage on stable SDK only, see mono_pkg.yaml')
+library;
+
 import 'dart:io';
 
 import 'package:pub_semver/pub_semver.dart';

dwds/test/build_daemon_breakpoint_test.dart

@@ -4,6 +4,7 @@
 
 @TestOn('vm')
 @Timeout(Duration(minutes: 2))
+library;
 
 import 'package:test/test.dart';
 import 'package:test_common/test_sdk_configuration.dart';

dwds/test/build_daemon_callstack_test.dart

@@ -4,6 +4,7 @@
 
 @TestOn('vm')
 @Timeout(Duration(minutes: 2))
+library;
 
 import 'package:test/test.dart';
 import 'package:test_common/logging.dart';

dwds/test/build_daemon_circular_evaluate_test.dart

@@ -4,6 +4,7 @@
 
 @TestOn('vm')
 @Timeout(Duration(minutes: 2))
+library;
 
 import 'package:test/test.dart';
 import 'package:test_common/test_sdk_configuration.dart';

dwds/test/build_daemon_evaluate_test.dart

@@ -5,6 +5,7 @@
 @Tags(['daily'])
 @TestOn('vm')
 @Timeout(Duration(minutes: 2))
+library;
 
 import 'package:test/test.dart';
 import 'package:test_common/test_sdk_configuration.dart';

dwds/test/chrome_proxy_service_test.dart

@@ -5,6 +5,8 @@
 @TestOn('vm')
 @Tags(['daily'])
 @Timeout(Duration(minutes: 2))
+library;
+
 import 'dart:async';
 import 'dart:convert';
 import 'dart:io';

dwds/test/dart_uri_file_uri_test.dart

@@ -4,6 +4,7 @@
 
 @TestOn('vm')
 @Timeout(Duration(minutes: 2))
+library;
 
 import 'package:dwds/src/utilities/dart_uri.dart';
 import 'package:path/path.dart' as p;

dwds/test/dart_uri_test.dart

@@ -4,6 +4,7 @@
 
 @TestOn('vm')
 @Timeout(Duration(minutes: 2))
+library;
 
 import 'package:dwds/src/utilities/dart_uri.dart';
 import 'package:path/path.dart' as p;

dwds/test/debug_extension_test.dart

@@ -10,6 +10,7 @@
   'windows': Skip('https://github.com/dart-lang/webdev/issues/711'),
   'linux': Skip('https://github.com/dart-lang/webdev/issues/2114'),
 })
+library;
 
 import 'package:dwds/src/connections/debug_connection.dart';
 import 'package:dwds/src/handlers/injector.dart';

dwds/test/debug_service_test.dart

@@ -4,6 +4,8 @@
 
 @TestOn('vm')
 @Timeout(Duration(minutes: 2))
+library;
+
 import 'dart:async';
 import 'dart:convert';
 import 'dart:io';

dwds/test/debugger_test.dart

@@ -4,6 +4,8 @@
 
 @TestOn('vm')
 @Timeout(Duration(minutes: 2))
+library;
+
 import 'dart:async';
 
 import 'package:dwds/src/debugging/debugger.dart';

dwds/test/devtools_test.dart

@@ -4,6 +4,8 @@
 
 @Timeout(Duration(minutes: 5))
 @TestOn('vm')
+library;
+
 import 'dart:io';
 
 import 'package:test/test.dart';

dwds/test/evaluate_circular_common.dart

@@ -4,6 +4,7 @@
 
 @TestOn('vm')
 @Timeout(Duration(minutes: 2))
+library;
 
 import 'package:test/test.dart';
 import 'package:test_common/logging.dart';

dwds/test/evaluate_common.dart

@@ -4,6 +4,8 @@
 
 @TestOn('vm')
 @Timeout(Duration(minutes: 2))
+library;
+
 import 'dart:async';
 
 import 'package:dwds/src/services/expression_evaluator.dart';

dwds/test/events_test.dart

@@ -3,6 +3,8 @@
 // BSD-style license that can be found in the LICENSE file.
 
 @Timeout(Duration(minutes: 2))
+library;
+
 import 'dart:async';
 import 'dart:io';
 

dwds/test/execution_context_test.dart

@@ -3,6 +3,8 @@
 // BSD-style license that can be found in the LICENSE file.
 
 @Timeout(Duration(minutes: 2))
+library;
+
 import 'dart:async';
 import 'dart:convert';
 

dwds/test/expression_compiler_service_test.dart

@@ -5,6 +5,8 @@
 @Tags(['daily'])
 @TestOn('vm')
 @Timeout(Duration(minutes: 2))
+library;
+
 import 'dart:async';
 import 'dart:convert';
 import 'dart:io';

dwds/test/expression_evaluator_test.dart

@@ -4,6 +4,8 @@
 
 @TestOn('vm')
 @Timeout(Duration(minutes: 2))
+library;
+
 import 'dart:async';
 
 import 'package:dwds/src/debugging/debugger.dart';

dwds/test/extension_backend_test.dart

@@ -3,6 +3,8 @@
 // BSD-style license that can be found in the LICENSE file.
 
 @Timeout(Duration(minutes: 2))
+library;
+
 import 'dart:async';
 
 import 'package:async/src/stream_queue.dart';

dwds/test/extension_debugger_test.dart

@@ -3,6 +3,8 @@
 // BSD-style license that can be found in the LICENSE file.
 
 @Timeout(Duration(minutes: 2))
+library;
+
 import 'dart:async';
 import 'dart:convert';
 

dwds/test/frontend_server_breakpoint_test.dart

@@ -4,6 +4,7 @@
 
 @TestOn('vm')
 @Timeout(Duration(minutes: 2))
+library;
 
 import 'package:test/test.dart';
 import 'package:test_common/logging.dart';

dwds/test/frontend_server_callstack_test.dart

@@ -4,6 +4,7 @@
 
 @TestOn('vm')
 @Timeout(Duration(minutes: 2))
+library;
 
 import 'package:test/test.dart';
 import 'package:test_common/logging.dart';

dwds/test/frontend_server_circular_evaluate_test.dart

@@ -4,6 +4,7 @@
 
 @TestOn('vm')
 @Timeout(Duration(minutes: 2))
+library;
 
 import 'dart:io';
 

dwds/test/frontend_server_ddc_evaluate_test.dart

@@ -5,6 +5,7 @@
 @Tags(['daily'])
 @TestOn('vm')
 @Timeout(Duration(minutes: 5))
+library;
 
 import 'dart:io';
 

dwds/test/frontend_server_evaluate_test.dart

@@ -5,6 +5,7 @@
 @Tags(['daily'])
 @TestOn('vm')
 @Timeout(Duration(minutes: 5))
+library;
 
 import 'dart:io';
 

dwds/test/handlers/asset_handler_test.dart

@@ -3,6 +3,7 @@
 // BSD-style license that can be found in the LICENSE file.
 
 @Timeout(Duration(minutes: 2))
+library;
 
 import 'package:shelf/shelf.dart';
 import 'package:test/test.dart';

dwds/test/handlers/injector_test.dart

@@ -3,6 +3,7 @@
 // BSD-style license that can be found in the LICENSE file.
 
 @Timeout(Duration(minutes: 2))
+library;
 
 import 'dart:io';