Skip to content

[DWDS] Restructure tests and use package:mockito to generate mocks #1643

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
5 tasks
elliette opened this issue Jun 10, 2022 · 1 comment
Open
5 tasks

[DWDS] Restructure tests and use package:mockito to generate mocks #1643

elliette opened this issue Jun 10, 2022 · 1 comment
Labels
P3 A lower priority bug or feature request package:dwds triaged

Comments

@elliette
Copy link
Contributor

Background context:

Currently the majority of tests in DWDS are integration tests using chromedriver. We have a few unit tests as well, some of which implement their own fakes (eg, in metadata_test.dart), others of which use the fakes from fakes.dart.

Suggested improvements:

  • separate directories for integration and unit tests
  • switch from the fakes in fakes.dart to mocks generated by package:mockito
  • move fakes from other test files into fakes.dart so that they can easily be found
  • increase number of unit tests
  • add documentation / general guidelines on writing and running tests
@bkonyi bkonyi added P3 A lower priority bug or feature request triaged labels Nov 13, 2024
@bkonyi
Copy link
Collaborator

bkonyi commented Nov 13, 2024

After talking with @elliette, it doesn't seem like we've made any progress on this issue. We should consider whether or not we actually want to use package:mockito since it involves a lot of code generation steps since Dart 3.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
P3 A lower priority bug or feature request package:dwds triaged
Projects
None yet
Development

No branches or pull requests

2 participants