From e48e5a287473fa4fde75bb6817e85fac1e4fe96f Mon Sep 17 00:00:00 2001 From: Anna Gringauze Date: Tue, 24 Aug 2021 15:25:54 -0700 Subject: [PATCH 1/3] Add running tests on min SDK and current beta - Run webdev tests on 2.13.4 and beta - prevent breaks on latest stable - prevent breaks on next SDK stable release - Run dwds tests on beta - prevents breaks on next SDK stable release --- .github/workflows/dart.yml | 309 +++++++++++++++++++++++++++++++++++-- dwds/dart_test.yaml | 1 - dwds/mono_pkg.yaml | 11 +- tool/ci.sh | 6 +- webdev/dart_test.yaml | 3 - webdev/mono_pkg.yaml | 7 + 6 files changed, 316 insertions(+), 21 deletions(-) diff --git a/.github/workflows/dart.yml b/.github/workflows/dart.yml index 926e02b4c..b4915ef5d 100644 --- a/.github/workflows/dart.yml +++ b/.github/workflows/dart.yml @@ -38,6 +38,71 @@ jobs: - name: mono_repo self validate run: dart pub global run mono_repo generate --validate job_002: + name: "analyzer_and_format; linux; Dart 2.13.4; PKG: webdev; `dart analyze --fatal-warnings .`" + runs-on: ubuntu-latest + steps: + - name: Cache Pub hosted dependencies + uses: actions/cache@v2.1.6 + with: + path: "~/.pub-cache/hosted" + key: "os:ubuntu-latest;pub-cache-hosted;dart:2.13.4;packages:webdev;commands:analyze_1" + restore-keys: | + os:ubuntu-latest;pub-cache-hosted;dart:2.13.4;packages:webdev + os:ubuntu-latest;pub-cache-hosted;dart:2.13.4 + os:ubuntu-latest;pub-cache-hosted + os:ubuntu-latest + - uses: dart-lang/setup-dart@v1.2 + with: + sdk: "2.13.4" + - id: checkout + uses: actions/checkout@v2.3.4 + - id: webdev_pub_upgrade + name: webdev; dart pub upgrade + if: "always() && steps.checkout.conclusion == 'success'" + working-directory: webdev + run: dart pub upgrade + - name: "webdev; dart analyze --fatal-warnings ." + if: "always() && steps.webdev_pub_upgrade.conclusion == 'success'" + working-directory: webdev + run: dart analyze --fatal-warnings . + job_003: + name: "analyzer_and_format; linux; Dart beta; PKGS: dwds, webdev; `dart analyze --fatal-warnings .`" + runs-on: ubuntu-latest + steps: + - name: Cache Pub hosted dependencies + uses: actions/cache@v2.1.6 + with: + path: "~/.pub-cache/hosted" + key: "os:ubuntu-latest;pub-cache-hosted;dart:beta;packages:dwds-webdev;commands:analyze_1" + restore-keys: | + os:ubuntu-latest;pub-cache-hosted;dart:beta;packages:dwds-webdev + os:ubuntu-latest;pub-cache-hosted;dart:beta + os:ubuntu-latest;pub-cache-hosted + os:ubuntu-latest + - uses: dart-lang/setup-dart@v1.2 + with: + sdk: beta + - id: checkout + uses: actions/checkout@v2.3.4 + - id: dwds_pub_upgrade + name: dwds; dart pub upgrade + if: "always() && steps.checkout.conclusion == 'success'" + working-directory: dwds + run: dart pub upgrade + - name: "dwds; dart analyze --fatal-warnings ." + if: "always() && steps.dwds_pub_upgrade.conclusion == 'success'" + working-directory: dwds + run: dart analyze --fatal-warnings . + - id: webdev_pub_upgrade + name: webdev; dart pub upgrade + if: "always() && steps.checkout.conclusion == 'success'" + working-directory: webdev + run: dart pub upgrade + - name: "webdev; dart analyze --fatal-warnings ." + if: "always() && steps.webdev_pub_upgrade.conclusion == 'success'" + working-directory: webdev + run: dart analyze --fatal-warnings . + job_004: name: "analyzer_and_format; linux; Dart dev; PKG: dwds; `dart format --output=none --set-exit-if-changed .`, `dart analyze --fatal-infos .`, `dart test test/build/ensure_version_test.dart`" runs-on: ubuntu-latest steps: @@ -45,7 +110,7 @@ jobs: uses: actions/cache@v2.1.6 with: path: "~/.pub-cache/hosted" - key: "os:ubuntu-latest;pub-cache-hosted;dart:dev;packages:dwds;commands:format-analyze-test_0" + key: "os:ubuntu-latest;pub-cache-hosted;dart:dev;packages:dwds;commands:format-analyze_0-test_0" restore-keys: | os:ubuntu-latest;pub-cache-hosted;dart:dev;packages:dwds os:ubuntu-latest;pub-cache-hosted;dart:dev @@ -73,7 +138,7 @@ jobs: if: "always() && steps.dwds_pub_upgrade.conclusion == 'success'" working-directory: dwds run: dart test test/build/ensure_version_test.dart - job_003: + job_005: name: "analyzer_and_format; linux; Dart dev; PKGS: example, fixtures/_webdevSmoke, frontend_server_client, frontend_server_common; `dart format --output=none --set-exit-if-changed .`, `dart analyze --fatal-infos .`" runs-on: ubuntu-latest steps: @@ -81,7 +146,7 @@ jobs: uses: actions/cache@v2.1.6 with: path: "~/.pub-cache/hosted" - key: "os:ubuntu-latest;pub-cache-hosted;dart:dev;packages:example-fixtures/_webdevSmoke-frontend_server_client-frontend_server_common;commands:format-analyze" + key: "os:ubuntu-latest;pub-cache-hosted;dart:dev;packages:example-fixtures/_webdevSmoke-frontend_server_client-frontend_server_common;commands:format-analyze_0" restore-keys: | os:ubuntu-latest;pub-cache-hosted;dart:dev;packages:example-fixtures/_webdevSmoke-frontend_server_client-frontend_server_common os:ubuntu-latest;pub-cache-hosted;dart:dev @@ -144,7 +209,7 @@ jobs: if: "always() && steps.frontend_server_common_pub_upgrade.conclusion == 'success'" working-directory: frontend_server_common run: dart analyze --fatal-infos . - job_004: + job_006: name: "analyzer_and_format; linux; Dart dev; PKG: webdev; `dart format --output=none --set-exit-if-changed .`, `dart analyze --fatal-infos .`, `dart test test/build/ensure_build_test.dart`" runs-on: ubuntu-latest steps: @@ -152,7 +217,7 @@ jobs: uses: actions/cache@v2.1.6 with: path: "~/.pub-cache/hosted" - key: "os:ubuntu-latest;pub-cache-hosted;dart:dev;packages:webdev;commands:format-analyze-test_2" + key: "os:ubuntu-latest;pub-cache-hosted;dart:dev;packages:webdev;commands:format-analyze_0-test_2" restore-keys: | os:ubuntu-latest;pub-cache-hosted;dart:dev;packages:webdev os:ubuntu-latest;pub-cache-hosted;dart:dev @@ -180,7 +245,124 @@ jobs: if: "always() && steps.webdev_pub_upgrade.conclusion == 'success'" working-directory: webdev run: dart test test/build/ensure_build_test.dart - job_005: + job_007: + name: "unit_test; linux; Dart 2.13.4; PKG: webdev; `Xvfb :99 -screen 0 1024x768x24 > /dev/null 2>&1 &`, `dart test -j 1`" + runs-on: ubuntu-latest + steps: + - name: Cache Pub hosted dependencies + uses: actions/cache@v2.1.6 + with: + path: "~/.pub-cache/hosted" + key: "os:ubuntu-latest;pub-cache-hosted;dart:2.13.4;packages:webdev;commands:command-test_3" + restore-keys: | + os:ubuntu-latest;pub-cache-hosted;dart:2.13.4;packages:webdev + os:ubuntu-latest;pub-cache-hosted;dart:2.13.4 + os:ubuntu-latest;pub-cache-hosted + os:ubuntu-latest + - uses: dart-lang/setup-dart@v1.2 + with: + sdk: "2.13.4" + - id: checkout + uses: actions/checkout@v2.3.4 + - id: webdev_pub_upgrade + name: webdev; dart pub upgrade + if: "always() && steps.checkout.conclusion == 'success'" + working-directory: webdev + run: dart pub upgrade + - name: "webdev; Xvfb :99 -screen 0 1024x768x24 > /dev/null 2>&1 &" + if: "always() && steps.webdev_pub_upgrade.conclusion == 'success'" + working-directory: webdev + run: "Xvfb :99 -screen 0 1024x768x24 > /dev/null 2>&1 &" + - name: "webdev; dart test -j 1" + if: "always() && steps.webdev_pub_upgrade.conclusion == 'success'" + working-directory: webdev + run: dart test -j 1 + needs: + - job_001 + - job_002 + - job_003 + - job_004 + - job_005 + - job_006 + job_008: + name: "unit_test; linux; Dart beta; PKG: dwds; `Xvfb :99 -screen 0 1024x768x24 > /dev/null 2>&1 &`, `dart test`" + runs-on: ubuntu-latest + steps: + - name: Cache Pub hosted dependencies + uses: actions/cache@v2.1.6 + with: + path: "~/.pub-cache/hosted" + key: "os:ubuntu-latest;pub-cache-hosted;dart:beta;packages:dwds;commands:command-test_1" + restore-keys: | + os:ubuntu-latest;pub-cache-hosted;dart:beta;packages:dwds + os:ubuntu-latest;pub-cache-hosted;dart:beta + os:ubuntu-latest;pub-cache-hosted + os:ubuntu-latest + - uses: dart-lang/setup-dart@v1.2 + with: + sdk: beta + - id: checkout + uses: actions/checkout@v2.3.4 + - id: dwds_pub_upgrade + name: dwds; dart pub upgrade + if: "always() && steps.checkout.conclusion == 'success'" + working-directory: dwds + run: dart pub upgrade + - name: "dwds; Xvfb :99 -screen 0 1024x768x24 > /dev/null 2>&1 &" + if: "always() && steps.dwds_pub_upgrade.conclusion == 'success'" + working-directory: dwds + run: "Xvfb :99 -screen 0 1024x768x24 > /dev/null 2>&1 &" + - name: dwds; dart test + if: "always() && steps.dwds_pub_upgrade.conclusion == 'success'" + working-directory: dwds + run: dart test + needs: + - job_001 + - job_002 + - job_003 + - job_004 + - job_005 + - job_006 + job_009: + name: "unit_test; linux; Dart beta; PKG: webdev; `Xvfb :99 -screen 0 1024x768x24 > /dev/null 2>&1 &`, `dart test -j 1`" + runs-on: ubuntu-latest + steps: + - name: Cache Pub hosted dependencies + uses: actions/cache@v2.1.6 + with: + path: "~/.pub-cache/hosted" + key: "os:ubuntu-latest;pub-cache-hosted;dart:beta;packages:webdev;commands:command-test_3" + restore-keys: | + os:ubuntu-latest;pub-cache-hosted;dart:beta;packages:webdev + os:ubuntu-latest;pub-cache-hosted;dart:beta + os:ubuntu-latest;pub-cache-hosted + os:ubuntu-latest + - uses: dart-lang/setup-dart@v1.2 + with: + sdk: beta + - id: checkout + uses: actions/checkout@v2.3.4 + - id: webdev_pub_upgrade + name: webdev; dart pub upgrade + if: "always() && steps.checkout.conclusion == 'success'" + working-directory: webdev + run: dart pub upgrade + - name: "webdev; Xvfb :99 -screen 0 1024x768x24 > /dev/null 2>&1 &" + if: "always() && steps.webdev_pub_upgrade.conclusion == 'success'" + working-directory: webdev + run: "Xvfb :99 -screen 0 1024x768x24 > /dev/null 2>&1 &" + - name: "webdev; dart test -j 1" + if: "always() && steps.webdev_pub_upgrade.conclusion == 'success'" + working-directory: webdev + run: dart test -j 1 + needs: + - job_001 + - job_002 + - job_003 + - job_004 + - job_005 + - job_006 + job_010: name: "unit_test; linux; Dart dev; PKG: dwds; `Xvfb :99 -screen 0 1024x768x24 > /dev/null 2>&1 &`, `dart test`" runs-on: ubuntu-latest steps: @@ -217,7 +399,9 @@ jobs: - job_002 - job_003 - job_004 - job_006: + - job_005 + - job_006 + job_011: name: "unit_test; linux; Dart dev; PKG: frontend_server_client; `dart test`" runs-on: ubuntu-latest steps: @@ -250,7 +434,9 @@ jobs: - job_002 - job_003 - job_004 - job_007: + - job_005 + - job_006 + job_012: name: "unit_test; linux; Dart dev; PKG: webdev; `Xvfb :99 -screen 0 1024x768x24 > /dev/null 2>&1 &`, `dart test -j 1`" runs-on: ubuntu-latest steps: @@ -287,7 +473,9 @@ jobs: - job_002 - job_003 - job_004 - job_008: + - job_005 + - job_006 + job_013: name: "unit_test; linux; Dart stable; PKG: frontend_server_client; `dart test`" runs-on: ubuntu-latest steps: @@ -320,7 +508,84 @@ jobs: - job_002 - job_003 - job_004 - job_009: + - job_005 + - job_006 + job_014: + name: "unit_test; windows; Dart 2.13.4; PKG: webdev; `dart test -j 1`" + runs-on: windows-latest + steps: + - uses: dart-lang/setup-dart@v1.2 + with: + sdk: "2.13.4" + - id: checkout + uses: actions/checkout@v2.3.4 + - id: webdev_pub_upgrade + name: webdev; dart pub upgrade + if: "always() && steps.checkout.conclusion == 'success'" + working-directory: webdev + run: dart pub upgrade + - name: "webdev; dart test -j 1" + if: "always() && steps.webdev_pub_upgrade.conclusion == 'success'" + working-directory: webdev + run: dart test -j 1 + needs: + - job_001 + - job_002 + - job_003 + - job_004 + - job_005 + - job_006 + job_015: + name: "unit_test; windows; Dart beta; PKG: dwds; `dart test`" + runs-on: windows-latest + steps: + - uses: dart-lang/setup-dart@v1.2 + with: + sdk: beta + - id: checkout + uses: actions/checkout@v2.3.4 + - id: dwds_pub_upgrade + name: dwds; dart pub upgrade + if: "always() && steps.checkout.conclusion == 'success'" + working-directory: dwds + run: dart pub upgrade + - name: dwds; dart test + if: "always() && steps.dwds_pub_upgrade.conclusion == 'success'" + working-directory: dwds + run: dart test + needs: + - job_001 + - job_002 + - job_003 + - job_004 + - job_005 + - job_006 + job_016: + name: "unit_test; windows; Dart beta; PKG: webdev; `dart test -j 1`" + runs-on: windows-latest + steps: + - uses: dart-lang/setup-dart@v1.2 + with: + sdk: beta + - id: checkout + uses: actions/checkout@v2.3.4 + - id: webdev_pub_upgrade + name: webdev; dart pub upgrade + if: "always() && steps.checkout.conclusion == 'success'" + working-directory: webdev + run: dart pub upgrade + - name: "webdev; dart test -j 1" + if: "always() && steps.webdev_pub_upgrade.conclusion == 'success'" + working-directory: webdev + run: dart test -j 1 + needs: + - job_001 + - job_002 + - job_003 + - job_004 + - job_005 + - job_006 + job_017: name: "unit_test; windows; Dart dev; PKG: dwds; `dart test`" runs-on: windows-latest steps: @@ -343,7 +608,9 @@ jobs: - job_002 - job_003 - job_004 - job_010: + - job_005 + - job_006 + job_018: name: "unit_test; windows; Dart dev; PKG: frontend_server_client; `dart test`" runs-on: windows-latest steps: @@ -366,7 +633,9 @@ jobs: - job_002 - job_003 - job_004 - job_011: + - job_005 + - job_006 + job_019: name: "unit_test; windows; Dart dev; PKG: webdev; `dart test -j 1`" runs-on: windows-latest steps: @@ -389,7 +658,9 @@ jobs: - job_002 - job_003 - job_004 - job_012: + - job_005 + - job_006 + job_020: name: "unit_test; windows; Dart stable; PKG: frontend_server_client; `dart test`" runs-on: windows-latest steps: @@ -412,7 +683,9 @@ jobs: - job_002 - job_003 - job_004 - job_013: + - job_005 + - job_006 + job_021: name: Notify failure runs-on: ubuntu-latest if: "(github.event_name == 'push' || github.event_name == 'schedule') && failure()" @@ -436,3 +709,11 @@ jobs: - job_010 - job_011 - job_012 + - job_013 + - job_014 + - job_015 + - job_016 + - job_017 + - job_018 + - job_019 + - job_020 diff --git a/dwds/dart_test.yaml b/dwds/dart_test.yaml index ca8256556..479dd5834 100644 --- a/dwds/dart_test.yaml +++ b/dwds/dart_test.yaml @@ -3,4 +3,3 @@ retry: 3 tags: extension: # Extension tests require configuration, so we may exclude. - dev-sdk: # Tests that require dev SDK to pass, we may exclude them for stable SDK. diff --git a/dwds/mono_pkg.yaml b/dwds/mono_pkg.yaml index a5d10893d..061d48578 100644 --- a/dwds/mono_pkg.yaml +++ b/dwds/mono_pkg.yaml @@ -6,11 +6,18 @@ stages: - analyze: --fatal-infos . - test: test/build/ensure_version_test.dart dart: dev + - group: + - analyze: --fatal-warnings . + dart: beta - unit_test: - group: - command: Xvfb :99 -screen 0 1024x768x24 > /dev/null 2>&1 & - test: - dart: dev + dart: + - dev + - beta - test: os: windows - dart: dev + dart: + - dev + - beta diff --git a/tool/ci.sh b/tool/ci.sh index 716288c72..b323e6bc7 100755 --- a/tool/ci.sh +++ b/tool/ci.sh @@ -67,10 +67,14 @@ for PKG in ${PKGS}; do echo echo -e "\033[1mPKG: ${PKG}; TASK: ${TASK}\033[22m" case ${TASK} in - analyze) + analyze_0) echo 'dart analyze --fatal-infos .' dart analyze --fatal-infos . || EXIT_CODE=$? ;; + analyze_1) + echo 'dart analyze --fatal-warnings .' + dart analyze --fatal-warnings . || EXIT_CODE=$? + ;; command) echo 'Xvfb :99 -screen 0 1024x768x24 > /dev/null 2>&1 &' Xvfb :99 -screen 0 1024x768x24 > /dev/null 2>&1 & || EXIT_CODE=$? diff --git a/webdev/dart_test.yaml b/webdev/dart_test.yaml index 101eac048..d0577a31e 100644 --- a/webdev/dart_test.yaml +++ b/webdev/dart_test.yaml @@ -1,5 +1,2 @@ retry: 3 -tags: - dev-sdk: # Tests that require dev SDK to pass, we may exclude them for stable SDK. - unreleased-sdk: # Tests that require unpublished SDK to pass, so we may exclude them for stable and dev SDK. diff --git a/webdev/mono_pkg.yaml b/webdev/mono_pkg.yaml index 663173645..6890a5b0d 100644 --- a/webdev/mono_pkg.yaml +++ b/webdev/mono_pkg.yaml @@ -4,6 +4,8 @@ dart: # minimum SDK version defined in the webdev pubspec. # This ensures we do not accidentally break users upon # release of webdev. + - 2.13.4 + - beta - dev stages: @@ -13,6 +15,11 @@ stages: - analyze: --fatal-infos . - test: test/build/ensure_build_test.dart dart: dev + - group: + - analyze: --fatal-warnings . + dart: + - beta + - 2.13.4 - unit_test: - group: - command: Xvfb :99 -screen 0 1024x768x24 > /dev/null 2>&1 & From 75ab6da4b23bc02325f51772959689ccafbb6bb5 Mon Sep 17 00:00:00 2001 From: Anna Gringauze Date: Wed, 25 Aug 2021 10:38:12 -0700 Subject: [PATCH 2/3] Require min SDK constraint to match current stable - Run tests in CI for stable and dev - Move tests on beta to a sheduled job instead of on PR - Add tests to ensure that min SDK constraint in webdev and dwds matches major and minor versions of the current stable. --- .github/workflows/dart.yml | 529 +++++++++++++++++++--------- dwds/mono_pkg.yaml | 19 +- dwds/test/build/min_sdk_test.dart | 31 ++ example/pubspec.yaml | 3 +- mono_repo.yaml | 6 +- tool/ci.sh | 16 +- webdev/mono_pkg.yaml | 32 +- webdev/test/build/min_sdk_test.dart | 31 ++ 8 files changed, 465 insertions(+), 202 deletions(-) create mode 100644 dwds/test/build/min_sdk_test.dart create mode 100644 webdev/test/build/min_sdk_test.dart diff --git a/.github/workflows/dart.yml b/.github/workflows/dart.yml index b4915ef5d..99655d388 100644 --- a/.github/workflows/dart.yml +++ b/.github/workflows/dart.yml @@ -38,71 +38,6 @@ jobs: - name: mono_repo self validate run: dart pub global run mono_repo generate --validate job_002: - name: "analyzer_and_format; linux; Dart 2.13.4; PKG: webdev; `dart analyze --fatal-warnings .`" - runs-on: ubuntu-latest - steps: - - name: Cache Pub hosted dependencies - uses: actions/cache@v2.1.6 - with: - path: "~/.pub-cache/hosted" - key: "os:ubuntu-latest;pub-cache-hosted;dart:2.13.4;packages:webdev;commands:analyze_1" - restore-keys: | - os:ubuntu-latest;pub-cache-hosted;dart:2.13.4;packages:webdev - os:ubuntu-latest;pub-cache-hosted;dart:2.13.4 - os:ubuntu-latest;pub-cache-hosted - os:ubuntu-latest - - uses: dart-lang/setup-dart@v1.2 - with: - sdk: "2.13.4" - - id: checkout - uses: actions/checkout@v2.3.4 - - id: webdev_pub_upgrade - name: webdev; dart pub upgrade - if: "always() && steps.checkout.conclusion == 'success'" - working-directory: webdev - run: dart pub upgrade - - name: "webdev; dart analyze --fatal-warnings ." - if: "always() && steps.webdev_pub_upgrade.conclusion == 'success'" - working-directory: webdev - run: dart analyze --fatal-warnings . - job_003: - name: "analyzer_and_format; linux; Dart beta; PKGS: dwds, webdev; `dart analyze --fatal-warnings .`" - runs-on: ubuntu-latest - steps: - - name: Cache Pub hosted dependencies - uses: actions/cache@v2.1.6 - with: - path: "~/.pub-cache/hosted" - key: "os:ubuntu-latest;pub-cache-hosted;dart:beta;packages:dwds-webdev;commands:analyze_1" - restore-keys: | - os:ubuntu-latest;pub-cache-hosted;dart:beta;packages:dwds-webdev - os:ubuntu-latest;pub-cache-hosted;dart:beta - os:ubuntu-latest;pub-cache-hosted - os:ubuntu-latest - - uses: dart-lang/setup-dart@v1.2 - with: - sdk: beta - - id: checkout - uses: actions/checkout@v2.3.4 - - id: dwds_pub_upgrade - name: dwds; dart pub upgrade - if: "always() && steps.checkout.conclusion == 'success'" - working-directory: dwds - run: dart pub upgrade - - name: "dwds; dart analyze --fatal-warnings ." - if: "always() && steps.dwds_pub_upgrade.conclusion == 'success'" - working-directory: dwds - run: dart analyze --fatal-warnings . - - id: webdev_pub_upgrade - name: webdev; dart pub upgrade - if: "always() && steps.checkout.conclusion == 'success'" - working-directory: webdev - run: dart pub upgrade - - name: "webdev; dart analyze --fatal-warnings ." - if: "always() && steps.webdev_pub_upgrade.conclusion == 'success'" - working-directory: webdev - run: dart analyze --fatal-warnings . - job_004: name: "analyzer_and_format; linux; Dart dev; PKG: dwds; `dart format --output=none --set-exit-if-changed .`, `dart analyze --fatal-infos .`, `dart test test/build/ensure_version_test.dart`" runs-on: ubuntu-latest steps: @@ -138,7 +73,7 @@ jobs: if: "always() && steps.dwds_pub_upgrade.conclusion == 'success'" working-directory: dwds run: dart test test/build/ensure_version_test.dart - job_005: + job_003: name: "analyzer_and_format; linux; Dart dev; PKGS: example, fixtures/_webdevSmoke, frontend_server_client, frontend_server_common; `dart format --output=none --set-exit-if-changed .`, `dart analyze --fatal-infos .`" runs-on: ubuntu-latest steps: @@ -209,7 +144,7 @@ jobs: if: "always() && steps.frontend_server_common_pub_upgrade.conclusion == 'success'" working-directory: frontend_server_common run: dart analyze --fatal-infos . - job_006: + job_004: name: "analyzer_and_format; linux; Dart dev; PKG: webdev; `dart format --output=none --set-exit-if-changed .`, `dart analyze --fatal-infos .`, `dart test test/build/ensure_build_test.dart`" runs-on: ubuntu-latest steps: @@ -217,7 +152,7 @@ jobs: uses: actions/cache@v2.1.6 with: path: "~/.pub-cache/hosted" - key: "os:ubuntu-latest;pub-cache-hosted;dart:dev;packages:webdev;commands:format-analyze_0-test_2" + key: "os:ubuntu-latest;pub-cache-hosted;dart:dev;packages:webdev;commands:format-analyze_0-test_4" restore-keys: | os:ubuntu-latest;pub-cache-hosted;dart:dev;packages:webdev os:ubuntu-latest;pub-cache-hosted;dart:dev @@ -245,62 +180,68 @@ jobs: if: "always() && steps.webdev_pub_upgrade.conclusion == 'success'" working-directory: webdev run: dart test test/build/ensure_build_test.dart - job_007: - name: "unit_test; linux; Dart 2.13.4; PKG: webdev; `Xvfb :99 -screen 0 1024x768x24 > /dev/null 2>&1 &`, `dart test -j 1`" + job_005: + name: "analyzer_and_format; linux; Dart stable; PKGS: dwds, webdev; `dart analyze .`, `dart test test/build/min_sdk_test.dart --run-skipped`" runs-on: ubuntu-latest steps: - name: Cache Pub hosted dependencies uses: actions/cache@v2.1.6 with: path: "~/.pub-cache/hosted" - key: "os:ubuntu-latest;pub-cache-hosted;dart:2.13.4;packages:webdev;commands:command-test_3" + key: "os:ubuntu-latest;pub-cache-hosted;dart:stable;packages:dwds-webdev;commands:analyze_1-test_1" restore-keys: | - os:ubuntu-latest;pub-cache-hosted;dart:2.13.4;packages:webdev - os:ubuntu-latest;pub-cache-hosted;dart:2.13.4 + os:ubuntu-latest;pub-cache-hosted;dart:stable;packages:dwds-webdev + os:ubuntu-latest;pub-cache-hosted;dart:stable os:ubuntu-latest;pub-cache-hosted os:ubuntu-latest - uses: dart-lang/setup-dart@v1.2 with: - sdk: "2.13.4" + sdk: stable - id: checkout uses: actions/checkout@v2.3.4 + - id: dwds_pub_upgrade + name: dwds; dart pub upgrade + if: "always() && steps.checkout.conclusion == 'success'" + working-directory: dwds + run: dart pub upgrade + - name: dwds; dart analyze . + if: "always() && steps.dwds_pub_upgrade.conclusion == 'success'" + working-directory: dwds + run: dart analyze . + - name: "dwds; dart test test/build/min_sdk_test.dart --run-skipped" + if: "always() && steps.dwds_pub_upgrade.conclusion == 'success'" + working-directory: dwds + run: dart test test/build/min_sdk_test.dart --run-skipped - id: webdev_pub_upgrade name: webdev; dart pub upgrade if: "always() && steps.checkout.conclusion == 'success'" working-directory: webdev run: dart pub upgrade - - name: "webdev; Xvfb :99 -screen 0 1024x768x24 > /dev/null 2>&1 &" + - name: webdev; dart analyze . if: "always() && steps.webdev_pub_upgrade.conclusion == 'success'" working-directory: webdev - run: "Xvfb :99 -screen 0 1024x768x24 > /dev/null 2>&1 &" - - name: "webdev; dart test -j 1" + run: dart analyze . + - name: "webdev; dart test test/build/min_sdk_test.dart --run-skipped" if: "always() && steps.webdev_pub_upgrade.conclusion == 'success'" working-directory: webdev - run: dart test -j 1 - needs: - - job_001 - - job_002 - - job_003 - - job_004 - - job_005 - - job_006 - job_008: - name: "unit_test; linux; Dart beta; PKG: dwds; `Xvfb :99 -screen 0 1024x768x24 > /dev/null 2>&1 &`, `dart test`" + run: dart test test/build/min_sdk_test.dart --run-skipped + job_006: + name: "unit_test; linux; Dart dev; PKG: dwds; `Xvfb :99 -screen 0 1024x768x24 > /dev/null 2>&1 &`, `dart test`" runs-on: ubuntu-latest steps: - name: Cache Pub hosted dependencies uses: actions/cache@v2.1.6 with: path: "~/.pub-cache/hosted" - key: "os:ubuntu-latest;pub-cache-hosted;dart:beta;packages:dwds;commands:command-test_1" + key: "os:ubuntu-latest;pub-cache-hosted;dart:dev;packages:dwds;commands:command-test_2" restore-keys: | - os:ubuntu-latest;pub-cache-hosted;dart:beta;packages:dwds - os:ubuntu-latest;pub-cache-hosted;dart:beta + os:ubuntu-latest;pub-cache-hosted;dart:dev;packages:dwds + os:ubuntu-latest;pub-cache-hosted;dart:dev os:ubuntu-latest;pub-cache-hosted os:ubuntu-latest - uses: dart-lang/setup-dart@v1.2 with: - sdk: beta + sdk: dev - id: checkout uses: actions/checkout@v2.3.4 - id: dwds_pub_upgrade @@ -322,24 +263,57 @@ jobs: - job_003 - job_004 - job_005 - - job_006 - job_009: - name: "unit_test; linux; Dart beta; PKG: webdev; `Xvfb :99 -screen 0 1024x768x24 > /dev/null 2>&1 &`, `dart test -j 1`" + job_007: + name: "unit_test; linux; Dart dev; PKG: frontend_server_client; `dart test`" runs-on: ubuntu-latest steps: - name: Cache Pub hosted dependencies uses: actions/cache@v2.1.6 with: path: "~/.pub-cache/hosted" - key: "os:ubuntu-latest;pub-cache-hosted;dart:beta;packages:webdev;commands:command-test_3" + key: "os:ubuntu-latest;pub-cache-hosted;dart:dev;packages:frontend_server_client;commands:test_2" restore-keys: | - os:ubuntu-latest;pub-cache-hosted;dart:beta;packages:webdev - os:ubuntu-latest;pub-cache-hosted;dart:beta + os:ubuntu-latest;pub-cache-hosted;dart:dev;packages:frontend_server_client + os:ubuntu-latest;pub-cache-hosted;dart:dev os:ubuntu-latest;pub-cache-hosted os:ubuntu-latest - uses: dart-lang/setup-dart@v1.2 with: - sdk: beta + sdk: dev + - id: checkout + uses: actions/checkout@v2.3.4 + - id: frontend_server_client_pub_upgrade + name: frontend_server_client; dart pub upgrade + if: "always() && steps.checkout.conclusion == 'success'" + working-directory: frontend_server_client + run: dart pub upgrade + - name: frontend_server_client; dart test + if: "always() && steps.frontend_server_client_pub_upgrade.conclusion == 'success'" + working-directory: frontend_server_client + run: dart test + needs: + - job_001 + - job_002 + - job_003 + - job_004 + - job_005 + job_008: + name: "unit_test; linux; Dart dev; PKG: webdev; `Xvfb :99 -screen 0 1024x768x24 > /dev/null 2>&1 &`, `dart test -j 1`" + runs-on: ubuntu-latest + steps: + - name: Cache Pub hosted dependencies + uses: actions/cache@v2.1.6 + with: + path: "~/.pub-cache/hosted" + key: "os:ubuntu-latest;pub-cache-hosted;dart:dev;packages:webdev;commands:command-test_3" + restore-keys: | + os:ubuntu-latest;pub-cache-hosted;dart:dev;packages:webdev + os:ubuntu-latest;pub-cache-hosted;dart:dev + os:ubuntu-latest;pub-cache-hosted + os:ubuntu-latest + - uses: dart-lang/setup-dart@v1.2 + with: + sdk: dev - id: checkout uses: actions/checkout@v2.3.4 - id: webdev_pub_upgrade @@ -361,24 +335,23 @@ jobs: - job_003 - job_004 - job_005 - - job_006 - job_010: - name: "unit_test; linux; Dart dev; PKG: dwds; `Xvfb :99 -screen 0 1024x768x24 > /dev/null 2>&1 &`, `dart test`" + job_009: + name: "unit_test; linux; Dart stable; PKG: dwds; `Xvfb :99 -screen 0 1024x768x24 > /dev/null 2>&1 &`, `dart test`" runs-on: ubuntu-latest steps: - name: Cache Pub hosted dependencies uses: actions/cache@v2.1.6 with: path: "~/.pub-cache/hosted" - key: "os:ubuntu-latest;pub-cache-hosted;dart:dev;packages:dwds;commands:command-test_1" + key: "os:ubuntu-latest;pub-cache-hosted;dart:stable;packages:dwds;commands:command-test_2" restore-keys: | - os:ubuntu-latest;pub-cache-hosted;dart:dev;packages:dwds - os:ubuntu-latest;pub-cache-hosted;dart:dev + os:ubuntu-latest;pub-cache-hosted;dart:stable;packages:dwds + os:ubuntu-latest;pub-cache-hosted;dart:stable os:ubuntu-latest;pub-cache-hosted os:ubuntu-latest - uses: dart-lang/setup-dart@v1.2 with: - sdk: dev + sdk: stable - id: checkout uses: actions/checkout@v2.3.4 - id: dwds_pub_upgrade @@ -400,24 +373,23 @@ jobs: - job_003 - job_004 - job_005 - - job_006 - job_011: - name: "unit_test; linux; Dart dev; PKG: frontend_server_client; `dart test`" + job_010: + name: "unit_test; linux; Dart stable; PKG: frontend_server_client; `dart test`" runs-on: ubuntu-latest steps: - name: Cache Pub hosted dependencies uses: actions/cache@v2.1.6 with: path: "~/.pub-cache/hosted" - key: "os:ubuntu-latest;pub-cache-hosted;dart:dev;packages:frontend_server_client;commands:test_1" + key: "os:ubuntu-latest;pub-cache-hosted;dart:stable;packages:frontend_server_client;commands:test_2" restore-keys: | - os:ubuntu-latest;pub-cache-hosted;dart:dev;packages:frontend_server_client - os:ubuntu-latest;pub-cache-hosted;dart:dev + os:ubuntu-latest;pub-cache-hosted;dart:stable;packages:frontend_server_client + os:ubuntu-latest;pub-cache-hosted;dart:stable os:ubuntu-latest;pub-cache-hosted os:ubuntu-latest - uses: dart-lang/setup-dart@v1.2 with: - sdk: dev + sdk: stable - id: checkout uses: actions/checkout@v2.3.4 - id: frontend_server_client_pub_upgrade @@ -435,24 +407,23 @@ jobs: - job_003 - job_004 - job_005 - - job_006 - job_012: - name: "unit_test; linux; Dart dev; PKG: webdev; `Xvfb :99 -screen 0 1024x768x24 > /dev/null 2>&1 &`, `dart test -j 1`" + job_011: + name: "unit_test; linux; Dart stable; PKG: webdev; `Xvfb :99 -screen 0 1024x768x24 > /dev/null 2>&1 &`, `dart test -j 1`" runs-on: ubuntu-latest steps: - name: Cache Pub hosted dependencies uses: actions/cache@v2.1.6 with: path: "~/.pub-cache/hosted" - key: "os:ubuntu-latest;pub-cache-hosted;dart:dev;packages:webdev;commands:command-test_3" + key: "os:ubuntu-latest;pub-cache-hosted;dart:stable;packages:webdev;commands:command-test_3" restore-keys: | - os:ubuntu-latest;pub-cache-hosted;dart:dev;packages:webdev - os:ubuntu-latest;pub-cache-hosted;dart:dev + os:ubuntu-latest;pub-cache-hosted;dart:stable;packages:webdev + os:ubuntu-latest;pub-cache-hosted;dart:stable os:ubuntu-latest;pub-cache-hosted os:ubuntu-latest - uses: dart-lang/setup-dart@v1.2 with: - sdk: dev + sdk: stable - id: checkout uses: actions/checkout@v2.3.4 - id: webdev_pub_upgrade @@ -474,24 +445,37 @@ jobs: - job_003 - job_004 - job_005 - - job_006 - job_013: - name: "unit_test; linux; Dart stable; PKG: frontend_server_client; `dart test`" - runs-on: ubuntu-latest + job_012: + name: "unit_test; windows; Dart dev; PKG: dwds; `dart test`" + runs-on: windows-latest steps: - - name: Cache Pub hosted dependencies - uses: actions/cache@v2.1.6 + - uses: dart-lang/setup-dart@v1.2 with: - path: "~/.pub-cache/hosted" - key: "os:ubuntu-latest;pub-cache-hosted;dart:stable;packages:frontend_server_client;commands:test_1" - restore-keys: | - os:ubuntu-latest;pub-cache-hosted;dart:stable;packages:frontend_server_client - os:ubuntu-latest;pub-cache-hosted;dart:stable - os:ubuntu-latest;pub-cache-hosted - os:ubuntu-latest + sdk: dev + - id: checkout + uses: actions/checkout@v2.3.4 + - id: dwds_pub_upgrade + name: dwds; dart pub upgrade + if: "always() && steps.checkout.conclusion == 'success'" + working-directory: dwds + run: dart pub upgrade + - name: dwds; dart test + if: "always() && steps.dwds_pub_upgrade.conclusion == 'success'" + working-directory: dwds + run: dart test + needs: + - job_001 + - job_002 + - job_003 + - job_004 + - job_005 + job_013: + name: "unit_test; windows; Dart dev; PKG: frontend_server_client; `dart test`" + runs-on: windows-latest + steps: - uses: dart-lang/setup-dart@v1.2 with: - sdk: stable + sdk: dev - id: checkout uses: actions/checkout@v2.3.4 - id: frontend_server_client_pub_upgrade @@ -509,14 +493,13 @@ jobs: - job_003 - job_004 - job_005 - - job_006 job_014: - name: "unit_test; windows; Dart 2.13.4; PKG: webdev; `dart test -j 1`" + name: "unit_test; windows; Dart dev; PKG: webdev; `dart test -j 1`" runs-on: windows-latest steps: - uses: dart-lang/setup-dart@v1.2 with: - sdk: "2.13.4" + sdk: dev - id: checkout uses: actions/checkout@v2.3.4 - id: webdev_pub_upgrade @@ -534,14 +517,13 @@ jobs: - job_003 - job_004 - job_005 - - job_006 job_015: - name: "unit_test; windows; Dart beta; PKG: dwds; `dart test`" + name: "unit_test; windows; Dart stable; PKG: dwds; `dart test`" runs-on: windows-latest steps: - uses: dart-lang/setup-dart@v1.2 with: - sdk: beta + sdk: stable - id: checkout uses: actions/checkout@v2.3.4 - id: dwds_pub_upgrade @@ -559,14 +541,37 @@ jobs: - job_003 - job_004 - job_005 - - job_006 job_016: - name: "unit_test; windows; Dart beta; PKG: webdev; `dart test -j 1`" + name: "unit_test; windows; Dart stable; PKG: frontend_server_client; `dart test`" runs-on: windows-latest steps: - uses: dart-lang/setup-dart@v1.2 with: - sdk: beta + sdk: stable + - id: checkout + uses: actions/checkout@v2.3.4 + - id: frontend_server_client_pub_upgrade + name: frontend_server_client; dart pub upgrade + if: "always() && steps.checkout.conclusion == 'success'" + working-directory: frontend_server_client + run: dart pub upgrade + - name: frontend_server_client; dart test + if: "always() && steps.frontend_server_client_pub_upgrade.conclusion == 'success'" + working-directory: frontend_server_client + run: dart test + needs: + - job_001 + - job_002 + - job_003 + - job_004 + - job_005 + job_017: + name: "unit_test; windows; Dart stable; PKG: webdev; `dart test -j 1`" + runs-on: windows-latest + steps: + - uses: dart-lang/setup-dart@v1.2 + with: + sdk: stable - id: checkout uses: actions/checkout@v2.3.4 - id: webdev_pub_upgrade @@ -584,14 +589,23 @@ jobs: - job_003 - job_004 - job_005 - - job_006 - job_017: - name: "unit_test; windows; Dart dev; PKG: dwds; `dart test`" - runs-on: windows-latest + job_018: + name: "beta_cron; linux; Dart beta; PKG: dwds; `Xvfb :99 -screen 0 1024x768x24 > /dev/null 2>&1 &`, `dart test -j 1`" + runs-on: ubuntu-latest steps: + - name: Cache Pub hosted dependencies + uses: actions/cache@v2.1.6 + with: + path: "~/.pub-cache/hosted" + key: "os:ubuntu-latest;pub-cache-hosted;dart:beta;packages:dwds;commands:command-test_3" + restore-keys: | + os:ubuntu-latest;pub-cache-hosted;dart:beta;packages:dwds + os:ubuntu-latest;pub-cache-hosted;dart:beta + os:ubuntu-latest;pub-cache-hosted + os:ubuntu-latest - uses: dart-lang/setup-dart@v1.2 with: - sdk: dev + sdk: beta - id: checkout uses: actions/checkout@v2.3.4 - id: dwds_pub_upgrade @@ -599,10 +613,15 @@ jobs: if: "always() && steps.checkout.conclusion == 'success'" working-directory: dwds run: dart pub upgrade - - name: dwds; dart test + - name: "dwds; Xvfb :99 -screen 0 1024x768x24 > /dev/null 2>&1 &" if: "always() && steps.dwds_pub_upgrade.conclusion == 'success'" working-directory: dwds - run: dart test + run: "Xvfb :99 -screen 0 1024x768x24 > /dev/null 2>&1 &" + - name: "dwds; dart test -j 1" + if: "always() && steps.dwds_pub_upgrade.conclusion == 'success'" + working-directory: dwds + run: dart test -j 1 + if: "github.event_name == 'schedule'" needs: - job_001 - job_002 @@ -610,24 +629,50 @@ jobs: - job_004 - job_005 - job_006 - job_018: - name: "unit_test; windows; Dart dev; PKG: frontend_server_client; `dart test`" - runs-on: windows-latest + - job_007 + - job_008 + - job_009 + - job_010 + - job_011 + - job_012 + - job_013 + - job_014 + - job_015 + - job_016 + - job_017 + job_019: + name: "beta_cron; linux; Dart beta; PKG: webdev; `Xvfb :99 -screen 0 1024x768x24 > /dev/null 2>&1 &`, `dart test -j 1`" + runs-on: ubuntu-latest steps: + - name: Cache Pub hosted dependencies + uses: actions/cache@v2.1.6 + with: + path: "~/.pub-cache/hosted" + key: "os:ubuntu-latest;pub-cache-hosted;dart:beta;packages:webdev;commands:command-test_3" + restore-keys: | + os:ubuntu-latest;pub-cache-hosted;dart:beta;packages:webdev + os:ubuntu-latest;pub-cache-hosted;dart:beta + os:ubuntu-latest;pub-cache-hosted + os:ubuntu-latest - uses: dart-lang/setup-dart@v1.2 with: - sdk: dev + sdk: beta - id: checkout uses: actions/checkout@v2.3.4 - - id: frontend_server_client_pub_upgrade - name: frontend_server_client; dart pub upgrade + - id: webdev_pub_upgrade + name: webdev; dart pub upgrade if: "always() && steps.checkout.conclusion == 'success'" - working-directory: frontend_server_client + working-directory: webdev run: dart pub upgrade - - name: frontend_server_client; dart test - if: "always() && steps.frontend_server_client_pub_upgrade.conclusion == 'success'" - working-directory: frontend_server_client - run: dart test + - name: "webdev; Xvfb :99 -screen 0 1024x768x24 > /dev/null 2>&1 &" + if: "always() && steps.webdev_pub_upgrade.conclusion == 'success'" + working-directory: webdev + run: "Xvfb :99 -screen 0 1024x768x24 > /dev/null 2>&1 &" + - name: "webdev; dart test -j 1" + if: "always() && steps.webdev_pub_upgrade.conclusion == 'success'" + working-directory: webdev + run: dart test -j 1 + if: "github.event_name == 'schedule'" needs: - job_001 - job_002 @@ -635,13 +680,81 @@ jobs: - job_004 - job_005 - job_006 - job_019: - name: "unit_test; windows; Dart dev; PKG: webdev; `dart test -j 1`" - runs-on: windows-latest + - job_007 + - job_008 + - job_009 + - job_010 + - job_011 + - job_012 + - job_013 + - job_014 + - job_015 + - job_016 + - job_017 + job_020: + name: "beta_cron; linux; Dart beta; PKG: dwds; `dart analyze .`" + runs-on: ubuntu-latest steps: + - name: Cache Pub hosted dependencies + uses: actions/cache@v2.1.6 + with: + path: "~/.pub-cache/hosted" + key: "os:ubuntu-latest;pub-cache-hosted;dart:beta;packages:dwds;commands:analyze_1" + restore-keys: | + os:ubuntu-latest;pub-cache-hosted;dart:beta;packages:dwds + os:ubuntu-latest;pub-cache-hosted;dart:beta + os:ubuntu-latest;pub-cache-hosted + os:ubuntu-latest - uses: dart-lang/setup-dart@v1.2 with: - sdk: dev + sdk: beta + - id: checkout + uses: actions/checkout@v2.3.4 + - id: dwds_pub_upgrade + name: dwds; dart pub upgrade + if: "always() && steps.checkout.conclusion == 'success'" + working-directory: dwds + run: dart pub upgrade + - name: dwds; dart analyze . + if: "always() && steps.dwds_pub_upgrade.conclusion == 'success'" + working-directory: dwds + run: dart analyze . + if: "github.event_name == 'schedule'" + needs: + - job_001 + - job_002 + - job_003 + - job_004 + - job_005 + - job_006 + - job_007 + - job_008 + - job_009 + - job_010 + - job_011 + - job_012 + - job_013 + - job_014 + - job_015 + - job_016 + - job_017 + job_021: + name: "beta_cron; linux; Dart beta; PKG: webdev; `dart analyze .`" + runs-on: ubuntu-latest + steps: + - name: Cache Pub hosted dependencies + uses: actions/cache@v2.1.6 + with: + path: "~/.pub-cache/hosted" + key: "os:ubuntu-latest;pub-cache-hosted;dart:beta;packages:webdev;commands:analyze_1" + restore-keys: | + os:ubuntu-latest;pub-cache-hosted;dart:beta;packages:webdev + os:ubuntu-latest;pub-cache-hosted;dart:beta + os:ubuntu-latest;pub-cache-hosted + os:ubuntu-latest + - uses: dart-lang/setup-dart@v1.2 + with: + sdk: beta - id: checkout uses: actions/checkout@v2.3.4 - id: webdev_pub_upgrade @@ -649,10 +762,48 @@ jobs: if: "always() && steps.checkout.conclusion == 'success'" working-directory: webdev run: dart pub upgrade - - name: "webdev; dart test -j 1" + - name: webdev; dart analyze . if: "always() && steps.webdev_pub_upgrade.conclusion == 'success'" working-directory: webdev + run: dart analyze . + if: "github.event_name == 'schedule'" + needs: + - job_001 + - job_002 + - job_003 + - job_004 + - job_005 + - job_006 + - job_007 + - job_008 + - job_009 + - job_010 + - job_011 + - job_012 + - job_013 + - job_014 + - job_015 + - job_016 + - job_017 + job_022: + name: "beta_cron; windows; Dart beta; PKG: dwds; `dart test -j 1`" + runs-on: windows-latest + steps: + - uses: dart-lang/setup-dart@v1.2 + with: + sdk: beta + - id: checkout + uses: actions/checkout@v2.3.4 + - id: dwds_pub_upgrade + name: dwds; dart pub upgrade + if: "always() && steps.checkout.conclusion == 'success'" + working-directory: dwds + run: dart pub upgrade + - name: "dwds; dart test -j 1" + if: "always() && steps.dwds_pub_upgrade.conclusion == 'success'" + working-directory: dwds run: dart test -j 1 + if: "github.event_name == 'schedule'" needs: - job_001 - job_002 @@ -660,24 +811,36 @@ jobs: - job_004 - job_005 - job_006 - job_020: - name: "unit_test; windows; Dart stable; PKG: frontend_server_client; `dart test`" + - job_007 + - job_008 + - job_009 + - job_010 + - job_011 + - job_012 + - job_013 + - job_014 + - job_015 + - job_016 + - job_017 + job_023: + name: "beta_cron; windows; Dart beta; PKG: webdev; `dart test -j 1`" runs-on: windows-latest steps: - uses: dart-lang/setup-dart@v1.2 with: - sdk: stable + sdk: beta - id: checkout uses: actions/checkout@v2.3.4 - - id: frontend_server_client_pub_upgrade - name: frontend_server_client; dart pub upgrade + - id: webdev_pub_upgrade + name: webdev; dart pub upgrade if: "always() && steps.checkout.conclusion == 'success'" - working-directory: frontend_server_client + working-directory: webdev run: dart pub upgrade - - name: frontend_server_client; dart test - if: "always() && steps.frontend_server_client_pub_upgrade.conclusion == 'success'" - working-directory: frontend_server_client - run: dart test + - name: "webdev; dart test -j 1" + if: "always() && steps.webdev_pub_upgrade.conclusion == 'success'" + working-directory: webdev + run: dart test -j 1 + if: "github.event_name == 'schedule'" needs: - job_001 - job_002 @@ -685,7 +848,18 @@ jobs: - job_004 - job_005 - job_006 - job_021: + - job_007 + - job_008 + - job_009 + - job_010 + - job_011 + - job_012 + - job_013 + - job_014 + - job_015 + - job_016 + - job_017 + job_024: name: Notify failure runs-on: ubuntu-latest if: "(github.event_name == 'push' || github.event_name == 'schedule') && failure()" @@ -717,3 +891,6 @@ jobs: - job_018 - job_019 - job_020 + - job_021 + - job_022 + - job_023 diff --git a/dwds/mono_pkg.yaml b/dwds/mono_pkg.yaml index 061d48578..cbd8d6d6f 100644 --- a/dwds/mono_pkg.yaml +++ b/dwds/mono_pkg.yaml @@ -7,17 +7,28 @@ stages: - test: test/build/ensure_version_test.dart dart: dev - group: - - analyze: --fatal-warnings . - dart: beta + - analyze: . + - test: test/build/min_sdk_test.dart --run-skipped + dart: stable - unit_test: - group: - command: Xvfb :99 -screen 0 1024x768x24 > /dev/null 2>&1 & - test: dart: - dev - - beta + - stable - test: os: windows dart: - dev - - beta + - stable + - beta_cron: + - analyze: . + dart: beta + - group: + - command: Xvfb :99 -screen 0 1024x768x24 > /dev/null 2>&1 & + - test: -j 1 + dart: beta + - test: -j 1 + os: windows + dart: beta diff --git a/dwds/test/build/min_sdk_test.dart b/dwds/test/build/min_sdk_test.dart new file mode 100644 index 000000000..c44613c61 --- /dev/null +++ b/dwds/test/build/min_sdk_test.dart @@ -0,0 +1,31 @@ +// Copyright (c) 2021, the Dart project authors. Please see the AUTHORS file +// for details. All rights reserved. Use of this source code is governed by a +// BSD-style license that can be found in the LICENSE file. + +// @dart = 2.9 + +@TestOn('vm') +@Skip('Intended to run in analyze stage on stable SDK only, see mono_pkg.yaml') +import 'dart:io'; + +import 'package:pub_semver/pub_semver.dart'; +import 'package:pubspec_parse/pubspec_parse.dart'; +import 'package:test/test.dart'; + +void main() { + test('dwds pubspec has the stable as min SDK constraint', () { + var pubspec = Pubspec.parse(File('pubspec.yaml').readAsStringSync()); + var sdkVersion = Version.parse(Platform.version.split(' ')[0]); + sdkVersion = Version(sdkVersion.major, sdkVersion.minor, 0); + + var sdkConstraint = VersionConstraint.compatibleWith(sdkVersion); + var pubspecSdkConstraint = pubspec.environment['sdk']; + expect(sdkConstraint.allowsAll(pubspecSdkConstraint), true, + reason: + 'Min sdk constraint is outdated. Please update SDK constraint in ' + 'pubspec to allow latest stable and backwards compatible versions. ' + 'Current stable: $sdkVersion, ' + 'Dwds pubspec constraint: $pubspecSdkConstraint' + ); + }); +} diff --git a/example/pubspec.yaml b/example/pubspec.yaml index 7b90f664f..9fd17bffb 100644 --- a/example/pubspec.yaml +++ b/example/pubspec.yaml @@ -9,5 +9,4 @@ environment: dev_dependencies: build_runner: ^2.0.0 build_web_compilers: ^3.0.0 - webdev: - path: ../webdev + webdev: ^2.7.5 diff --git a/mono_repo.yaml b/mono_repo.yaml index 54c98931b..09f5dee1d 100644 --- a/mono_repo.yaml +++ b/mono_repo.yaml @@ -3,7 +3,7 @@ self_validate: analyzer_and_format github: env: DISPLAY: ':99' - cron: '0 0 * * 0' + cron: '0 0 * * 0' # "At 00:00 (UTC) on Sunday." on_completion: - name: "Notify failure" runs-on: ubuntu-latest @@ -16,6 +16,10 @@ github: "${CHAT_WEBHOOK_URL}" env: CHAT_WEBHOOK_URL: ${{ secrets.BUILD_AND_TEST_TEAM_CHAT_WEBHOOK_URL }} + stages: + - name: beta_cron + # Only run this stage for scheduled cron jobs + if: github.event_name == 'schedule' merge_stages: - analyzer_and_format diff --git a/tool/ci.sh b/tool/ci.sh index b323e6bc7..7f183de59 100755 --- a/tool/ci.sh +++ b/tool/ci.sh @@ -72,8 +72,8 @@ for PKG in ${PKGS}; do dart analyze --fatal-infos . || EXIT_CODE=$? ;; analyze_1) - echo 'dart analyze --fatal-warnings .' - dart analyze --fatal-warnings . || EXIT_CODE=$? + echo 'dart analyze .' + dart analyze . || EXIT_CODE=$? ;; command) echo 'Xvfb :99 -screen 0 1024x768x24 > /dev/null 2>&1 &' @@ -88,17 +88,21 @@ for PKG in ${PKGS}; do dart test test/build/ensure_version_test.dart || EXIT_CODE=$? ;; test_1) - echo 'dart test' - dart test || EXIT_CODE=$? + echo 'dart test test/build/min_sdk_test.dart --run-skipped' + dart test test/build/min_sdk_test.dart --run-skipped || EXIT_CODE=$? ;; test_2) - echo 'dart test test/build/ensure_build_test.dart' - dart test test/build/ensure_build_test.dart || EXIT_CODE=$? + echo 'dart test' + dart test || EXIT_CODE=$? ;; test_3) echo 'dart test -j 1' dart test -j 1 || EXIT_CODE=$? ;; + test_4) + echo 'dart test test/build/ensure_build_test.dart' + dart test test/build/ensure_build_test.dart || EXIT_CODE=$? + ;; *) echo -e "\033[31mUnknown TASK '${TASK}' - TERMINATING JOB\033[0m" exit 64 diff --git a/webdev/mono_pkg.yaml b/webdev/mono_pkg.yaml index 6890a5b0d..27c8c4544 100644 --- a/webdev/mono_pkg.yaml +++ b/webdev/mono_pkg.yaml @@ -1,13 +1,4 @@ # See https://pub.dev/packages/mono_repo for details -dart: - # The minimum version should be kept in sync with the - # minimum SDK version defined in the webdev pubspec. - # This ensures we do not accidentally break users upon - # release of webdev. - - 2.13.4 - - beta - - dev - stages: - analyzer_and_format: - group: @@ -16,13 +7,28 @@ stages: - test: test/build/ensure_build_test.dart dart: dev - group: - - analyze: --fatal-warnings . - dart: - - beta - - 2.13.4 + - analyze: . + - test: test/build/min_sdk_test.dart --run-skipped + dart: stable - unit_test: - group: - command: Xvfb :99 -screen 0 1024x768x24 > /dev/null 2>&1 & - test: -j 1 + dart: + - dev + - stable + - test: -j 1 + os: windows + dart: + - dev + - stable + - beta_cron: + - analyze: . + dart: beta + - group: + - command: Xvfb :99 -screen 0 1024x768x24 > /dev/null 2>&1 & + - test: -j 1 + dart: beta - test: -j 1 os: windows + dart: beta diff --git a/webdev/test/build/min_sdk_test.dart b/webdev/test/build/min_sdk_test.dart new file mode 100644 index 000000000..01abb45dd --- /dev/null +++ b/webdev/test/build/min_sdk_test.dart @@ -0,0 +1,31 @@ +// Copyright (c) 2021, the Dart project authors. Please see the AUTHORS file +// for details. All rights reserved. Use of this source code is governed by a +// BSD-style license that can be found in the LICENSE file. + +// @dart = 2.9 + +@TestOn('vm') +@Skip('Intended to run in analyze stage on stable SDK only, see mono_pkg.yaml') +import 'dart:io'; + +import 'package:pub_semver/pub_semver.dart'; +import 'package:pubspec_parse/pubspec_parse.dart'; +import 'package:test/test.dart'; + +void main() { + test('webdev pubspec has the stable as min SDK constraint', () { + var pubspec = Pubspec.parse(File('pubspec.yaml').readAsStringSync()); + var sdkVersion = Version.parse(Platform.version.split(' ')[0]); + sdkVersion = Version(sdkVersion.major, sdkVersion.minor, 0); + + var sdkConstraint = VersionConstraint.compatibleWith(sdkVersion); + var pubspecSdkConstraint = pubspec.environment['sdk']; + expect(sdkConstraint.allowsAll(pubspecSdkConstraint), true, + reason: + 'Min sdk constraint is outdated. Please update SDK constraint in ' + 'pubspec to allow latest stable and backwards compatible versions. ' + 'Current stable: $sdkVersion, ' + 'Webdev pubspec constraint: $pubspecSdkConstraint' + ); + }); +} \ No newline at end of file From 9c8e29f4d1ee8d567d34a423eba3521edf6e9d0a Mon Sep 17 00:00:00 2001 From: Anna Gringauze Date: Wed, 25 Aug 2021 10:50:03 -0700 Subject: [PATCH 3/3] Format --- dwds/test/build/min_sdk_test.dart | 13 ++++++------- webdev/test/build/min_sdk_test.dart | 15 +++++++-------- 2 files changed, 13 insertions(+), 15 deletions(-) diff --git a/dwds/test/build/min_sdk_test.dart b/dwds/test/build/min_sdk_test.dart index c44613c61..726dd86bd 100644 --- a/dwds/test/build/min_sdk_test.dart +++ b/dwds/test/build/min_sdk_test.dart @@ -17,15 +17,14 @@ void main() { var pubspec = Pubspec.parse(File('pubspec.yaml').readAsStringSync()); var sdkVersion = Version.parse(Platform.version.split(' ')[0]); sdkVersion = Version(sdkVersion.major, sdkVersion.minor, 0); - - var sdkConstraint = VersionConstraint.compatibleWith(sdkVersion); + + var sdkConstraint = VersionConstraint.compatibleWith(sdkVersion); var pubspecSdkConstraint = pubspec.environment['sdk']; expect(sdkConstraint.allowsAll(pubspecSdkConstraint), true, reason: - 'Min sdk constraint is outdated. Please update SDK constraint in ' - 'pubspec to allow latest stable and backwards compatible versions. ' - 'Current stable: $sdkVersion, ' - 'Dwds pubspec constraint: $pubspecSdkConstraint' - ); + 'Min sdk constraint is outdated. Please update SDK constraint in ' + 'pubspec to allow latest stable and backwards compatible versions.' + '\n Current stable: $sdkVersion,' + '\n Dwds pubspec constraint: $pubspecSdkConstraint'); }); } diff --git a/webdev/test/build/min_sdk_test.dart b/webdev/test/build/min_sdk_test.dart index 01abb45dd..a890013d2 100644 --- a/webdev/test/build/min_sdk_test.dart +++ b/webdev/test/build/min_sdk_test.dart @@ -17,15 +17,14 @@ void main() { var pubspec = Pubspec.parse(File('pubspec.yaml').readAsStringSync()); var sdkVersion = Version.parse(Platform.version.split(' ')[0]); sdkVersion = Version(sdkVersion.major, sdkVersion.minor, 0); - - var sdkConstraint = VersionConstraint.compatibleWith(sdkVersion); + + var sdkConstraint = VersionConstraint.compatibleWith(sdkVersion); var pubspecSdkConstraint = pubspec.environment['sdk']; expect(sdkConstraint.allowsAll(pubspecSdkConstraint), true, reason: - 'Min sdk constraint is outdated. Please update SDK constraint in ' - 'pubspec to allow latest stable and backwards compatible versions. ' - 'Current stable: $sdkVersion, ' - 'Webdev pubspec constraint: $pubspecSdkConstraint' - ); + 'Min sdk constraint is outdated. Please update SDK constraint in ' + 'pubspec to allow latest stable and backwards compatible versions.' + '\n Current stable: $sdkVersion, ' + '\n Webdev pubspec constraint: $pubspecSdkConstraint'); }); -} \ No newline at end of file +}