Skip to content

Commit 20159bb

Browse files
nstarmanjorenham
andcommitted
Apply suggestions from code review
Co-authored-by: Joren Hammudoglu <[email protected]> Signed-off-by: Nathaniel Starkman <[email protected]>
1 parent 909f749 commit 20159bb

File tree

6 files changed

+11
-14
lines changed

6 files changed

+11
-14
lines changed

.github/workflows/ci.yml

Lines changed: 4 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -1,15 +1,11 @@
11
name: CI
2-
3-
permissions:
4-
contents: read
5-
packages: read
2+
permissions: read-all
63

74
on:
85
workflow_dispatch:
96
pull_request:
107
push:
11-
branches:
12-
- main
8+
branches: [main]
139

1410
concurrency:
1511
group: ${{ github.workflow }}-${{ github.ref }}
@@ -76,7 +72,7 @@ jobs:
7672

7773
- name: Test package
7874
run: >-
79-
uv run pytest src docs tests -ra --cov --cov-report=xml
75+
uv run pytest src docs tests -cov --cov-report=xml
8076
--cov-report=term --durations=20
8177
8278
- name: Upload coverage report
@@ -111,7 +107,7 @@ jobs:
111107

112108
- name: Test package
113109
run: >-
114-
uv run pytest src docs tests -ra --cov --cov-report=xml
110+
uv run pytest src docs tests --cov --cov-report=xml
115111
--cov-report=term --durations=20 --mpl
116112
117113
- name: Upload coverage report

pyproject.toml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -139,7 +139,7 @@ version_tuple = {version_tuple!r}
139139
]
140140

141141
[tool.ruff.lint.per-file-ignores]
142-
"tests/*.py" = ["ANN201", "S101"]
142+
"tests/*.py" = ["ANN201", "D1", "S101"]
143143

144144
[tool.ruff.lint.flake8-import-conventions]
145145
banned-from = ["array_api_typing"]

src/array_api_typing/__init__.py

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,10 @@
11
"""Static typing support for the array API standard."""
22

3-
__all__ = ["HasArrayNamespace", "__version__", "__version_tuple__"]
3+
__all__ = (
4+
"HasArrayNamespace",
5+
"__version__",
6+
"__version_tuple__",
7+
)
48

59
from ._namespace import HasArrayNamespace
610
from ._version import version as __version__, version_tuple as __version_tuple__

src/array_api_typing/_namespace.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
"""Static typing support for the array API standard."""
22

3-
__all__ = ["HasArrayNamespace"]
3+
__all__ = ("HasArrayNamespace",)
44

55
from types import ModuleType
66
from typing import Protocol, final

tests/__init__.py

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1 +0,0 @@
1-
"""Tests."""

tests/test_namespace.py

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,3 @@
1-
"""Tests for the HasArrayNamespace protocol."""
2-
31
from types import SimpleNamespace
42
from typing import Protocol, runtime_checkable
53

0 commit comments

Comments
 (0)