Skip to content

Commit 9529230

Browse files
committed
fix: desktop and mobile design audit fixes
1 parent 132f1ec commit 9529230

File tree

6 files changed

+73
-25
lines changed

6 files changed

+73
-25
lines changed

components/card.vue

+2-5
Original file line numberDiff line numberDiff line change
@@ -140,22 +140,19 @@ const iconComponent = computed(() => {
140140
z-index: 2;
141141
display: flex;
142142
justify-content: space-between;
143-
align-items: center;
144143
height: 100%;
145-
@include medium {
146-
align-items: flex-start;
147-
}
148144
}
149145
.image {
150146
padding: 0 toRem(28);
151147
max-height: toRem(120);
148+
margin: auto 0;
152149
@include large {
153150
padding: 0;
154151
margin-right: 1rem;
155152
}
156153
@include medium {
157154
max-height: toRem(75);
158-
margin-left: 1rem;
155+
margin: 0 1rem;
159156
}
160157
@include small {
161158
margin-left: 0;

components/roadmap.vue

+36-16
Original file line numberDiff line numberDiff line change
@@ -10,19 +10,22 @@
1010
<div
1111
class="col-4_sm-3_mi-10_ti-12"
1212
data-push-left="off-0_mi-1_ti-0">
13-
<div class="heading">
14-
13+
<div class="heading-wrapper">
1514
<ZeroButton
1615
tag="a"
16+
target="_blank"
1717
to="https://github.com/data-preservation-programs/singularity/milestones"
18-
class="icon-button">
19-
<GithubIcon class="icon" />
20-
</ZeroButton>
18+
class="heading-button">
19+
<div class="heading">
2120

22-
<span class="h2">
23-
{{ item.heading }}
24-
</span>
21+
<GithubIcon class="icon" />
22+
23+
<span class="h2">
24+
{{ item.heading }}
25+
</span>
2526

27+
</div>
28+
</ZeroButton>
2629
</div>
2730
</div>
2831

@@ -98,39 +101,56 @@ const cta = computed(() => {
98101
margin-bottom: toRem(15);
99102
}
100103
&:hover {
101-
.icon {
104+
.heading {
102105
transform: scale(1.15);
106+
}
107+
.icon {
103108
:deep(path) {
104109
fill: $chardonnay;
105110
}
106111
}
112+
.h2 {
113+
color: $chardonnay;
114+
}
107115
}
108116
}
109117
118+
.heading-wrapper {
119+
display: flex;
120+
align-items: center;
121+
}
122+
110123
.heading {
111124
display: flex;
112125
align-items: center;
113126
margin-top: toRem(25);
127+
cursor: pointer;
128+
@include transitionDefault;
114129
@include mini {
115130
margin-top: 0;
116131
margin-bottom: 0.5rem;
117132
}
118-
.icon-button {
133+
.heading-button {
119134
display: block;
120-
width: toRem(41);
121-
height: toRem(41);
122-
margin-right: toRem(14);
123135
padding: 0.5rem;
124136
}
125137
.icon {
126-
width: 100%;
127-
height: 100%;
128-
transform: scale(1);
138+
width: toRem(41);
139+
height: toRem(41);
140+
margin-right: toRem(14);
129141
transition: 300ms cubic-bezier(0.33, 0.2, 0.41, 0.99);
142+
@include mini {
143+
width: toRem(18);
144+
height: toRem(18);
145+
margin-right: toRem(7);
146+
}
130147
:deep(path) {
131148
transition: inherit;
132149
}
133150
}
151+
.h2 {
152+
@include transitionDefault;
153+
}
134154
}
135155
136156
.roadmap-card {

components/site-footer.vue

+8
Original file line numberDiff line numberDiff line change
@@ -81,6 +81,7 @@ const legal = computed(() => {
8181
align-items: center;
8282
padding: toRem(34) 0;
8383
height: toRem(234);
84+
z-index: 10;
8485
@include gridMaxMQ {
8586
padding-top: toRem(72);
8687
height: unset;
@@ -149,6 +150,13 @@ const legal = computed(() => {
149150
@include mini {
150151
margin-bottom: toRem(22);
151152
}
153+
:deep(a) {
154+
display: inline-block;
155+
@include transitionDefault;
156+
&:hover {
157+
transform: scale(1.1);
158+
}
159+
}
152160
:deep(span) {
153161
&.green {
154162
color: $sageGreen;

components/subfooter-card.vue

+22-3
Original file line numberDiff line numberDiff line change
@@ -49,8 +49,9 @@
4949
<div v-if="fullwidth" class="col-5_mi-12 inner-column">
5050
<div class="after">
5151

52-
<div class="description">
53-
{{ description }}
52+
<div
53+
class="description"
54+
v-html="description">
5455
</div>
5556

5657
<div v-if="fullwidth && cta" class="cta">
@@ -222,11 +223,19 @@ const cardStyles = computed(() => {
222223
.description {
223224
font-size: toRem(18);
224225
line-height: leading(24, 18);
225-
font-weight: 500;
226226
letter-spacing: 0.01em;
227227
}
228228
229+
.description {
230+
font-weight: 400;
231+
}
232+
233+
:deep(.weight-500) {
234+
font-weight: 500;
235+
}
236+
229237
.subheading {
238+
font-weight: 500;
230239
@include medium {
231240
font-size: toRem(16);
232241
}
@@ -241,6 +250,14 @@ const cardStyles = computed(() => {
241250
display: inline;
242251
}
243252
}
253+
:deep(a) {
254+
font-size: 1.125rem;
255+
display: inline-block;
256+
@include transitionDefault;
257+
&:hover {
258+
transform: scale(1.15);
259+
}
260+
}
244261
}
245262
246263
.subfooter-card.fullwidth {
@@ -280,8 +297,10 @@ const cardStyles = computed(() => {
280297
}
281298
}
282299
.after {
300+
margin-top: toRem(34);
283301
padding: 0 toRem(40);
284302
@include medium {
303+
margin-top: 0;
285304
padding: 0;
286305
}
287306
.subheading {

content/core/index.json

+1-1
Original file line numberDiff line numberDiff line change
@@ -504,7 +504,7 @@
504504
"borderGradientAngle": "45deg",
505505
"title": "<img src='/images/topography-graphic-with-border.svg' />Keep up<br>with Singularity",
506506
"subheading": "Your feedback can shape our next big release. <br>Join us on <a href='https://github.com/data-preservation-programs/singularity' target='_blank'>Github</a> and <a href='https://filecoinproject.slack.com/archives/C05JABREATH' target='_blank'>Slack</a>",
507-
"description": "Sign up to keep up. We're passionate about keeping you in the loop with our latest features and updates, but we're even more committed to respecting your inbox.",
507+
"description": "<span class='weight-500'>Sign up to keep up.</span> We're passionate about keeping you in the loop with our latest features and updates, but we're even more committed to respecting your inbox.",
508508
"cta": {
509509
"tag": "a",
510510
"to": "https://example.com",

pages/index.vue

+4
Original file line numberDiff line numberDiff line change
@@ -265,6 +265,7 @@ onMounted(() => {
265265
266266
:deep(#features) {
267267
padding-top: 0;
268+
z-index: 10;
268269
@include medium {
269270
padding-top: toRem(35);
270271
}
@@ -317,6 +318,7 @@ onMounted(() => {
317318
}
318319
319320
:deep(#how-it-works) {
321+
padding-top: toRem(60);
320322
@include medium {
321323
padding-top: 0.875rem;
322324
}
@@ -357,6 +359,8 @@ onMounted(() => {
357359
}
358360
359361
:deep(#roadmap) {
362+
padding-top: toRem(11);
363+
padding-bottom: 2rem;
360364
div[data-block-id="col_1"] {
361365
margin-bottom: toRem(45);
362366
@include medium {

0 commit comments

Comments
 (0)