Skip to content
This repository was archived by the owner on May 17, 2024. It is now read-only.

Commit f5c2f5c

Browse files
committed
bug: disable supporting of uuids
1 parent 3ef3700 commit f5c2f5c

File tree

2 files changed

+3
-3
lines changed

2 files changed

+3
-3
lines changed

data_diff/databases/mssql.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -69,7 +69,7 @@ class Dialect(BaseDialect):
6969
"varbinary": Text,
7070
"xml": Text,
7171
# UUID
72-
"uniqueidentifier": Native_UUID,
72+
# "uniqueidentifier": Native_UUID, # It is not supported yet
7373
# Bool
7474
"bit": Boolean,
7575
# JSON
@@ -167,7 +167,7 @@ def md5_as_hex(self, s: str) -> str:
167167
return f"HashBytes('MD5', {s})"
168168

169169
def normalize_uuid(self, value: str, coltype) -> str:
170-
return f"CONVERT(VARCHAR(36), UPPER(TRIM(CONVERT(varchar(4000), {value}))))"
170+
return f"CONVERT(VARCHAR(36), TRIM(CONVERT(varchar(4000), {value})))"
171171

172172

173173
@attrs.define(frozen=False, init=False, kw_only=True)

tests/test_database_types.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -353,7 +353,7 @@ def init_conns():
353353
"int": ["INT", "BIGINT"],
354354
"datetime": ["datetime2(6)"],
355355
"float": ["DECIMAL(6, 2)", "FLOAT", "REAL"],
356-
"uuid": ["VARCHAR(100)", "CHAR(100)", "UNIQUEIDENTIFIER"],
356+
"uuid": ["VARCHAR(100)", "CHAR(100)"],
357357
"boolean": [
358358
"BIT",
359359
],

0 commit comments

Comments
 (0)