Skip to content

Use strings as ids #13

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
curran opened this issue May 26, 2016 · 2 comments
Closed

Use strings as ids #13

curran opened this issue May 26, 2016 · 2 comments

Comments

@curran
Copy link
Member

curran commented May 26, 2016

Currently, node ids are being assigned as integers, but their usage is always as strings (identifiers for nodes in graph-data-structure).

The code

property.id = counter++;

should become

property.id = String(counter++);
@curran
Copy link
Member Author

curran commented May 26, 2016

Needed for datavis-tech/graph-data-structure#12

@curran
Copy link
Member Author

curran commented May 26, 2016

Part of datavis-tech/reactive-model#31

@curran curran closed this as completed in 4d4ca1d May 26, 2016
@curran curran mentioned this issue May 26, 2016
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@curran