Error message formatting

Author: davedoesdev

coverage/coverage.xml

@@ -1,5 +1,5 @@
 <?xml version="1.0" ?>
-<coverage branch-rate="1" branches-covered="56" branches-valid="56" complexity="0" line-rate="1" lines-covered="87" lines-valid="87" timestamp="1524608656119" version="4.4.2">
+<coverage branch-rate="1" branches-covered="56" branches-valid="56" complexity="0" line-rate="1" lines-covered="87" lines-valid="87" timestamp="1524610853051" version="4.4.2">
 	<!-- Generated by coverage.py: https://coverage.readthedocs.io -->
 	<!-- Based on https://raw.githubusercontent.com/cobertura/web/master/htdocs/xml/coverage-04.dtd -->
 	<sources>

coverage/html/index.html

@@ -107,7 +107,7 @@ <h1>Coverage report:
     <div class="content">
         <p>
             <a class="nav" href="https://coverage.readthedocs.io">coverage.py v4.4.2</a>,
-            created at 2018-04-24 23:24
+            created at 2018-04-25 00:00
         </p>
     </div>
 </div>

coverage/html/python_jwt___init___py.html

@@ -362,7 +362,7 @@ <h2 class="stats">
 <p id="t64" class="stm run hide_run">    <span class="key">if</span> <span class="nam">other_headers</span> <span class="key">is</span> <span class="key">not</span> <span class="nam">None</span><span class="op">:</span><span class="strut">&nbsp;</span></p>
 <p id="t65" class="stm run hide_run">        <span class="nam">redefined_keys</span> <span class="op">=</span> <span class="nam">set</span><span class="op">(</span><span class="nam">header</span><span class="op">.</span><span class="nam">keys</span><span class="op">(</span><span class="op">)</span><span class="op">)</span> <span class="op">&amp;</span> <span class="nam">set</span><span class="op">(</span><span class="nam">other_headers</span><span class="op">.</span><span class="nam">keys</span><span class="op">(</span><span class="op">)</span><span class="op">)</span><span class="strut">&nbsp;</span></p>
 <p id="t66" class="stm run hide_run">        <span class="key">if</span> <span class="nam">redefined_keys</span><span class="op">:</span><span class="strut">&nbsp;</span></p>
-<p id="t67" class="stm run hide_run">            <span class="key">raise</span> <span class="nam">ValueError</span><span class="op">(</span><span class="str">'other_headers re-specified the headers: {}'</span><span class="op">.</span><span class="nam">format</span><span class="op">(</span><span class="nam">redefined_keys</span><span class="op">)</span><span class="op">)</span><span class="strut">&nbsp;</span></p>
+<p id="t67" class="stm run hide_run">            <span class="key">raise</span> <span class="nam">ValueError</span><span class="op">(</span><span class="str">'other_headers re-specified the headers: {}'</span><span class="op">.</span><span class="nam">format</span><span class="op">(</span><span class="str">', '</span><span class="op">.</span><span class="nam">join</span><span class="op">(</span><span class="nam">redefined_keys</span><span class="op">)</span><span class="op">)</span><span class="op">)</span><span class="strut">&nbsp;</span></p>
 <p id="t68" class="stm run hide_run">        <span class="nam">header</span><span class="op">.</span><span class="nam">update</span><span class="op">(</span><span class="nam">other_headers</span><span class="op">)</span><span class="strut">&nbsp;</span></p>
 <p id="t69" class="pln"><span class="strut">&nbsp;</span></p>
 <p id="t70" class="stm run hide_run">    <span class="nam">claims</span> <span class="op">=</span> <span class="nam">dict</span><span class="op">(</span><span class="nam">claims</span><span class="op">)</span><span class="strut">&nbsp;</span></p>
@@ -530,7 +530,7 @@ <h2 class="stats">
     <div class="content">
         <p>
             <a class="nav" href="index.html">&#xab; index</a> &nbsp; &nbsp; <a class="nav" href="https://coverage.readthedocs.io">coverage.py v4.4.2</a>,
-            created at 2018-04-24 23:24
+            created at 2018-04-25 00:00
         </p>
     </div>
 </div>

coverage/html/status.json

@@ -1 +1 @@
-{"files":{"python_jwt___init___py":{"index":{"relative_filename":"python_jwt/__init__.py","html_filename":"python_jwt___init___py.html","nums":[1,87,0,0,56,0,0]},"hash":"3878443fd8f9f87f48009d27a91a6f3d"}},"version":"4.4.2","settings":"a3199b6aad875f0076f4863c12dbfc6a","format":1}
+{"files":{"python_jwt___init___py":{"index":{"relative_filename":"python_jwt/__init__.py","html_filename":"python_jwt___init___py.html","nums":[1,87,0,0,56,0,0]},"hash":"d105f43a63a29f8229f7ff1eeea8975f"}},"version":"4.4.2","settings":"a3199b6aad875f0076f4863c12dbfc6a","format":1}

python_jwt/__init__.py

@@ -64,7 +64,7 @@ def generate_jwt(claims, priv_key=None,
     if other_headers is not None:
         redefined_keys = set(header.keys()) & set(other_headers.keys())
         if redefined_keys:
-            raise ValueError('other_headers re-specified the headers: {}'.format(redefined_keys))
+            raise ValueError('other_headers re-specified the headers: {}'.format(', '.join(redefined_keys)))
         header.update(other_headers)
 
     claims = dict(claims)

test/other_headers_vows.py

@@ -45,7 +45,7 @@ def topic(self):
         def should_not_generated_token(self, r):
             """ Should not generate """
             expect(r).to_be_an_error()
-            expect(str(r)).to_equal("other_headers re-specified the headers: set(['typ'])")
+            expect(str(r)).to_equal("other_headers re-specified the headers: typ")
 
     @Vows.batch
     #pylint: disable=unused-variable
@@ -60,7 +60,7 @@ def topic(self):
         def should_not_generated_token(self, r):
             """ Should not generate """
             expect(r).to_be_an_error()
-            expect(str(r)).to_equal("other_headers re-specified the headers: set(['alg'])")
+            expect(str(r)).to_equal("other_headers re-specified the headers: alg")
 
 other_headers('none', None)
 for _alg in algs: