Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Request to Fix Regex Parsing Issue for Markdown Links in Python Package #1

Closed
JannLee opened this issue Apr 23, 2024 · 2 comments
Closed

Comments

@JannLee
Copy link

JannLee commented Apr 23, 2024

Hi! Thank you for offering this plugin!
I am using this python package to add an interactive graph to my static page generated by mkdocs.

However, I found some bugs while using this script.

If markdown text wrriten multiple links of one line.
Regex incorrectly parsed it as follows.

  • example text: "Blah Blah [[Blah Blah]] Blah Blah [[Blah Bla]] Blah Blah"
  • parsing result: Blah Blah [[Blah Blah]] Blah Blah [[Blah Bla]] Blah Blah
  • I hoped result: Blah Blah [[Blah Blah]] Blah Blah [[Blah Bla]] Blah Blah

The reason is regex non-capturing text.
And I can modify this script to work correctly.

May I send a PR?

@daxcore
Copy link
Owner

daxcore commented Apr 24, 2024

Hey,
thanks for the bug report!
the fix should be just a single character in the regex, shouldn't it? xD

let me know, if the last commit fixes the problem for u?!

@JannLee
Copy link
Author

JannLee commented Apr 25, 2024

It seems to be working properly with the last commit.
Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants