Rewrite timezone support

Author: dbernheisel

.github/workflows/ci.yml

@@ -14,27 +14,27 @@ jobs:
       MIX_ENV: test
       CI: "true"
     steps:
-      - uses: actions/checkout@v2
+      - uses: actions/checkout@v3
       - uses: erlef/setup-beam@v1
         with:
           otp-version: '25'
-          elixir-version: '1.14.0'
+          elixir-version: '1.14.3'
       - run: mix deps.get --only dev
       - run: mix format --check-formatted
       - run: mix credo --strict
 
   test-oldest:
-    runs-on: ubuntu-18.04
+    runs-on: ubuntu-20.04
     name: Tests on oldest version
     env:
       MIX_ENV: test
       CI: "true"
     steps:
-      - uses: actions/checkout@v2
+      - uses: actions/checkout@v3
       - uses: erlef/setup-beam@v1
         with:
-          otp-version: '19'
-          elixir-version: '1.4.5'
+          otp-version: '21'
+          elixir-version: '1.11.4'
       - run: rm mix.lock
       - run: mix deps.get
       - run: mix compile --force --warnings-as-errors
@@ -47,11 +47,11 @@ jobs:
       MIX_ENV: test
       CI: "true"
     steps:
-      - uses: actions/checkout@v2
+      - uses: actions/checkout@v3
       - uses: erlef/setup-beam@v1
         with:
           otp-version: '25'
-          elixir-version: '1.14.0'
+          elixir-version: '1.14.3'
       - run: rm mix.lock
       - run: mix deps.get
       - run: mix compile --force --warnings-as-errors

CHANGELOG.md

@@ -1,6 +1,12 @@
 # Changelog
 
-## 1.1.5
+## 1.2.0 (unreleased)
+
+- Drop Timex as dependency. This required a custom IANA file parser for
+  determining timezones and rules that was able to parse timezone abbreviations.
+  Doing so requires the use of Elixir functions introduced in Elixir 1.11.
+
+## 1.1.5 (2022-10-07)
 
 - Switch to pre-compiled combinators so that NimbleParsec is not needed during
   compilation-- why have everyone else compile this when we can compile it
@@ -12,18 +18,18 @@
   fallback `assume_date` since there is not a data structure that only describes
   Month and Year in Elixir.
 
-## 1.1.4
+## 1.1.4 (2022-10-05)
 
 - Update GitHub Repo references
 
-## 1.1.3
+## 1.1.3 (2021-10-24)
 
 - Stricter time parsing by requiring time separators. For example, `949` used to
   be parsed as `09:49:00`, but is now considered not valid. This is to help
   decrease false positives of nonsensical times such as `25:00 am` (incorrectly
   parsed as `02:05:00`). Thanks @fcapovilla (PR #46)
 
-## 1.1.2
+## 1.1.2 (2021-06-14)
 
 - Correct handling of 12:xx:xx AM timestamps (12hr). These were incorrectly
     parsed as 12:xx:xx (24hr) timestamps when they should have been 00:xx:xx
@@ -32,19 +38,19 @@
 - Lock Timex to >= 3.2.1 and <= 3.7.2 to avoid timezone conversion issues when
   using `to_utc: true`. Looks like there are some breaking changes (for us)
 
-## 1.1.1
+## 1.1.1 (2021-02-06)
 
 - Adjust tokenizer to prefer month/day before of day/month when those are the
     only found tokens. Thanks @mwean raising the issue.
 
-## 1.1.0
+## 1.1.0 (2020-10-17)
 
 - Add option `use_1904_date_system` for the serial parser. It defaults to
     `false`. Most spreadsheet applications use the 1900 date system, but
     Microsoft Excel on Macintosh in particular used the 1904 date system
     [@fcapovilla].
 
-## 1.0.0
+## 1.0.0 (2020-02-05)
 
 ### Breaking
 
@@ -84,32 +90,32 @@
 - Added `parsers: []` option to add or disable parsers. This is helpful if you
     are don't want to consider Serial or Epoch timestamps.
 
-## 0.2.0
+## 0.2.0 (2019-09-26)
 
 - Add Serial time support
 
-## 0.1.4
+## 0.1.4 (2019-09-03)
 
 - Refactor
 - Support subsecond parsing to 24 digits (yoctoseconds) [thanks @myfreeweb]
 
-## 0.1.3
+## 0.1.3 (2019-08-02)
 
 - Support parsing Unix epoch times from strings
 - Fix microsecond parsing
 
-## 0.1.2
+## 0.1.2 (2019-07-11)
 
 - Validate days of month. Previously it would allow invalid days such as Feb 30.
   Now it will check if the year is a leap year and allow up to 29, and otherwise
   28 for Feb. It will also reject day 31 on months without 31 days.
 
-## 0.1.1
+## 0.1.1 (2019-07-03)
 
 - Fix PM 12-hr conversion. The bug would convert 12:34PM to 24:34 which is
   not valid
 
-## 0.1.0
+## 0.1.0 (2019-06-24)
 
 - Add DateTimeParser.parse_datetime/2
 - Add DateTimeParser.parse_date/1

EXAMPLES.livemd

@@ -227,6 +227,8 @@ convert to UTC or to assume a time when not present.
 |`2016/1/9`|`2016-01-09`|parse| |
 |`2017-02-29`|`Could not parse "2017-02-29"`|parse_date| |
 |`2017-02-29 00:00:00 UTC`|`Could not parse "2017-02-29 00:00:00 UTC"`|parse_datetime| |
+|`2017-03-04 15:20:47 EDT`|`2017-03-04T20:20:47Z`|parse_datetime|`[to_utc: true]`|
+|`2017-03-04 15:20:47 EST`|`2017-03-04T20:20:47Z`|parse_datetime|`[to_utc: true]`|
 |`2017-04-31`|`Could not parse "2017-04-31"`|parse_date| |
 |`2017-04-31 00:00:00 UTC`|`Could not parse "2017-04-31 00:00:00 UTC"`|parse_datetime| |
 |`2017-06-31`|`Could not parse "2017-06-31"`|parse_date| |
@@ -239,7 +241,7 @@ convert to UTC or to assume a time when not present.
 |`2017-11-04 15:20:47 EDT`|`2017-11-04`|parse_date| |
 |`2017-11-04 15:20:47 EDT`|`2017-11-04T19:20:47Z`|parse_datetime|`[to_utc: true]`|
 |`2017-11-04 15:20:47 EST`|`2017-11-04`|parse_date| |
-|`2017-11-04 15:20:47 EST`|`2017-11-04T20:20:47Z`|parse_datetime|`[to_utc: true]`|
+|`2017-11-04 15:20:47 EST`|`2017-11-04T19:20:47Z`|parse_datetime|`[to_utc: true]`|
 |`2017-11-04 15:20:47 UTC`|`2017-11-04`|parse_date| |
 |`2017-11-04 15:20:47 UTC`|`2017-11-04T15:20:47Z`|parse_datetime| |
 |`2017-11-04 15:20:47+0000`|`2017-11-04`|parse_date| |

README.md

@@ -111,14 +111,14 @@ iex> DateTimeParser.parse_datetime(~s|"Mar 28, 2018 7:39:53 AM PDT"|, to_utc: tr
 
 iex> {:ok, datetime} = DateTimeParser.parse_datetime(~s|"Mar 1, 2018 7:39:53 AM PST"|)
 iex> datetime
-#DateTime<2018-03-01 07:39:53-08:00 PST PST8PDT>
+#DateTime<2018-03-01 07:39:53-08:00 PST America/Los_Angeles>
 
 iex> DateTimeParser.parse_datetime(~s|"Mar 1, 2018 7:39:53 AM PST"|, to_utc: true)
 {:ok, DateTime.from_naive!(~N[2018-03-01T15:39:53Z], "Etc/UTC")}
 
 iex> {:ok, datetime} = DateTimeParser.parse_datetime(~s|"Mar 28, 2018 7:39:53 AM PDT"|)
 iex> datetime
-#DateTime<2018-03-28 07:39:53-07:00 PDT PST8PDT>
+#DateTime<2018-03-28 07:39:53-07:00 PDT America/Los_Angeles>
 
 iex> DateTimeParser.parse_time("10:13pm")
 {:ok, ~T[22:13:00]}
@@ -147,6 +147,9 @@ end
 
 ## Configuration
 
+You must have a timezone database configured if you want parsing to consider
+timezones. See [tz](https://github.com/mathieuprog/tz) or [tzdata](https://github.com/lau/tzdata).
+
 ```elixir
 # This is the default config
 alias DateTimeParser.Parser
@@ -155,6 +158,9 @@ config :date_time_parser, parsers: [Parser.Epoch, Parser.Serial, Parser.Tokenize
 # To enable only specific parsers, include them in the :parsers key.
 config :date_time_parser, parsers: [Parser.Tokenizer]
 
+# Adding the timezone database from Tz
+config :elixir, :time_zone_database, Tz.TimeZoneDatabase
+
 # Or in runtime, pass in the parsers in the function.
 DateTimeParser.parse(mystring, parsers: [Parser.Tokenizer])
 ```

bin/release

@@ -9,9 +9,9 @@ mix tests
 git add EXAMPLES.livemd
 git add lib/combinators.ex
 
-sed -i "s/$previous_version/$release_version/" README.md
-sed -i "s/$previous_version/$release_version/" mix.exs
-sed -i "s/unreleased/$release_version/" CHANGELOG.md
+sed -i "" "s/$previous_version/$release_version/" README.md
+sed -i "" "s/$previous_version/$release_version/" mix.exs
+sed -i "" "s/unreleased/$release_version ($(date +%F))/" CHANGELOG.md
 git add mix.exs
 git add README.md
 git add CHANGELOG.md

config/config.exs

@@ -0,0 +1,2 @@
+import Config
+import_config "#{config_env()}.exs"

config/dev.exs

@@ -0,0 +1,3 @@
+import Config
+
+config :elixir, :time_zone_database, Tz.TimeZoneDatabase

config/test.exs

@@ -0,0 +1,2 @@
+import Config
+config :elixir, :time_zone_database, Tz.TimeZoneDatabase