Skip to content
This repository was archived by the owner on Oct 21, 2023. It is now read-only.

Commit 23e75de

Browse files
add jquery and datatables as explicit dependencies
1 parent 9371db1 commit 23e75de

File tree

3 files changed

+7
-5
lines changed

3 files changed

+7
-5
lines changed

src/banner.js

+1-1
Original file line numberDiff line numberDiff line change
@@ -1,2 +1,2 @@
1-
(function() { function _dcdt(d3, dc) {
1+
(function() { function _dcdt(d3, dc, jQuery, datatables) {
22
'use strict';

src/datatable.js

+1-1
Original file line numberDiff line numberDiff line change
@@ -35,7 +35,7 @@ dc_datatables.datatable = function(selector, chartGroup) {
3535
table = table.enter()
3636
.append('table')
3737
.merge(table);
38-
_dt = $(table.node()).DataTable({
38+
_dt = jQuery(table.node()).DataTable({
3939
columns: _table.columns().map(function(c) {
4040
var col = {
4141
name: typeof c === 'string' ? c : c.label,

src/footer.js

+5-3
Original file line numberDiff line numberDiff line change
@@ -3,13 +3,15 @@ dc_datatables.dc = dc;
33

44
return dc_datatables;}
55
if(typeof define === "function" && define.amd) {
6-
define(["d3", "dc"], _dcdt);
6+
define(["d3", "dc", "jquery", "datatables"], _dcdt);
77
} else if(typeof module === "object" && module.exports) {
88
var _d3 = require('d3');
99
var _dc = require('dc');
10-
module.exports = _dcdt(_d3, _dc);
10+
var _jQuery = require('jquery');
11+
var _datatables = require('datatables');
12+
module.exports = _dcdt(_d3, _dc, _jQuery, _datatables);
1113
} else {
12-
this.dc_datatables = _dcdt(d3, dc);
14+
this.dc_datatables = _dcdt(d3, dc, $, $); // datatables has no symbol of its own (?)
1315
}
1416
}
1517
)();

0 commit comments

Comments
 (0)