style compliance

Author: gordonwoodhull

dc.js

@@ -3259,7 +3259,13 @@ dc.stackMixin = function (_chart) {
     };
 
     function flattenStack() {
-        return _chart.data().reduce(function (all, layer) {
+        var groups = _chart.data();
+
+        if (groups.length) {
+            groups[0].values = _chart._computeOrderedGroups(groups[0].values);
+        }
+
+        return groups.reduce(function (all, layer) {
             return all.concat(layer.values);
         }, []);
     }

dc.min.js

@@ -980,61 +980,61 @@ describe('dc.barChart', function() {
     });
 
     describe('check ordering option of the x axis', function() {
-            beforeEach(function() {
-                var rows = [
-                    {x: 'a', y: 1},
-                    {x: 'b', y: 3},
-                    {x: 'd', y: 4},
-                    {x: 'c', y: 2}
-                ];
-
-                id = 'bar-chart';
-                appendChartID(id);
-                data = crossfilter(rows);
-                dimension = data.dimension(function(d) {
-                    return d.x;
-                });
-                group = dimension.group().reduceSum(function(d) {
-                    return d.y;
-                });
+        beforeEach(function() {
+            var rows = [
+                {x: 'a', y: 1},
+                {x: 'b', y: 3},
+                {x: 'd', y: 4},
+                {x: 'c', y: 2}
+            ];
 
-                chart = dc.barChart('#' + id);
-                chart.width(500).transitionDuration(0)
-                    .x(d3.scale.ordinal())
-                    .xUnits(dc.units.ordinal)
-                    .elasticY(true).elasticX(true)
-                    .dimension(dimension)
-                    .group(group);
-                chart.render();
+            id = 'bar-chart';
+            appendChartID(id);
+            data = crossfilter(rows);
+            dimension = data.dimension(function(d) {
+                return d.x;
             });
-
-            it('should be ordered by default alphabetical order', function() {
-                var data = chart.data()["0"].values;
-                var expectedData = ["a", "b", "c", "d"];
-                expect(data.map(function(d) { return d.x; })).toEqual(expectedData);
+            group = dimension.group().reduceSum(function(d) {
+                return d.y;
             });
 
-            it('should be ordered by value increasing', function() {
-                chart.ordering(function(d) { return d.data.value; });
-                chart.redraw();
-                expect(xAxisText()).toEqual(["a", "c", "b", "d"]);
-            });
+            chart = dc.barChart('#' + id);
+            chart.width(500).transitionDuration(0)
+                .x(d3.scale.ordinal())
+                .xUnits(dc.units.ordinal)
+                .elasticY(true).elasticX(true)
+                .dimension(dimension)
+                .group(group);
+            chart.render();
+        });
 
-            it('should be ordered by value decreasing', function() {
-                chart.ordering(function(d) { return -d.data.value; });
-                chart.redraw();
-                expect(xAxisText()).toEqual(["d", "b", "c", "a"]);
-            });
+        it('should be ordered by default alphabetical order', function() {
+            var data = chart.data()["0"].values;
+            var expectedData = ["a", "b", "c", "d"];
+            expect(data.map(function(d) { return d.x; })).toEqual(expectedData);
+        });
 
-            it('should be ordered by alphabetical order', function() {
-                chart.ordering(function(d) { return d.data.key; });
-                chart.redraw();
-                expect(xAxisText()).toEqual(["a", "b", "c", "d"]);
-            });
+        it('should be ordered by value increasing', function() {
+            chart.ordering(function(d) { return d.data.value; });
+            chart.redraw();
+            expect(xAxisText()).toEqual(["a", "c", "b", "d"]);
+        });
 
-            function xAxisText() {
-                return chart.selectAll("g.x text")[0].map(function(x) { return d3.select(x).text(); });
-            }
+        it('should be ordered by value decreasing', function() {
+            chart.ordering(function(d) { return -d.data.value; });
+            chart.redraw();
+            expect(xAxisText()).toEqual(["d", "b", "c", "a"]);
+        });
+
+        it('should be ordered by alphabetical order', function() {
+            chart.ordering(function(d) { return d.data.key; });
+            chart.redraw();
+            expect(xAxisText()).toEqual(["a", "b", "c", "d"]);
+        });
+
+        function xAxisText() {
+            return chart.selectAll("g.x text")[0].map(function(x) { return d3.select(x).text(); });
+        }
     });
 
     function nthStack(n) {

dc.min.js.map

@@ -172,7 +172,7 @@ dc.stackMixin = function (_chart) {
     function flattenStack() {
         var groups = _chart.data();
 
-        if(groups.length){
+        if (groups.length) {
             groups[0].values = _chart._computeOrderedGroups(groups[0].values);
         }