correct ordering for ordinal (string) keys

gordonwoodhull · gordonwoodhull · commit 902736ad4436 · 2020-06-26T16:19:35.000-04:00
fixes #1690
diff --git a/src/base/base-mixin.js b/src/base/base-mixin.js
@@ -364,7 +364,7 @@ export class BaseMixin {
 
     _computeOrderedGroups (data) {
         // clone the array before sorting, otherwise Array.sort sorts in-place
-        return Array.from(data).sort((a, b) => this._ordering(a) - this._ordering(b));
+        return Array.from(data).sort((a, b) => d3.ascending(this._ordering(a), this._ordering(b)));
     }
 
     /**

Original file line number	Diff line number	Diff line change
`@@ -364,7 +364,7 @@ export class BaseMixin {`
`364`	`364`
`365`	`365`	`_computeOrderedGroups (data) {`
`366`	`366`	`// clone the array before sorting, otherwise Array.sort sorts in-place`
`367`		`- return Array.from(data).sort((a, b) => this._ordering(a) - this._ordering(b));`
	`367`	`+ return Array.from(data).sort((a, b) => d3.ascending(this._ordering(a), this._ordering(b)));`
`368`	`368`	`}`
`369`	`369`
`370`	`370`	`/**`