Skip to content
forked from pydata/xarray

Commit 7838d57

Browse files
committed
Nicer error
1 parent c94d9c2 commit 7838d57

File tree

2 files changed

+4
-4
lines changed

2 files changed

+4
-4
lines changed

xarray/core/dataarray.py

+1-1
Original file line numberDiff line numberDiff line change
@@ -6790,7 +6790,7 @@ def groupby(
67906790
if len(groupers) > 1:
67916791
raise ValueError("grouping by multiple variables is not supported yet.")
67926792
if not groupers:
6793-
raise ValueError("**groupers must be provided if `group` is not.")
6793+
raise ValueError("Either `group` or `**groupers` must be provided.")
67946794
group, grouper = next(iter(groupers.items()))
67956795

67966796
rgrouper = ResolvedGrouper(grouper, group, self)

xarray/core/dataset.py

+3-3
Original file line numberDiff line numberDiff line change
@@ -10330,9 +10330,9 @@ def groupby(
1033010330
rgrouper = ResolvedGrouper(UniqueGrouper(), group, self)
1033110331
else:
1033210332
if len(groupers) > 1:
10333-
raise ValueError("grouping by multiple variables is not supported yet.")
10334-
if not groupers:
10335-
raise ValueError
10333+
raise ValueError("Grouping by multiple variables is not supported yet.")
10334+
elif not groupers:
10335+
raise ValueError("Either `group` or `**groupers` must be provided.")
1033610336
for group, grouper in groupers.items():
1033710337
rgrouper = ResolvedGrouper(grouper, group, self)
1033810338

0 commit comments

Comments
 (0)