Skip to content

Commit 27f0448

Browse files
JonasMatos0Jonas Matos
and
Jonas Matos
authored
feat: pass strikethrough markdown for hint message on field (#5727)
Co-authored-by: Jonas Matos <[email protected]>
1 parent 787e80c commit 27f0448

File tree

4 files changed

+118
-4
lines changed

4 files changed

+118
-4
lines changed

packages/netlify-cms-core/package.json

+1
Original file line numberDiff line numberDiff line change
@@ -65,6 +65,7 @@
6565
"redux-devtools-extension": "^2.13.8",
6666
"redux-notifications": "^4.0.1",
6767
"redux-thunk": "^2.3.0",
68+
"remark-gfm": "1.0.0",
6869
"sanitize-filename": "^1.6.1",
6970
"semaphore": "^1.0.5",
7071
"tomlify-j0.4": "^3.0.0-alpha.0",

packages/netlify-cms-core/src/components/Editor/EditorControlPane/EditorControl.js

+3-1
Original file line numberDiff line numberDiff line change
@@ -9,6 +9,7 @@ import { partial, uniqueId } from 'lodash';
99
import { connect } from 'react-redux';
1010
import { FieldLabel, colors, transitions, lengths, borders } from 'netlify-cms-ui-default';
1111
import ReactMarkdown from 'react-markdown';
12+
import gfm from 'remark-gfm';
1213

1314
import { resolveWidget, getEditorComponents } from '../../../lib/registry';
1415
import { clearFieldErrors, tryLoadEntry, validateMetaField } from '../../../actions/entries';
@@ -330,7 +331,8 @@ class EditorControl extends React.Component {
330331
{fieldHint && (
331332
<ControlHint active={isSelected || this.state.styleActive} error={hasErrors}>
332333
<ReactMarkdown
333-
allowedElements={['a', 'strong', 'em']}
334+
remarkPlugins={[gfm]}
335+
allowedElements={['a', 'strong', 'em', 'del']}
334336
unwrapDisallowed={true}
335337
components={{
336338
// eslint-disable-next-line no-unused-vars

website/content/docs/widgets.md

+1-1
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,7 @@ To see working examples of all of the built-in widgets, try making a 'Kitchen Si
1515
The following options are available on all fields:
1616

1717
- `required`: specify as `false` to make a field optional; defaults to `true`
18-
- `hint`: optionally add helper text directly below a widget. Useful for including instructions. Accepts markdown for bold, italic, and links.
18+
- `hint`: optionally add helper text directly below a widget. Useful for including instructions. Accepts markdown for bold, italic, strikethrough, and links.
1919
- `pattern`: add field validation by specifying a list with a [regex pattern](https://regexr.com/) and an error message; more extensive validation can be achieved with [custom widgets](../custom-widgets/#advanced-field-validation)
2020
- **Example:**
2121
```yaml

yarn.lock

+113-2
Original file line numberDiff line numberDiff line change
@@ -12299,6 +12299,13 @@ markdown-table@^1.1.0:
1229912299
resolved "https://registry.yarnpkg.com/markdown-table/-/markdown-table-1.1.3.tgz#9fcb69bcfdb8717bfd0398c6ec2d93036ef8de60"
1230012300
integrity sha512-1RUZVgQlpJSPWYbFSpmudq5nHY1doEIv89gBtF0s4gW1GF2XorxcA/70M5vq7rLv0a6mhOUccRsqkwhwLCIQ2Q==
1230112301

12302+
markdown-table@^2.0.0:
12303+
version "2.0.0"
12304+
resolved "https://registry.yarnpkg.com/markdown-table/-/markdown-table-2.0.0.tgz#194a90ced26d31fe753d8b9434430214c011865b"
12305+
integrity sha512-Ezda85ToJUBhM6WGaG6veasyym+Tbs3cMAw/ZhOPqXiYsr0jgocBV3j3nx+4lk47plLlIqjwuTm/ywVI+zjJ/A==
12306+
dependencies:
12307+
repeat-string "^1.0.0"
12308+
1230212309
markdown-to-jsx@^6.11.4:
1230312310
version "6.11.4"
1230412311
resolved "https://registry.yarnpkg.com/markdown-to-jsx/-/markdown-to-jsx-6.11.4.tgz#b4528b1ab668aef7fe61c1535c27e837819392c5"
@@ -12347,6 +12354,15 @@ mdast-util-definitions@^4.0.0:
1234712354
dependencies:
1234812355
unist-util-visit "^2.0.0"
1234912356

12357+
mdast-util-find-and-replace@^1.1.0:
12358+
version "1.1.1"
12359+
resolved "https://registry.yarnpkg.com/mdast-util-find-and-replace/-/mdast-util-find-and-replace-1.1.1.tgz#b7db1e873f96f66588c321f1363069abf607d1b5"
12360+
integrity sha512-9cKl33Y21lyckGzpSmEQnIDjEfeeWelN5s1kUW1LwdB0Fkuq2u+4GdqcGEygYxJE8GVqCl0741bYXHgamfWAZA==
12361+
dependencies:
12362+
escape-string-regexp "^4.0.0"
12363+
unist-util-is "^4.0.0"
12364+
unist-util-visit-parents "^3.0.0"
12365+
1235012366
mdast-util-from-markdown@^0.8.0:
1235112367
version "0.8.5"
1235212368
resolved "https://registry.yarnpkg.com/mdast-util-from-markdown/-/mdast-util-from-markdown-0.8.5.tgz#d1ef2ca42bc377ecb0463a987910dae89bd9a28c"
@@ -12358,6 +12374,48 @@ mdast-util-from-markdown@^0.8.0:
1235812374
parse-entities "^2.0.0"
1235912375
unist-util-stringify-position "^2.0.0"
1236012376

12377+
mdast-util-gfm-autolink-literal@^0.1.0:
12378+
version "0.1.3"
12379+
resolved "https://registry.yarnpkg.com/mdast-util-gfm-autolink-literal/-/mdast-util-gfm-autolink-literal-0.1.3.tgz#9c4ff399c5ddd2ece40bd3b13e5447d84e385fb7"
12380+
integrity sha512-GjmLjWrXg1wqMIO9+ZsRik/s7PLwTaeCHVB7vRxUwLntZc8mzmTsLVr6HW1yLokcnhfURsn5zmSVdi3/xWWu1A==
12381+
dependencies:
12382+
ccount "^1.0.0"
12383+
mdast-util-find-and-replace "^1.1.0"
12384+
micromark "^2.11.3"
12385+
12386+
mdast-util-gfm-strikethrough@^0.2.0:
12387+
version "0.2.3"
12388+
resolved "https://registry.yarnpkg.com/mdast-util-gfm-strikethrough/-/mdast-util-gfm-strikethrough-0.2.3.tgz#45eea337b7fff0755a291844fbea79996c322890"
12389+
integrity sha512-5OQLXpt6qdbttcDG/UxYY7Yjj3e8P7X16LzvpX8pIQPYJ/C2Z1qFGMmcw+1PZMUM3Z8wt8NRfYTvCni93mgsgA==
12390+
dependencies:
12391+
mdast-util-to-markdown "^0.6.0"
12392+
12393+
mdast-util-gfm-table@^0.1.0:
12394+
version "0.1.6"
12395+
resolved "https://registry.yarnpkg.com/mdast-util-gfm-table/-/mdast-util-gfm-table-0.1.6.tgz#af05aeadc8e5ee004eeddfb324b2ad8c029b6ecf"
12396+
integrity sha512-j4yDxQ66AJSBwGkbpFEp9uG/LS1tZV3P33fN1gkyRB2LoRL+RR3f76m0HPHaby6F4Z5xr9Fv1URmATlRRUIpRQ==
12397+
dependencies:
12398+
markdown-table "^2.0.0"
12399+
mdast-util-to-markdown "~0.6.0"
12400+
12401+
mdast-util-gfm-task-list-item@^0.1.0:
12402+
version "0.1.6"
12403+
resolved "https://registry.yarnpkg.com/mdast-util-gfm-task-list-item/-/mdast-util-gfm-task-list-item-0.1.6.tgz#70c885e6b9f543ddd7e6b41f9703ee55b084af10"
12404+
integrity sha512-/d51FFIfPsSmCIRNp7E6pozM9z1GYPIkSy1urQ8s/o4TC22BZ7DqfHFWiqBD23bc7J3vV1Fc9O4QIHBlfuit8A==
12405+
dependencies:
12406+
mdast-util-to-markdown "~0.6.0"
12407+
12408+
mdast-util-gfm@^0.1.0:
12409+
version "0.1.2"
12410+
resolved "https://registry.yarnpkg.com/mdast-util-gfm/-/mdast-util-gfm-0.1.2.tgz#8ecddafe57d266540f6881f5c57ff19725bd351c"
12411+
integrity sha512-NNkhDx/qYcuOWB7xHUGWZYVXvjPFFd6afg6/e2g+SV4r9q5XUcCbV4Wfa3DLYIiD+xAEZc6K4MGaE/m0KDcPwQ==
12412+
dependencies:
12413+
mdast-util-gfm-autolink-literal "^0.1.0"
12414+
mdast-util-gfm-strikethrough "^0.2.0"
12415+
mdast-util-gfm-table "^0.1.0"
12416+
mdast-util-gfm-task-list-item "^0.1.0"
12417+
mdast-util-to-markdown "^0.6.1"
12418+
1236112419
mdast-util-phrasing@^2.0.0:
1236212420
version "2.0.0"
1236312421
resolved "https://registry.yarnpkg.com/mdast-util-phrasing/-/mdast-util-phrasing-2.0.0.tgz#57e61f2be908be9f5fce54fcc2fa593687986267"
@@ -12396,7 +12454,7 @@ mdast-util-to-hast@^4.0.0:
1239612454
unist-util-visit "^1.1.0"
1239712455
xtend "^4.0.1"
1239812456

12399-
mdast-util-to-markdown@^0.6.0:
12457+
mdast-util-to-markdown@^0.6.0, mdast-util-to-markdown@^0.6.1, mdast-util-to-markdown@~0.6.0:
1240012458
version "0.6.5"
1240112459
resolved "https://registry.yarnpkg.com/mdast-util-to-markdown/-/mdast-util-to-markdown-0.6.5.tgz#b33f67ca820d69e6cc527a93d4039249b504bebe"
1240212460
integrity sha512-XeV9sDE7ZlOQvs45C9UKMtfTcctcaj/pGwH8YLbMHoMOXNNCn2LsqVQOqrF1+/NU8lKDAqozme9SCXWyo9oAcQ==
@@ -12550,7 +12608,52 @@ microevent.ts@~0.1.1:
1255012608
resolved "https://registry.yarnpkg.com/microevent.ts/-/microevent.ts-0.1.1.tgz#70b09b83f43df5172d0205a63025bce0f7357fa0"
1255112609
integrity sha512-jo1OfR4TaEwd5HOrt5+tAZ9mqT4jmpNAusXtyfNzqVm9uiSYFZlKM1wYL4oU7azZW/PxQW53wM0S6OR1JHNa2g==
1255212610

12553-
micromark@~2.11.0:
12611+
micromark-extension-gfm-autolink-literal@~0.5.0:
12612+
version "0.5.7"
12613+
resolved "https://registry.yarnpkg.com/micromark-extension-gfm-autolink-literal/-/micromark-extension-gfm-autolink-literal-0.5.7.tgz#53866c1f0c7ef940ae7ca1f72c6faef8fed9f204"
12614+
integrity sha512-ePiDGH0/lhcngCe8FtH4ARFoxKTUelMp4L7Gg2pujYD5CSMb9PbblnyL+AAMud/SNMyusbS2XDSiPIRcQoNFAw==
12615+
dependencies:
12616+
micromark "~2.11.3"
12617+
12618+
micromark-extension-gfm-strikethrough@~0.6.5:
12619+
version "0.6.5"
12620+
resolved "https://registry.yarnpkg.com/micromark-extension-gfm-strikethrough/-/micromark-extension-gfm-strikethrough-0.6.5.tgz#96cb83356ff87bf31670eefb7ad7bba73e6514d1"
12621+
integrity sha512-PpOKlgokpQRwUesRwWEp+fHjGGkZEejj83k9gU5iXCbDG+XBA92BqnRKYJdfqfkrRcZRgGuPuXb7DaK/DmxOhw==
12622+
dependencies:
12623+
micromark "~2.11.0"
12624+
12625+
micromark-extension-gfm-table@~0.4.0:
12626+
version "0.4.3"
12627+
resolved "https://registry.yarnpkg.com/micromark-extension-gfm-table/-/micromark-extension-gfm-table-0.4.3.tgz#4d49f1ce0ca84996c853880b9446698947f1802b"
12628+
integrity sha512-hVGvESPq0fk6ALWtomcwmgLvH8ZSVpcPjzi0AjPclB9FsVRgMtGZkUcpE0zgjOCFAznKepF4z3hX8z6e3HODdA==
12629+
dependencies:
12630+
micromark "~2.11.0"
12631+
12632+
micromark-extension-gfm-tagfilter@~0.3.0:
12633+
version "0.3.0"
12634+
resolved "https://registry.yarnpkg.com/micromark-extension-gfm-tagfilter/-/micromark-extension-gfm-tagfilter-0.3.0.tgz#d9f26a65adee984c9ccdd7e182220493562841ad"
12635+
integrity sha512-9GU0xBatryXifL//FJH+tAZ6i240xQuFrSL7mYi8f4oZSbc+NvXjkrHemeYP0+L4ZUT+Ptz3b95zhUZnMtoi/Q==
12636+
12637+
micromark-extension-gfm-task-list-item@~0.3.0:
12638+
version "0.3.3"
12639+
resolved "https://registry.yarnpkg.com/micromark-extension-gfm-task-list-item/-/micromark-extension-gfm-task-list-item-0.3.3.tgz#d90c755f2533ed55a718129cee11257f136283b8"
12640+
integrity sha512-0zvM5iSLKrc/NQl84pZSjGo66aTGd57C1idmlWmE87lkMcXrTxg1uXa/nXomxJytoje9trP0NDLvw4bZ/Z/XCQ==
12641+
dependencies:
12642+
micromark "~2.11.0"
12643+
12644+
micromark-extension-gfm@^0.3.0:
12645+
version "0.3.3"
12646+
resolved "https://registry.yarnpkg.com/micromark-extension-gfm/-/micromark-extension-gfm-0.3.3.tgz#36d1a4c089ca8bdfd978c9bd2bf1a0cb24e2acfe"
12647+
integrity sha512-oVN4zv5/tAIA+l3GbMi7lWeYpJ14oQyJ3uEim20ktYFAcfX1x3LNlFGGlmrZHt7u9YlKExmyJdDGaTt6cMSR/A==
12648+
dependencies:
12649+
micromark "~2.11.0"
12650+
micromark-extension-gfm-autolink-literal "~0.5.0"
12651+
micromark-extension-gfm-strikethrough "~0.6.5"
12652+
micromark-extension-gfm-table "~0.4.0"
12653+
micromark-extension-gfm-tagfilter "~0.3.0"
12654+
micromark-extension-gfm-task-list-item "~0.3.0"
12655+
12656+
micromark@^2.11.3, micromark@~2.11.0, micromark@~2.11.3:
1255412657
version "2.11.4"
1255512658
resolved "https://registry.yarnpkg.com/micromark/-/micromark-2.11.4.tgz#d13436138eea826383e822449c9a5c50ee44665a"
1255612659
integrity sha512-+WoovN/ppKolQOFIAajxi7Lu9kInbPxFuTBVEavFcL8eAfVstoc5MocPmqBeAdBOJV00uaVjegzH4+MA0DN/uA==
@@ -15619,6 +15722,14 @@ relateurl@^0.2.7:
1561915722
resolved "https://registry.yarnpkg.com/relateurl/-/relateurl-0.2.7.tgz#54dbf377e51440aca90a4cd274600d3ff2d888a9"
1562015723
integrity sha1-VNvzd+UUQKypCkzSdGANP/LYiKk=
1562115724

15725+
15726+
version "1.0.0"
15727+
resolved "https://registry.yarnpkg.com/remark-gfm/-/remark-gfm-1.0.0.tgz#9213643001be3f277da6256464d56fd28c3b3c0d"
15728+
integrity sha512-KfexHJCiqvrdBZVbQ6RopMZGwaXz6wFJEfByIuEwGf0arvITHjiKKZ1dpXujjH9KZdm1//XJQwgfnJ3lmXaDPA==
15729+
dependencies:
15730+
mdast-util-gfm "^0.1.0"
15731+
micromark-extension-gfm "^0.3.0"
15732+
1562215733
remark-parse@^6.0.3:
1562315734
version "6.0.3"
1562415735
resolved "https://registry.yarnpkg.com/remark-parse/-/remark-parse-6.0.3.tgz#c99131052809da482108413f87b0ee7f52180a3a"

0 commit comments

Comments
 (0)