Skip to content

Bug report: search results stop updating after dragging an operation #107

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
csmith opened this issue Apr 7, 2017 · 2 comments · May be fixed by deepcodeg/CyberChef#4, rx007/CyberChef#4 or Benjamin-KY/CyberChef#4

Comments

@csmith
Copy link
Contributor

csmith commented Apr 7, 2017

Summary

After performing a search and dragging an operation from the search results to the recipe, the search results can no longer be cleared or updated (i.e., you can't search for anything again without a page reload).

Example

Repro steps:

  1. Search for "hex"
  2. Drag "To hex" from the search results to the recipe
  3. Delete the search text [expecting the results to disappear; they don't]
  4. Try searching for anything else [expecting new results to appear; they don't]

This error occurs immediately after dragging the search result:

TypeError: t is null  scripts.js:1:1411855
	a.prototype.getTitle https://gchq.github.io/CyberChef/scripts.js:1:1411855
	a.prototype.hasContent https://gchq.github.io/CyberChef/scripts.js:1:1399487
	a.prototype.show https://gchq.github.io/CyberChef/scripts.js:1:1407656
	a.prototype.enter https://gchq.github.io/CyberChef/scripts.js:1:1406969
	r</<.proxy/n https://gchq.github.io/CyberChef/scripts.js:1:55634
	r</</t.event.special[e].handle https://gchq.github.io/CyberChef/scripts.js:1:144414
	r</t.event.dispatch https://gchq.github.io/CyberChef/scripts.js:1:140954
	r</t.event.add/v.handle https://gchq.github.io/CyberChef/scripts.js:1:139019

And then this error occurs with each subsequent interaction with the search box

TypeError: this.$element is null scripts.js:1:1410158
	a.prototype.hide https://gchq.github.io/CyberChef/scripts.js:1:1410158
	a.prototype.leave https://gchq.github.io/CyberChef/scripts.js:1:1407493
	r</<.proxy/n https://gchq.github.io/CyberChef/scripts.js:1:55634
	r</</t.event.special[e].handle https://gchq.github.io/CyberChef/scripts.js:1:144414
	r</t.event.dispatch https://gchq.github.io/CyberChef/scripts.js:1:140954
	r</t.event.add/v.handle https://gchq.github.io/CyberChef/scripts.js:1:139019

Environment

  • CyberChef compile time: 05/04/2017 22:10:27 UTC
  • User-Agent:
    Mozilla/5.0 (Macintosh; Intel Mac OS X 10.12; rv:52.0) Gecko/20100101 Firefox/52.0
@csmith
Copy link
Contributor Author

csmith commented Apr 7, 2017

Reproduces in Chrome 57 as well.

Uncompressed stack traces:

TypeError: $e is null  scripts.js:86115:5
	Tooltip.prototype.getTitle scripts.js:86115:5
	Popover.prototype.hasContent scripts.js:85302:12
	Tooltip.prototype.show scripts.js:85873:9
	Tooltip.prototype.enter scripts.js:85829:65
	__WEBPACK_AMD_DEFINE_RESULT__</<.proxy/proxy scripts.js:5043:11
	__WEBPACK_AMD_DEFINE_RESULT__</</jQuery.event.special[orig].handle scripts.js:15237:11
	__WEBPACK_AMD_DEFINE_RESULT__</jQuery.event.dispatch scripts.js:14883:16
	__WEBPACK_AMD_DEFINE_RESULT__</jQuery.event.add/elemData.handle scripts.js:14692:6
TypeError: this.$element is null scripts.js:86025:5
	Tooltip.prototype.hide scripts.js:86025:5
	Tooltip.prototype.leave scripts.js:85863:65
	__WEBPACK_AMD_DEFINE_RESULT__</<.proxy/proxy scripts.js:5043:11
	__WEBPACK_AMD_DEFINE_RESULT__</</jQuery.event.special[orig].handle scripts.js:15237:11
	__WEBPACK_AMD_DEFINE_RESULT__</jQuery.event.dispatch scripts.js:14883:16
	__WEBPACK_AMD_DEFINE_RESULT__</jQuery.event.add/elemData.handle scripts.js:14692:6

At commit 1770205

@n1474335
Copy link
Member

n1474335 commented Apr 7, 2017

Thanks for this @csmith, I had also noticed it. I will work on it later this weekend if no one gets to it before me. Without having looked into it in great detail, it must be related to the introduction of ES6 modules and webpack as it wasn't a problem before.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants