Skip to content

Adopt Poetry as package manager and Makefile to hold scripts #7

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
andredias opened this issue Sep 25, 2021 · 3 comments
Closed

Adopt Poetry as package manager and Makefile to hold scripts #7

andredias opened this issue Sep 25, 2021 · 3 comments

Comments

@andredias
Copy link
Contributor

I wonder if you are interested in adopting Poetry as the package management tool. It could also replace setup.py.

In addition, I'd also include a Makefile to store all development task scripts in one single file. I believe it would make the project simpler.

I contributed to another project recently with changes these: sabuhish/fastapi-mail#89

@delfick
Copy link
Owner

delfick commented Sep 25, 2021

Hello,

Thanks for the suggestion. I'm not a fan of poetry (tbf, haven't given it much of a chance) but I especially think for libraries, a setup.py is more appropriate.

Poetry tends to be more for applications than libraries.

And I also prefer separate scripts than a Makefile. Those tend to get quite messy and I almost never need more than the format, lint, test.sh trio I have in all my projects.

@delfick delfick closed this as completed Sep 25, 2021
@delfick
Copy link
Owner

delfick commented Oct 15, 2021

Also, sorry I was abrupt the other day. I was gonna ask if you wanted to make a change to functionality and then forgot. I imagine it was to play with the context vars?

@andredias
Copy link
Contributor Author

No problem. This issue is not related to the other one #8

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants