Skip to content

Various refactorings #119

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
4 tasks
delphidabbler opened this issue Jul 13, 2023 · 2 comments
Open
4 tasks

Various refactorings #119

delphidabbler opened this issue Jul 13, 2023 · 2 comments
Assignees
@delphidabbler
Labels
considering Issue under consideration. May be accepted or rejected deferred-major-v Won't be implemented until a later major version. refactoring This issue requires refactoring only, not a change in functionality Vault Issue affects CodeSnip Vault, not the main CodeSnip program

Comments

@delphidabbler
Copy link
Owner

delphidabbler commented Jul 13, 2023 •
edited
Loading

These suggestions have been in draft for quite some time. Need to check if they're still valid.

  • UXMLDocHelper: Separate out generic helper code from snippets XML file specific code. Put generic code in super-class?
  • FmMain: Rename TMainForm.ActSubmitOrExportUpdate it is no longer shared
  • FmAbout: Change frmProgram type - it's no longer a HTML template
  • Extract TAligner embedded classes from the two "First Run" forms into separate unit and use that instead. Both classes are identical.
@delphidabbler delphidabbler converted this from a draft issue Jul 13, 2023
@delphidabbler delphidabbler changed the title Refactoring Various refactorings Jul 13, 2023
@delphidabbler delphidabbler self-assigned this Jul 13, 2023
@delphidabbler delphidabbler added considering Issue under consideration. May be accepted or rejected refactoring This issue requires refactoring only, not a change in functionality labels Jul 13, 2023
@delphidabbler
Copy link
Owner Author

  • UXMLDocHelper: Separate out generic helper code from snippets XML file specific code. Put generic code in super-class?

Put generic code into UXMLDocumentEx (did this in ddabapps/swagview).

@delphidabbler delphidabbler added the deferred-major-v Won't be implemented until a later major version. label Apr 15, 2025
@delphidabbler
Copy link
Owner Author

This has been done in the vault branch.

Doing it in CodeSnip 4 may be more trouble than it's worth if vault succeeds.

So deferring until it's clear whether vault will succeed.

@delphidabbler delphidabbler added the Vault Issue affects CodeSnip Vault, not the main CodeSnip program label Apr 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@delphidabbler delphidabbler

Labels
considering Issue under consideration. May be accepted or rejected deferred-major-v Won't be implemented until a later major version. refactoring This issue requires refactoring only, not a change in functionality Vault Issue affects CodeSnip Vault, not the main CodeSnip program
Projects
CodeSnip
Status: Considering
Milestone
No milestone
Development

No branches or pull requests
1 participant
@delphidabbler