fix(views): calendar view broken after theme toggle (#3765)

* fix(views): broken calendar view on theme toggle

This commit just removes a default value for the `initialTheme`
parameter inside the views util `getWebviewContent`.

`genVSCodeHTMLIndex`, which is called with a forwarded `initialTheme`,
has a codepath for an undefined `initialTheme` parameter.
It means that no theme is going to override the default theme and
therefore a certain ordering of css file references is taking place.

So by always providing a default theme this codepath is never taken and
results into a broken calendar view when toggling theme value.

Removing that makes sure that the default theme is setup in way that
keeps proper style ordering in place.

That default theme was added as a solution for
[[dendron://private/task.2022.05.31.fix-styling-for-plugin-views]] does
not seam to be necessary for that.

* chore(internal): fix invalid test-workspace note

Author: namjul

packages/plugin-core/src/views/utils.ts

@@ -7,7 +7,6 @@ import {
   DUtils,
   getStage,
   getWebTreeViewEntry,
-  ThemeType,
 } from "@dendronhq/common-all";
 import {
   findUpTo,
@@ -117,13 +116,6 @@ export class WebViewUtils {
         .toString();
     });
 
-    const vscodeColorTheme = vscode.window.activeColorTheme.kind;
-    const defaultInitialTheme =
-      vscodeColorTheme === vscode.ColorThemeKind.Dark ||
-      vscodeColorTheme === vscode.ColorThemeKind.HighContrast
-        ? ThemeType.DARK
-        : ThemeType.LIGHT;
-
     const out = WebViewCommonUtils.genVSCodeHTMLIndex({
       jsSrc: panel.webview.asWebviewUri(jsSrc).toString(),
       cssSrc: panel.webview.asWebviewUri(cssSrc).toString(),
@@ -144,7 +136,7 @@ export class WebViewUtils {
       // and hand it out to any other functions that need to use it.
       acquireVsCodeApi: `const vscode = acquireVsCodeApi(); window.vscode = vscode;`,
       themeMap: themeMap as WebViewThemeMap,
-      initialTheme: initialTheme ?? defaultInitialTheme,
+      initialTheme,
       name,
     });
     return out;