remove legacy fallback code and add tests for isNil

Author: talentlessguy

bindings/core.ts

@@ -45,12 +45,6 @@ function bindAlloc(solJson: SolJson) {
     null,
   )
 
-  // the fallback malloc is not a cwrap function and should just be returned
-  // directly in-case the alloc binding could not happen.
-  if (isNil(allocBinding)) {
-    return solJson._malloc
-  }
-
   return allocBinding
 }
 

common.ts

@@ -1,14 +1 @@
-export const formatFatalError = (message: string) =>
-  JSON.stringify({
-    errors: [
-      {
-        type: 'JSONError',
-        component: 'solcjs',
-        severity: 'error',
-        message: message,
-        formattedMessage: 'Error: ' + message,
-      },
-    ],
-  })
-
 export const isNil = (value: unknown): value is null => value == null

common_test.ts

@@ -0,0 +1,12 @@
+import { isNil } from './common.ts'
+import { expect } from '@std/expect'
+import { describe, it } from '@std/testing/bdd'
+
+describe('common.ts', () => {
+  it('isNil', () => {
+    expect(isNil(null)).toBe(true)
+    expect(isNil(undefined)).toBe(true)
+    expect(isNil(0)).toBe(false)
+    expect(isNil('')).toBe(false)
+  })
+})

deno.lock

@@ -18,7 +18,7 @@ contract HelloWorld {
 }
 `
 
-describe('solc/wrapper.ts', () => {
+describe('Wrapper', () => {
   let solc: Wrapper
   beforeAll(async () => {
     await download('./soljson_test.cjs', '0.8.18')