Skip to content

Commit 884faaf

Browse files
Jwatacopybara-github
authored andcommitted
siso: Merge remote-{library, exec}-link configs to remote-link
It doesn't need to distinguish between library and executable linking anymore. Bug: 370860664 Change-Id: Ic88c24f382e38501fa94591c81b6906e84640938 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5907590 Auto-Submit: Junji Watanabe <[email protected]> Commit-Queue: Junji Watanabe <[email protected]> Reviewed-by: Fumitoshi Ukai <[email protected]> Reviewed-by: Takuto Ikuta <[email protected]> Cr-Commit-Position: refs/heads/main@{#1364818} NOKEYCHECK=True GitOrigin-RevId: 430ca12968c848281ec5d9eaad46b90e363ea927
1 parent afb8dc4 commit 884faaf

File tree

2 files changed

+10
-7
lines changed

2 files changed

+10
-7
lines changed

config/siso/clang_linux.star

+3-3
Original file line numberDiff line numberDiff line change
@@ -216,7 +216,7 @@ def __step_config(ctx, step_config):
216216
"*.py",
217217
"*.stamp",
218218
],
219-
"remote": config.get(ctx, "remote-library-link"),
219+
"remote": config.get(ctx, "remote-link"),
220220
"canonicalize_dir": True,
221221
"timeout": "2m",
222222
"platform_ref": "large",
@@ -241,7 +241,7 @@ def __step_config(ctx, step_config):
241241
"*.py",
242242
"*.stamp",
243243
],
244-
"remote": config.get(ctx, "remote-library-link"),
244+
"remote": config.get(ctx, "remote-link"),
245245
"canonicalize_dir": True,
246246
"platform_ref": "large",
247247
"timeout": "2m",
@@ -265,7 +265,7 @@ def __step_config(ctx, step_config):
265265
"*.py",
266266
"*.stamp",
267267
],
268-
"remote": config.get(ctx, "remote-exec-link"),
268+
"remote": config.get(ctx, "remote-link"),
269269
"canonicalize_dir": True,
270270
"platform_ref": "large",
271271
"timeout": "10m",

config/siso/config.star

+7-4
Original file line numberDiff line numberDiff line change
@@ -20,9 +20,12 @@ __KNOWN_CONFIG_OPTIONS = [
2020
# TODO: b/308405411 - Enable this config for all builders.
2121
"remote-devtools-frontend-typescript",
2222

23-
# TODO: b/316267242 - Enable remote links after confirming performance.
24-
"remote-library-link",
25-
"remote-exec-link",
23+
# TODO: b/370860664 - Enable remote link by default after supporting
24+
# all platforms and target OSes.
25+
# For developers, we can't simply enable remote link without bytes
26+
# because developers need objects and tests locally for debugging
27+
# and testing.
28+
"remote-link",
2629
]
2730

2831
def __check(ctx):
@@ -50,7 +53,7 @@ def __get(ctx, key):
5053
# disable race strategy as "builder".
5154
# enable "remote-*" on cog
5255
# TODO: b/308405411 - enable "remote-devtools-frontend-typescript"
53-
if key in ("builder", "cog", "remote-library-link", "remote-exec-link"):
56+
if key in ("builder", "cog", "remote-link"):
5457
return True
5558
return False
5659

0 commit comments

Comments
 (0)