Bug compatibility with scala/bug/issues/11253

densh · densh · commit bf6b17abc2dd · 2018-11-15T11:28:27.000+01:00
Scalac mistakingly uses Double precision when performing
primitive binary operations on Long that take a Float
argument. Once this bug is fixed upstream we can conditionally
enable the workaround only on affected versions.
diff --git a/nscplugin/src/main/scala/scala/scalanative/nscplugin/NirGenExpr.scala b/nscplugin/src/main/scala/scala/scalanative/nscplugin/NirGenExpr.scala
@@ -985,6 +985,9 @@ trait NirGenExpr { self: NirGenPhase =>
     }
 
     def binaryOperationType(lty: nir.Type, rty: nir.Type) = (lty, rty) match {
+      // Bug compatibility with scala/bug/issues/11253
+      case (Type.Long, Type.Float) =>
+        Type.Double
       case (nir.Type.Ptr, _: nir.Type.RefKind) =>
         lty
       case (_: nir.Type.RefKind, nir.Type.Ptr) =>

Original file line number	Diff line number	Diff line change
`@@ -985,6 +985,9 @@ trait NirGenExpr { self: NirGenPhase =>`
`985`	`985`	`}`
`986`	`986`
`987`	`987`	`def binaryOperationType(lty: nir.Type, rty: nir.Type) = (lty, rty) match {`
	`988`	`+ // Bug compatibility with scala/bug/issues/11253`
	`989`	`+ case (Type.Long, Type.Float) =>`
	`990`	`+ Type.Double`
`988`	`991`	`case (nir.Type.Ptr, _: nir.Type.RefKind) =>`
`989`	`992`	`lty`
`990`	`993`	`case (_: nir.Type.RefKind, nir.Type.Ptr) =>`