Skip to content

Commit 3f13aa1

Browse files
authored
fix(all-rules): fix flakey all-rules firefox test (#4467)
wilco and I believe marque is to blame because it is animated This fixes the `all-rules` check, particularly on Firefox. We believe the issue is because marque has a moving bounding client rect, leading to inconsistent results. So instead we set the motion to none for a consistent testing environment. --- To see that it works, I've run the CI tests on this branch five times. It only failed on one unrelated flakey test this does not address. Also, #4456 finally builds after many consistent test failures in the same place in a row after rebasing on this change. We can see this test failing on other branches, such as `develop` in places like this: https://app.circleci.com/pipelines/github/dequelabs/axe-core/6332/workflows/b3e2a293-c89b-4201-898d-1c6c64ee2764 which shows it has nothing to do with the other PR.
1 parent f584e8e commit 3f13aa1

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

test/integration/full/all-rules/all-rules.html

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -94,7 +94,7 @@ <h2>Ok</h2>
9494
<p tabindex="-1">Paragraph.</p>
9595
<input type="button" />
9696
<input type="image" src="img.jpg" />
97-
<marquee>This content is inside a marquee.</marquee>
97+
<marquee scrollamount="0">This content is inside a marquee.</marquee>
9898
<div role="navigation">
9999
<div role="banner"></div>
100100
<div role="complementary"></div>

0 commit comments

Comments
 (0)