You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
fix(all-rules): fix flakey all-rules firefox test (#4467)
wilco and I believe marque is to blame because it is animated
This fixes the `all-rules` check, particularly on Firefox. We believe
the issue is because marque has a moving bounding client rect, leading
to inconsistent results. So instead we set the motion to none for a
consistent testing environment.
---
To see that it works, I've run the CI tests on this branch five times.
It only failed on one unrelated flakey test this does not address.
Also, #4456 finally builds
after many consistent test failures in the same place in a row after
rebasing on this change.
We can see this test failing on other branches, such as `develop` in
places like this:
https://app.circleci.com/pipelines/github/dequelabs/axe-core/6332/workflows/b3e2a293-c89b-4201-898d-1c6c64ee2764
which shows it has nothing to do with the other PR.
0 commit comments