Skip to content

Commit 656f6df

Browse files
authored
fix: drop Meta cache during update (frappe#18182)
1 parent 1c06b33 commit 656f6df

File tree

4 files changed

+10
-2
lines changed

4 files changed

+10
-2
lines changed

frappe/model/meta.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -56,7 +56,7 @@
5656

5757

5858
def get_meta(doctype, cached=True) -> "Meta":
59-
if not cached:
59+
if not cached or frappe.flags.in_patch:
6060
return Meta(doctype)
6161

6262
if meta := frappe.cache().hget("meta", doctype):

frappe/patches.txt

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -211,5 +211,6 @@ frappe.patches.v14_0.set_suspend_email_queue_default
211211
frappe.patches.v14_0.different_encryption_key
212212
frappe.patches.v14_0.update_multistep_webforms
213213
execute:frappe.delete_doc('Page', 'background_jobs', ignore_missing=True, force=True)
214+
frappe.patches.v14_0.drop_meta_cache
214215
frappe.patches.v14_0.drop_unused_indexes
215216
frappe.patches.v15_0.drop_modified_index
Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,7 @@
1+
import frappe
2+
3+
4+
def execute():
5+
cache = frappe.cache()
6+
for key in cache.hkeys("meta"):
7+
cache.hdel("meta", key)

frappe/tests/test_perf.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -74,7 +74,7 @@ def test_req_per_seconds_basic(self):
7474
"""Ideally should be ran against gunicorn worker, though I have not seen any difference
7575
when using werkzeug's run_simple for synchronous requests."""
7676

77-
EXPECTED_RPS = 55 # measured on GHA
77+
EXPECTED_RPS = 50 # measured on GHA
7878
FAILURE_THREASHOLD = 0.1
7979

8080
req_count = 1000

0 commit comments

Comments
 (0)