feat: add multiple file support #6
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closes #2 BREAKING CHANGE: `pathToSpec` renamed to `pathsToSpec` and it is `string[]` now instead of `string`
Merged
|
@raveclassic, please review this PR |
raveclassic
suggested changes
Dec 11, 2018
package.json
Outdated
| @@ -6,7 +6,7 @@ | |||
| "scripts": { | |||
| "ts-node": "ts-node", | |||
| "tslint": "tslint -c tslint.json --project tsconfig.json './src/**/*.ts' './test/**/*.ts'", | |||
| "test": "npm run tslint && npm run prettier && ts-node ./test/index.ts", | |||
| "test": "rm -rf ./test/out && npm run tslint && npm run prettier && ts-node ./test/index.ts", | |||
There was a problem hiding this comment.
Won't work in cmd. You can add rimraf to dependencies and use it as cli.
src/index.ts
Outdated
| }; | ||
| }; | ||
|
|
||
| const decode = (json: TJSON): Either<ValidationError[], TSwaggerObject> => { |
src/index.ts
Outdated
| fileName: string; | ||
| }; | ||
|
|
||
| const read = async (_pathToFile: string): Promise<TBuffer> => { |
There was a problem hiding this comment.
please don't use _naming
src/language/typescript.ts
Outdated
| @@ -218,10 +220,29 @@ const serializePath = (url: string, item: TPathItemObject, rootName: string, cwd | |||
| const serializeSchemaObject = (schema: TSchemaObject, rootName: string, cwd: string): TSerializedType => { | |||
| switch (schema.type) { | |||
| case undefined: { | |||
| const type = `${schema.$ref.replace(/^#\/definitions\//g, '')}`; | |||
| const $ref = schema.$ref; | |||
| const defBlock = fromNullable($ref.match(/#\/[^\/]+\//)) | |||
There was a problem hiding this comment.
What are you trying to achieve here? I believe everything can be rewritten with a single match
There was a problem hiding this comment.
replaced with a single match
| @@ -0,0 +1,182 @@ | |||
| { | |||
There was a problem hiding this comment.
Default identation for json files is 2 spaces. See .editorconfig
There was a problem hiding this comment.
there is nothing about json in the .editorconfig
but i changed it to 2 spaces
review fixes
raveclassic
approved these changes
Dec 13, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #2
BREAKING CHANGE:
pathToSpecrenamed topathsToSpecand it isstring[]now instead ofstring