Skip to content

Implement PodSecurity admission checks in the devfile/library #1017

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
valaparthvi opened this issue Jan 31, 2023 · 3 comments
Closed

Implement PodSecurity admission checks in the devfile/library #1017

valaparthvi opened this issue Jan 31, 2023 · 3 comments
Labels
area/library Common devfile library for interacting with devfiles

Comments

@valaparthvi
Copy link

valaparthvi commented Jan 31, 2023

Which area this feature is related to?

/area library

Which functionality do you think we should add?

As an odo user, I want to be able to run my application with standard Devfile even if the cluster that I'm using enforces security policies using PodSecurity Admission controller.

Why is this needed? Is your feature request related to a problem?
This feature will help tools such as odo to run a Devfile specification on a cluster that had these additional checks in place.

This problem will likely be faced by other tools that need to run the Devfile specification on a cluster and it makes sense to fix this problem inside the devfile/library.

Detailed description:

Describe the solution you'd like

To fix this, we propose to use https://github.com/kubernetes/pod-security-admission to analyze such checks and fix the failed checks within the devfile/library by modifying pod specs.

We do not expect the library to go online or fetch these policies, odo will pass the pod spec and the policies and library can modify the pod spec to satisfy the policy.

@feloy has created a POC to show how the pod-security-admission library can be used.
POC: https://github.com/feloy/podsecurity-admission-test

Describe alternatives you've considered

Alternatively, we could implement this within odo.

Additional context

redhat-developer/odo#6339
https://github.com/feloy/podsecurity-admission-test
https://github.com/kubernetes/pod-security-admission

cc: @kadel

@openshift-ci openshift-ci bot added the area/library Common devfile library for interacting with devfiles label Jan 31, 2023
@maysunfaisal
Copy link
Member

Need to confirm if its already done and close this

@feloy
Copy link
Contributor

feloy commented Jul 21, 2023

Should be fixed by devfile/library#165

@maysunfaisal
Copy link
Member

Closing as its implemented

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/library Common devfile library for interacting with devfiles
Projects
Status: Done ✅
Development

No branches or pull requests

3 participants