Skip to content

Implement changes in deployment specification under devfile registry helm chart #1430

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
4 tasks done
Tracked by #1274
michael-valdron opened this issue Feb 1, 2024 · 0 comments · Fixed by devfile/registry-support#221
Closed
4 tasks done
Tracked by #1274
Assignees
Labels
area/registry Devfile registry for stacks and infrastructure

Comments

@michael-valdron
Copy link
Member

michael-valdron commented Feb 1, 2024

Which area/kind this issue is related to?

/area registry

Issue Description

To create consistancy with the registry operator within the helm chart, the following changes need to be done:

  • Outdated probe time values need to be updated

Index Server - startupProbe

Timeouts on the helm chart should be updated to the timeouts on the registry operator:

initialDelaySeconds: 30
periodSeconds: 10
timeoutSeconds: 20

Registry Viewer - livenessProbe

Timeouts on the helm chart should be updated to the timeouts on the registry operator:

initialDelaySeconds: 15
periodSeconds: 10
timeoutSeconds: 20

Registry Viewer - readinessProbe

Timeouts on the helm chart should be updated to the timeouts on the registry operator:

initialDelaySeconds: 15
periodSeconds: 10
timeoutSeconds: 20

Parent Epic: #1274

Acceptance Criteria

  • Set probe time values under helm chart to match same probes under registry operator
  • Define pod level security context under helm chart to match registry operator
  • Remove .env mount from the helm chart
  • Check deployment integrity of changes
@openshift-ci openshift-ci bot added the area/registry Devfile registry for stacks and infrastructure label Feb 1, 2024
@Jdubrick Jdubrick self-assigned this Feb 20, 2024
@Jdubrick Jdubrick moved this to Refinement in Devfile Project Feb 20, 2024
@thepetk thepetk moved this from Refinement to Backlog in Devfile Project Feb 21, 2024
@Jdubrick Jdubrick moved this from Backlog to To Do 📝 in Devfile Project Feb 21, 2024
@Jdubrick Jdubrick moved this from To Do 📝 to In Progress 🚧 in Devfile Project Mar 6, 2024
@Jdubrick Jdubrick moved this from In Progress 🚧 to Done ✅ in Devfile Project Mar 8, 2024
@Jdubrick Jdubrick moved this from Done ✅ to In Review 👀 in Devfile Project Mar 8, 2024
@github-project-automation github-project-automation bot moved this from In Review 👀 to Done ✅ in Devfile Project Mar 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/registry Devfile registry for stacks and infrastructure
Projects
Status: Done ✅
Development

Successfully merging a pull request may close this issue.

2 participants