Skip to content

Remove devfile.projects[].github #340

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
benoitf opened this issue Feb 10, 2021 · 2 comments · Fixed by #439
Closed

Remove devfile.projects[].github #340

benoitf opened this issue Feb 10, 2021 · 2 comments · Fixed by #439
Assignees
Labels
area/api Enhancement or issue related to the api/devfile specification
Milestone

Comments

@benoitf
Copy link
Contributor

benoitf commented Feb 10, 2021

Is your feature request related to a problem? Please describe.
when referencing a project I have git or github parameter but they're equals so github brings no value there as we don't change the way of defining a project like

github:
   - organization: eclipse
   - repository: che

but as we specify the full url to the repo it's useless

Describe the solution you'd like
remove github as it brings confusion or make it fancier to define a github repository but if it's just to paste the git url there is no value.

Describe alternatives you've considered
N/A

Additional context
N/A

@johnmcollier johnmcollier added the area/api Enhancement or issue related to the api/devfile specification label Feb 10, 2021
@elsony
Copy link
Contributor

elsony commented Feb 16, 2021

git and github are duplicated. So we'll deprecate github and recommend users to use git. Adding doc to existing github field to advise users to use git instead of github.

@elsony
Copy link
Contributor

elsony commented Apr 27, 2021

The github duplicate with the existing git setting. Instead of deprecating github, we have decided to remove github support in devfile 2.1 before user starts to use it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/api Enhancement or issue related to the api/devfile specification
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants