Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid hardcoding Segment write key #769

Closed
kim-tsao opened this issue Feb 10, 2022 · 1 comment
Closed

Avoid hardcoding Segment write key #769

kim-tsao opened this issue Feb 10, 2022 · 1 comment
Assignees
Labels
area/registry Devfile registry for stacks and infrastructure area/telemetry telemetry related issues

Comments

@kim-tsao
Copy link
Contributor

Which area/kind this issue is related to?

/area registry
/area telemetry

Issue Description

Users setting up their own index server could turn on telemetry and that would result in data being sent to our servers since the write key is hardcoded. We should avoid this scenario and ensure the write key is set in some environment variable, either specified by the user or by us.

@openshift-ci openshift-ci bot added area/registry Devfile registry for stacks and infrastructure area/telemetry telemetry related issues labels Feb 10, 2022
@kim-tsao kim-tsao self-assigned this Feb 10, 2022
@kim-tsao
Copy link
Contributor Author

As discussed, we will be removing the enabled field since it's not necessary anymore. If a user specifies a telemetry key then we can assume they want telemetry to be enabled.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/registry Devfile registry for stacks and infrastructure area/telemetry telemetry related issues
Projects
None yet
Development

No branches or pull requests

1 participant