Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dotnet stacks are missing logos #845

Closed
deboer-tim opened this issue May 9, 2022 · 2 comments
Closed

Dotnet stacks are missing logos #845

deboer-tim opened this issue May 9, 2022 · 2 comments
Labels
kind/bug Something isn't working

Comments

@deboer-tim
Copy link

/kind bug

Which area this bug is related to?

/area registry

What versions of software are you using?

n/a

Bug Summary

Describe the bug:
The Dotnet devfiles all have an invalid icon, which is showing up as a missing link on the devfile registry, VS Code explorer, etc.

To Reproduce:
Open the registry...

Expected behaviour

No missing link icons.

Any logs, error output, screenshots etc? Provide the devfile that sees this bug, if applicable.

Screen Shot 2022-05-09 at 12 57 12 PM

Additional context

Suggestion on how to fix the bug

  1. We should fix the links in these specific devfiles.
  2. If an icon is missing we should show something other than the broken link - either use a placeholder or revert to what we do if there's no icon.
@openshift-ci openshift-ci bot added the kind/bug Something isn't working label May 9, 2022
@kadel
Copy link
Member

kadel commented May 10, 2022

I have opened PR to fix icon links (devfile/registry#110)

2. If an icon is missing we should show something other than the broken link - either use a placeholder or revert to what we do if there's no icon.

+1 for having a fallback in case the icon is not reachable.

@schultzp2020
Copy link
Contributor

fixed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants